references/openproject
1
0
Fork 0
mirror of https://github.com/opf/openproject.git synced 2026-06-14 03:30:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve test performance of work_package_form_resource

Browse Source 
Reduced execution time from ~4,5minutes to 40seconds with
`before_all` helper.

[ci skip]
This commit is contained in:
Oliver Günther
2017-08-31 14:32:18 +02:00
parent 342a30f7eb
commit 56ea4308c3
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/rails_helper.rb
+1
View File
@@ -32,6 +32,7 @@ require 'factory_girl_rails'
require 'rspec/rails'
require 'shoulda/matchers'
require 'rspec/example_disabler'
require 'test_prof/recipes/rspec/before_all'
##
# Start collecting coverage when desired
spec/requests/api/v3/work_packages/form/work_package_form_resource_spec.rb
+11 -5
View File
@@ -34,10 +34,17 @@ describe 'API v3 Work package form resource', type: :request do
include Capybara::RSpecMatchers
include API::V3::Utilities::PathHelper
let(:project) { FactoryGirl.create(:project, is_public: false) }
let(:work_package) { FactoryGirl.create(:work_package, project: project) }
let(:authorized_user) { FactoryGirl.create(:user, member_in_project: project) }
let(:unauthorized_user) { FactoryGirl.create(:user) }
before_all do
@project = FactoryGirl.create(:project, is_public: false)
@work_package = FactoryGirl.create(:work_package, project: @project)
@authorized_user = FactoryGirl.create(:user, member_in_project: @project)
@unauthorized_user = FactoryGirl.create(:user)
end
let(:project) { @project }
let(:work_package) { @work_package.reload }
let(:authorized_user) { @authorized_user }
let(:unauthorized_user) { @unauthorized_user }
describe '#post' do
let(:post_path) { api_v3_paths.work_package_form work_package.id }
@@ -58,7 +65,6 @@ describe 'API v3 Work package form resource', type: :request do
end
context 'user without needed permissions' do
let(:work_package) { FactoryGirl.create(:work_package, id: 42, project: project) }
let(:params) { {} }
include_context 'post request' do