references/openproject
1
0
Fork 0
mirror of https://github.com/opf/openproject.git synced 2026-06-14 03:30:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Type InjectField token as ProviderToken

Browse Source 
Replaces the `any`-typed token parameter with `ProviderToken<T>`, so a
non-token argument is now a compile error and `defaultValue`/getter share
that `T`. Runtime is unchanged. A property decorator cannot see the field
type, so a token/field mismatch is still uncatchable here; `inject()`
remains the safer option for DI-constructed classes.
This commit is contained in:
Alexander Brandon Coles
2026-06-04 17:08:18 +02:00
parent 3ba1df1fd3
commit 1a3bc3aa1d
1 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/app/shared/helpers/angular/inject-field.decorator.ts
+15 -12
View File
@@ -1,24 +1,27 @@
import 'reflect-metadata';
import { InjectOptions, Injector } from '@angular/core';
import { InjectOptions, Injector, ProviderToken } from '@angular/core';
import { debugLog } from 'core-app/shared/helpers/debug_output';
export interface InjectableClass {
injector:Injector;
}
export function InjectField(token?:any, defaultValue:any = null, options?:InjectOptions) {
return (target:InjectableClass, property:string) => {
// eslint-ignore-next-line no-param-reassign
if (delete (target as any)[property]) {
export function InjectField<T = unknown>(
token?:ProviderToken<T>,
defaultValue:T | null = null,
options?:InjectOptions,
) {
return (target:InjectableClass, property:string):void => {
if (delete (target as unknown as Record<string, unknown>)[property]) {
Object.defineProperty(target, property, {
get(this:InjectableClass) {
if (token) {
return this.injector.get<any>(token, defaultValue, options);
}
const type = Reflect.getMetadata('design:type', target, property);
return this.injector.get<any>(type, defaultValue, options);
get(this:InjectableClass):T | null {
// When no token is given, fall back to the property's reflected
// design type (requires emitDecoratorMetadata).
const resolvedToken = (token
?? Reflect.getMetadata('design:type', target, property)) as ProviderToken<T>;
return this.injector.get(resolvedToken, defaultValue, options);
},
set(this:InjectableClass) {
set(this:InjectableClass):void {
debugLog(`Trying to set InjectField property ${property}`);
},
});