references/openproject
1
0
Fork 0
mirror of https://github.com/opf/openproject.git synced 2026-06-13 19:20:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

rework readonly_attribute_errors variable in project update contract spec

Browse Source
This commit is contained in:
Ivan Kuchin
2026-02-25 15:45:14 +01:00
parent eb81b2060d
commit 0838ec3c80
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/contracts/projects/update_contract_spec.rb
+11 -5
View File
@@ -113,7 +113,13 @@ RSpec.describe Projects::UpdateContract do
end
describe "permissions" do
name_parent_identifier_readonly = %i[name parent_id identifier].index_with { %i[error_readonly] }
let(:readonly_attribute_errors) do
{
name: %i[error_readonly],
parent_id: %i[error_readonly],
identifier: %i[error_readonly]
}
end
shared_examples "contract is valid for custom values and/or comments" do
context "and custom values are changed" do
@@ -170,14 +176,14 @@ RSpec.describe Projects::UpdateContract do
end
include_examples "contract is invalid for custom values and/or comments" do
let(:errors) { name_parent_identifier_readonly }
let(:errors) { readonly_attribute_errors }
end
end
context "when project_attributes_only flag is false" do
let(:options) { { project_attributes_only: false } }
include_examples "contract is invalid", name_parent_identifier_readonly
it("is invalid") { expect_contract_invalid(readonly_attribute_errors) }
end
end
@@ -217,7 +223,7 @@ RSpec.describe Projects::UpdateContract do
let(:options) { { project_attributes_only: true } }
context "and only project attributes are changed" do
include_examples "contract is invalid", name_parent_identifier_readonly
it("is invalid") { expect_contract_invalid(readonly_attribute_errors) }
end
context "and project attributes are not changed" do
@@ -228,7 +234,7 @@ RSpec.describe Projects::UpdateContract do
context "and project attributes are changed" do
include_examples "contract is invalid for custom values and/or comments" do
let(:errors) { name_parent_identifier_readonly }
let(:errors) { readonly_attribute_errors }
end
end
end