Files
openproject/app/controllers/settings_controller.rb
T
ulferts c0b709530c Fix/replace deprecations (#5533)
* replace alias_method_chain

* remove deprecation silencing

* bump controller-testing

* introduce permitted params for settings

* replace various deprecations in controllers

* remove deprecation silencing for legacy_specs

* remove `puts` from spec

* replace deprecated access to errors

* remove unnecessary AR::Parameters usage in spec

* specify error to expect

* replace deprecations

* replace deprecated action calls in legacy function specs

* replace deprecations in functional controller tests

* replace deprecations in controllers/controller_specs

* remove params parser which does not seem to be in effect

It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code.

* replace deprecations in unit specs

* replace alias_method_chain

[ci skip]
2017-07-19 21:17:37 +02:00

90 lines
2.7 KiB
Ruby

#-- encoding: UTF-8
#-- copyright
# OpenProject is a project management system.
# Copyright (C) 2012-2017 the OpenProject Foundation (OPF)
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2017 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See doc/COPYRIGHT.rdoc for more details.
#++
class SettingsController < ApplicationController
layout 'admin'
before_action :require_admin
def index
edit
render action: 'edit'
end
def edit
@notifiables = Redmine::Notifiable.all
if request.post? && params[:settings]
permitted_params.settings.to_h.each do |name, value|
if value.is_a?(Array)
# remove blank values in array settings
value.delete_if(&:blank?)
elsif value.is_a?(Hash)
value.delete_if { |_, v| v.blank? }
else
value = value.strip
end
Setting[name] = value
end
flash[:notice] = l(:notice_successful_update)
redirect_to action: 'edit', tab: params[:tab]
else
@options = {}
@options[:user_format] = User::USER_FORMATS_STRUCTURE.keys.map { |f| [User.current.name(f), f.to_s] }
@deliveries = ActionMailer::Base.perform_deliveries
@guessed_host = request.host_with_port.dup
@custom_style = CustomStyle.current || CustomStyle.new
end
end
def plugin
@plugin = Redmine::Plugin.find(params[:id])
if request.post?
Setting["plugin_#{@plugin.id}"] = params[:settings].permit!.to_h
flash[:notice] = l(:notice_successful_update)
redirect_to action: 'plugin', id: @plugin.id
else
@partial = @plugin.settings[:partial]
@settings = Setting["plugin_#{@plugin.id}"]
end
rescue Redmine::PluginNotFound
render_404
end
def default_breadcrumb
l(:label_system_settings)
end
def show_local_breadcrumb
true
end
end