openproject

mirror of https://github.com/opf/openproject.git synced 2026-06-14 03:30:14 +00:00

Files

T

Christophe Bliard a06e519ed7 Set send_notifications only when not nil

When calling a service with `send_notifications: false`, the
`Journal::NotificationConfiguration.active?` will be set to `false` and
subsequent calls to set it to `true` will have no effect and log a
warning.

For this reason, it's better to use `nil` as default value for
`send_notifications` so that
`Journal::NotificationConfiguration.active?` is changed only when the
value is explicitly `true` or `false`, and ignored when the value is
`nil`.

2023-02-27 17:47:34 +01:00

concerns

Set send_notifications only when not nil

2023-02-27 17:47:34 +01:00

add_users_service.rb

Set send_notifications only when not nil

2023-02-27 17:47:34 +01:00

cleanup_inherited_roles_service.rb

Update copyright information for 2023

2022-12-30 15:51:26 +01:00

create_inherited_roles_service.rb

optimize creating memberships for groups