mirror of
https://github.com/opf/openproject.git
synced 2026-06-14 03:30:14 +00:00
Alexander Brandon Coles
4c55748cd8
Provides Project Status (BETA) widget as a Reference Implementation - this widget is currently based on the design of the Status form on the Project Settings > General page. In detail: - introduces a base `WidgetController` from which widget implementations should inherit. - adds `Overviews::Widgets::ProjectStatusComponent` and accompanying specs. Reuses existing forms. - adds `Overviews::Widgets::StatusController`` with custom `#update` action, routes and accompanying permissions. - makes the Project Status (BETA) widget available by registering in ng `OpenProjectGridsModule` and Rails grid modules configuration. N.B. The Project Status (BETA) widget is EXPERIMENTAL - it will require further visual refinement (in a follow up work package).
1134 lines
28 KiB
Ruby
1134 lines
28 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
#-- copyright
|
|
# OpenProject is an open source project management software.
|
|
# Copyright (C) the OpenProject GmbH
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License version 3.
|
|
#
|
|
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
|
|
# Copyright (C) 2006-2013 Jean-Philippe Lang
|
|
# Copyright (C) 2010-2013 the ChiliProject Team
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License
|
|
# as published by the Free Software Foundation; either version 2
|
|
# of the License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
#
|
|
# See COPYRIGHT and LICENSE files for more details.
|
|
#++
|
|
|
|
require "spec_helper"
|
|
|
|
RSpec.describe PermittedParams do
|
|
let(:user) { build_stubbed(:user) }
|
|
let(:admin) { build_stubbed(:admin) }
|
|
|
|
shared_context "with prepare params comparison" do
|
|
let(:params_key) { defined?(hash_key) ? hash_key : attribute }
|
|
let(:params) do
|
|
nested_params =
|
|
if defined?(nested_key)
|
|
{ nested_key => hash }
|
|
else
|
|
hash
|
|
end
|
|
|
|
ac_params =
|
|
if defined?(flat) && flat
|
|
nested_params
|
|
else
|
|
{ params_key => nested_params }
|
|
end
|
|
|
|
ActionController::Parameters.new(ac_params)
|
|
end
|
|
|
|
subject { described_class.new(params, user).send(attribute).to_h }
|
|
end
|
|
|
|
shared_examples_for "allows params" do
|
|
include_context "with prepare params comparison"
|
|
|
|
it do
|
|
expected = defined?(expected_allowed_params) ? expected_allowed_params : hash
|
|
expect(subject).to eq(expected)
|
|
end
|
|
end
|
|
|
|
shared_examples_for "allows nested params" do
|
|
include_context "with prepare params comparison"
|
|
|
|
it { expect(subject).to eq(hash) }
|
|
end
|
|
|
|
shared_examples_for "forbids params" do
|
|
include_context "with prepare params comparison"
|
|
|
|
it { expect(subject).not_to eq(hash) }
|
|
end
|
|
|
|
describe "#permit" do
|
|
it "adds an attribute to be permitted later" do
|
|
# just taking project_type here as an example, could be anything
|
|
|
|
# taking the originally whitelisted params to be restored later
|
|
original_whitelisted = described_class.instance_variable_get(:@whitelisted_params)
|
|
|
|
ActionController::Parameters.new(project_type: { "blubs1" => "blubs" })
|
|
|
|
described_class.instance_variable_set(:@whitelisted_params, original_whitelisted)
|
|
end
|
|
|
|
it "raises an argument error if key does not exist" do
|
|
expect { described_class.permit(:bogus_key) }.to raise_error ArgumentError
|
|
end
|
|
end
|
|
|
|
describe "#pref" do
|
|
let(:attribute) { :pref }
|
|
|
|
let(:hash) do
|
|
acceptable_params = %w(time_zone comments_sorting
|
|
warn_on_leaving_unsaved)
|
|
|
|
acceptable_params.index_with { |_x| "value" }
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "#news" do
|
|
let(:attribute) { :news }
|
|
let(:hash) do
|
|
%w(title summary description).index_with { |_x| "value" }.to_h
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "#comment" do
|
|
let(:attribute) { :comment }
|
|
let(:hash) do
|
|
%w(commented author comments).index_with { |_x| "value" }.to_h
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "#watcher" do
|
|
let(:attribute) { :watcher }
|
|
let(:hash) do
|
|
%w(watchable user user_id).index_with { |_x| "value" }.to_h
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "#reply" do
|
|
let(:attribute) { :reply }
|
|
let(:hash) do
|
|
%w(content subject).index_with { |_x| "value" }.to_h
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "#wiki" do
|
|
let(:attribute) { :wiki }
|
|
let(:hash) do
|
|
%w(start_page).index_with { |_x| "value" }.to_h
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "#membership" do
|
|
let(:attribute) { :membership }
|
|
let(:hash) do
|
|
{ "project_id" => "1", "role_ids" => ["1", "2", "4"] }
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "#category" do
|
|
let(:attribute) { :category }
|
|
let(:hash) do
|
|
%w(name assigned_to_id).index_with { |_x| "value" }.to_h
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "#version" do
|
|
let(:attribute) { :version }
|
|
|
|
context "with whitelisted params" do
|
|
let(:hash) do
|
|
%w(name description effective_date due_date
|
|
start_date wiki_page_title status sharing).index_with { |_x| "value" }.to_h
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
context "when empty" do
|
|
let(:hash) { {} }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
context "for custom field values" do
|
|
let(:hash) { { "custom_field_values" => { "1" => "5" } } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
end
|
|
|
|
describe "#message" do
|
|
let(:attribute) { :message }
|
|
|
|
context "with no instance passed" do
|
|
let(:expected_allowed_params) do
|
|
%w(subject content forum_id).index_with { |_x| "value" }.to_h
|
|
end
|
|
|
|
let(:hash) do
|
|
expected_allowed_params.merge(evil: "true", sticky: "true", locked: "true")
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
context "when empty" do
|
|
let(:hash) { {} }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
context "with project instance passed" do
|
|
let(:project) { instance_double(Project) }
|
|
let(:expected_allowed_params) do
|
|
{ "subject" => "value",
|
|
"content" => "value",
|
|
"forum_id" => "value",
|
|
"sticky" => "true",
|
|
"locked" => "true" }
|
|
end
|
|
|
|
let(:hash) do
|
|
ActionController::Parameters.new("message" => expected_allowed_params.merge(evil: "true"))
|
|
end
|
|
|
|
before do
|
|
mock_permissions_for(user) do |mock|
|
|
mock.allow_in_project :edit_messages, project:
|
|
end
|
|
end
|
|
|
|
subject { described_class.new(hash, user).message(project).to_h }
|
|
|
|
it do
|
|
expect(subject).to eq(expected_allowed_params)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#attachments" do
|
|
let(:attribute) { :attachments }
|
|
|
|
let(:hash) do
|
|
{ "file" => "myfile",
|
|
"description" => "mydescription" }
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "#project" do
|
|
let(:attribute) { :project }
|
|
|
|
describe "status_code" do
|
|
context "with valid status_code" do
|
|
let(:hash) { { "status_code" => "not_started" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
context "with empty status_code" do
|
|
let(:hash) { { "status_code" => "" } }
|
|
let(:expected_allowed_params) { { "status_code" => nil } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
end
|
|
|
|
describe "status_explanation" do
|
|
let(:hash) { { "status_explanation" => "Blah..." } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
end
|
|
|
|
describe "#new_project" do
|
|
let(:attribute) { :new_project }
|
|
let(:hash_key) { "project" }
|
|
|
|
context "with minimal params" do
|
|
let(:hash) { { "name" => "Brand New Project", "workspace_type" => "project" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
context "with parent_id" do
|
|
let(:hash) { { "name" => "Brand New Project", "workspace_type" => "project", "parent_id" => "19" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
context "with custom_field_values" do
|
|
let(:hash) { { "name" => "Brand New Project", "workspace_type" => "project", "custom_field_values" => { "4" => "21" } } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
end
|
|
|
|
describe "#copy_project_options" do
|
|
let(:attribute) { :copy_project_options }
|
|
let(:hash_key) { "copy_options" }
|
|
|
|
context "with minimal params" do
|
|
let(:hash) { { "dependencies" => [] } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
context "with dependencies with empty values" do
|
|
let(:hash) { { "dependencies" => ["", " "] } }
|
|
let(:expected_allowed_params) { { "dependencies" => [] } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
context "with dependencies" do
|
|
let(:hash) { { "dependencies" => ["members"] } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
context "with send_notifications" do
|
|
let(:hash) { { "dependencies" => [], "send_notifications" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
end
|
|
|
|
describe "#project_status" do
|
|
let(:attribute) { :project_status }
|
|
let(:hash_key) { "project" }
|
|
|
|
describe "status_code" do
|
|
context "with valid status_code" do
|
|
let(:hash) { { "status_code" => "not_started" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
context "with empty status_code" do
|
|
let(:hash) { { "status_code" => "" } }
|
|
let(:expected_allowed_params) { { "status_code" => nil } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
end
|
|
|
|
describe "status_explanation" do
|
|
let(:hash) { { "status_explanation" => "Blah..." } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
end
|
|
|
|
describe "#projects_type_ids" do
|
|
let(:attribute) { :projects_type_ids }
|
|
let(:hash_key) { "project" }
|
|
|
|
let(:hash) do
|
|
{ "type_ids" => ["1", "", "2"] }
|
|
end
|
|
|
|
let(:expected_allowed_params) do
|
|
[1, 2]
|
|
end
|
|
|
|
include_context "with prepare params comparison"
|
|
|
|
it do
|
|
actual = described_class.new(params, user).send(attribute)
|
|
|
|
expect(actual).to eq(expected_allowed_params)
|
|
end
|
|
end
|
|
|
|
describe "#color" do
|
|
let(:attribute) { :color }
|
|
|
|
let(:hash) do
|
|
{ "name" => "blubs",
|
|
"hexcode" => "#fff" }
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "#color_move" do
|
|
let(:attribute) { :color_move }
|
|
let(:hash_key) { "color" }
|
|
|
|
let(:hash) do
|
|
{ "move_to" => "1" }
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "#custom_field" do
|
|
let(:attribute) { :custom_field }
|
|
|
|
let(:hash) do
|
|
{ "editable" => "0", "admin_only" => "0" }
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "#custom_action" do
|
|
let(:attribute) { :custom_action }
|
|
let(:hash) do
|
|
{
|
|
"name" => "blubs",
|
|
"description" => "blubs blubs",
|
|
"actions" => { "assigned_to" => "1" },
|
|
"conditions" => { "status" => "42" },
|
|
"move_to" => "lower"
|
|
}
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "#update_work_package" do
|
|
let(:attribute) { :update_work_package }
|
|
let(:hash_key) { "work_package" }
|
|
|
|
describe "subject" do
|
|
let(:hash) { { "subject" => "blubs" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "description" do
|
|
let(:hash) { { "description" => "blubs" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "start_date" do
|
|
let(:hash) { { "start_date" => "2013-07-08" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "due_date" do
|
|
let(:hash) { { "due_date" => "2013-07-08" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "assigned_to_id" do
|
|
let(:hash) { { "assigned_to_id" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "responsible_id" do
|
|
let(:hash) { { "responsible_id" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "type_id" do
|
|
let(:hash) { { "type_id" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "priority_id" do
|
|
let(:hash) { { "priority_id" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "parent_id" do
|
|
let(:hash) { { "parent_id" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "version_id" do
|
|
let(:hash) { { "version_id" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "estimated_hours" do
|
|
let(:hash) { { "estimated_hours" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "done_ratio" do
|
|
let(:hash) { { "done_ratio" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "lock_version" do
|
|
let(:hash) { { "lock_version" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "status_id" do
|
|
let(:hash) { { "status_id" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "category_id" do
|
|
let(:hash) { { "category_id" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "budget_id" do
|
|
let(:hash) { { "budget_id" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "notes" do
|
|
let(:hash) { { "journal_notes" => "blubs" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "attachments" do
|
|
let(:hash) { { "attachments" => [{ "file" => "djskfj", "description" => "desc" }] } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "watcher_user_ids" do
|
|
include_context "with prepare params comparison"
|
|
let(:hash) { { "watcher_user_ids" => ["1", "2"] } }
|
|
let(:project) { instance_double(Project) }
|
|
|
|
before do
|
|
mock_permissions_for(user) do |mock|
|
|
mock.allow_in_project :add_work_package_watchers, project:
|
|
end
|
|
end
|
|
|
|
subject { described_class.new(params, user).update_work_package(project:).to_h }
|
|
|
|
context "when user is allowed to add watchers" do
|
|
before do
|
|
mock_permissions_for(user) do |mock|
|
|
mock.allow_in_project :add_work_package_watchers, project:
|
|
end
|
|
end
|
|
|
|
it do
|
|
expect(subject).to eq(hash)
|
|
end
|
|
end
|
|
|
|
context "when user is not allowed to add watchers" do
|
|
before do
|
|
mock_permissions_for(user, &:forbid_everything)
|
|
end
|
|
|
|
it do
|
|
expect(subject).to eq({})
|
|
end
|
|
end
|
|
end
|
|
|
|
context "for custom field values" do
|
|
let(:hash) { { "custom_field_values" => { "1" => "5" } } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "removes custom field values that do not follow the schema 'id as string' => 'value as string'" do
|
|
let(:hash) { { "custom_field_values" => { "blubs" => "5", "5" => { "1" => "2" } } } }
|
|
|
|
it_behaves_like "forbids params"
|
|
end
|
|
end
|
|
|
|
describe "#time_entry_activities_project" do
|
|
let(:attribute) { :time_entry_activities_project }
|
|
let(:hash) do
|
|
[
|
|
{ "activity_id" => "5", "active" => "0" },
|
|
{ "activity_id" => "6", "active" => "1" }
|
|
]
|
|
end
|
|
let(:expected_allowed_params) do
|
|
[
|
|
ActionController::Parameters.new("activity_id" => "5", "active" => "0").permit!,
|
|
ActionController::Parameters.new("activity_id" => "6", "active" => "1").permit!
|
|
]
|
|
end
|
|
|
|
it_behaves_like "allows params" do
|
|
subject { described_class.new(params, user).send(attribute) }
|
|
end
|
|
end
|
|
|
|
describe "#user" do
|
|
include_context "with prepare params comparison"
|
|
|
|
let(:hash_key) { "user" }
|
|
let(:external_authentication) { false }
|
|
let(:change_password_allowed) { true }
|
|
|
|
subject { described_class.new(params, user).send(attribute, external_authentication, change_password_allowed).to_h }
|
|
|
|
all_permissions = ["admin",
|
|
"login",
|
|
"firstname",
|
|
"lastname",
|
|
"mail",
|
|
"language",
|
|
"custom_fields",
|
|
"ldap_auth_source_id",
|
|
"force_password_change"]
|
|
|
|
describe "#user_create_as_admin" do
|
|
let(:attribute) { :user_create_as_admin }
|
|
let(:default_permissions) { %w[custom_fields firstname lastname language mail ldap_auth_source_id] }
|
|
|
|
context "for a non-admin" do
|
|
let(:hash) { all_permissions.zip(all_permissions).to_h }
|
|
|
|
it "permits default permissions" do
|
|
expect(subject.keys).to match_array(default_permissions)
|
|
end
|
|
end
|
|
|
|
context "for a non-admin with global :create_user permission" do
|
|
let(:user) { create(:user, global_permissions: [:create_user]) }
|
|
let(:hash) { all_permissions.zip(all_permissions).to_h }
|
|
|
|
it 'permits default permissions and "login"' do
|
|
expect(subject.keys).to match_array(default_permissions + ["login"])
|
|
end
|
|
end
|
|
|
|
context "for an admin" do
|
|
let(:user) { admin }
|
|
|
|
all_permissions.each do |field|
|
|
context field do
|
|
let(:hash) { { field => "test" } }
|
|
|
|
it "permits #{field}" do
|
|
expect(subject).to eq(field => "test")
|
|
end
|
|
end
|
|
end
|
|
|
|
context "with no password change allowed" do
|
|
let(:hash) { { "force_password_change" => "true" } }
|
|
let(:change_password_allowed) { false }
|
|
|
|
it "does not permit force_password_change" do
|
|
expect(subject).to eq({})
|
|
end
|
|
end
|
|
|
|
context "with external authentication" do
|
|
let(:hash) { { "ldap_auth_source_id" => "true" } }
|
|
let(:external_authentication) { true }
|
|
|
|
it "does not permit ldap_auth_source_id" do
|
|
expect(subject).to eq({})
|
|
end
|
|
end
|
|
|
|
context "for custom field values" do
|
|
let(:hash) { { "custom_field_values" => { "1" => "5" } } }
|
|
|
|
it "permits custom_field_values" do
|
|
expect(subject).to eq(hash)
|
|
end
|
|
end
|
|
|
|
context "for custom field values that do not follow the schema 'id as string' => 'value as string'" do
|
|
let(:hash) { { "custom_field_values" => { "blubs" => "5", "5" => { "1" => "2" } } } }
|
|
|
|
it "are removed" do
|
|
expect(subject).to eq({})
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
user_permissions = [
|
|
"firstname",
|
|
"lastname",
|
|
"mail",
|
|
"language",
|
|
"custom_fields"
|
|
]
|
|
|
|
describe "#user" do
|
|
let(:attribute) { :user }
|
|
let(:user) { admin }
|
|
|
|
user_permissions.each do |field|
|
|
context field do
|
|
let(:hash) { { field => "test" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
end
|
|
|
|
(all_permissions - user_permissions).each do |field|
|
|
context "for #{field} (admin-only)" do
|
|
let(:hash) { { field => "test" } }
|
|
|
|
it_behaves_like "forbids params"
|
|
end
|
|
end
|
|
|
|
context "for custom field values" do
|
|
let(:hash) { { "custom_field_values" => { "1" => "5" } } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
context "for custom field values that do not follow the schema 'id as string' => 'value as string'" do
|
|
let(:hash) { { "custom_field_values" => { "blubs" => "5", "5" => { "1" => "2" } } } }
|
|
|
|
it_behaves_like "forbids params"
|
|
end
|
|
|
|
context "for identity_url" do
|
|
let(:hash) { { "identity_url" => "test_identity_url" } }
|
|
|
|
it_behaves_like "forbids params"
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#user_register_via_omniauth" do
|
|
let(:attribute) { :user_register_via_omniauth }
|
|
let(:hash_key) { "user" }
|
|
|
|
user_permissions = %w(login firstname lastname mail language)
|
|
|
|
user_permissions.each do |field|
|
|
let(:hash) { { field => "test" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
context "for identity_url" do
|
|
let(:hash) { { "identity_url" => "test_identity_url" } }
|
|
|
|
it_behaves_like "forbids params"
|
|
end
|
|
end
|
|
|
|
shared_examples_for "allows enumeration move params" do
|
|
let(:hash) { { "2" => { "move_to" => "lower" } } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
shared_examples_for "allows move params" do
|
|
let(:hash) { { "move_to" => "lower" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
shared_examples_for "allows custom fields" do
|
|
describe "valid custom fields" do
|
|
let(:hash) { { "1" => { "custom_field_values" => { "1" => "5" } } } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "invalid custom fields" do
|
|
let(:hash) { { "custom_field_values" => { "blubs" => "5", "5" => { "1" => "2" } } } }
|
|
|
|
it_behaves_like "forbids params"
|
|
end
|
|
end
|
|
|
|
describe "#status" do
|
|
let (:attribute) { :status }
|
|
|
|
describe "name" do
|
|
let(:hash) { { "name" => "blubs" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "default_done_ratio" do
|
|
let(:hash) { { "default_done_ratio" => "10" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "is_closed" do
|
|
let(:hash) { { "is_closed" => "true" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "is_default" do
|
|
let(:hash) { { "is_default" => "true" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "move_to" do
|
|
it_behaves_like "allows move params"
|
|
end
|
|
end
|
|
|
|
describe "#settings" do
|
|
let (:attribute) { :settings }
|
|
|
|
describe "with password login enabled" do
|
|
before do
|
|
allow(OpenProject::Configuration)
|
|
.to receive(:disable_password_login?)
|
|
.and_return(false)
|
|
end
|
|
|
|
let(:hash) do
|
|
{
|
|
"sendmail_arguments" => "value",
|
|
"brute_force_block_after_failed_logins" => "value",
|
|
"password_active_rules" => ["value"],
|
|
"default_projects_modules" => ["value", "value"],
|
|
"emails_footer" => { "en" => "value" }
|
|
}
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "with password login disabled" do
|
|
include_context "with prepare params comparison"
|
|
|
|
before do
|
|
allow(OpenProject::Configuration)
|
|
.to receive(:disable_password_login?)
|
|
.and_return(true)
|
|
end
|
|
|
|
let(:hash) do
|
|
{
|
|
"sendmail_arguments" => "value",
|
|
"brute_force_block_after_failed_logins" => "value",
|
|
"password_active_rules" => ["value"],
|
|
"default_projects_modules" => ["value", "value"],
|
|
"emails_footer" => { "en" => "value" }
|
|
}
|
|
end
|
|
|
|
let(:permitted_hash) do
|
|
{
|
|
"sendmail_arguments" => "value",
|
|
"brute_force_block_after_failed_logins" => "value",
|
|
"default_projects_modules" => ["value", "value"],
|
|
"emails_footer" => { "en" => "value" }
|
|
}
|
|
end
|
|
|
|
it { expect(subject).to eq(permitted_hash) }
|
|
end
|
|
|
|
describe "with writable registration footer" do
|
|
before do
|
|
allow(Setting)
|
|
.to receive(:registration_footer_writable?)
|
|
.and_return(true)
|
|
end
|
|
|
|
let(:hash) do
|
|
{
|
|
"registration_footer" => {
|
|
"en" => "some footer"
|
|
}
|
|
}
|
|
end
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "with a non-writable registration footer (set via env var or config file)" do
|
|
include_context "with prepare params comparison"
|
|
|
|
before do
|
|
allow(Setting)
|
|
.to receive(:registration_footer_writable?)
|
|
.and_return(false)
|
|
end
|
|
|
|
let(:hash) do
|
|
{
|
|
"registration_footer" => {
|
|
"en" => "some footer"
|
|
}
|
|
}
|
|
end
|
|
|
|
let(:expected_permitted_hash) do
|
|
{}
|
|
end
|
|
|
|
it { expect(subject).to eq(expected_permitted_hash) }
|
|
end
|
|
|
|
context "when fetching settings" do
|
|
include_context "with prepare params comparison"
|
|
|
|
let(:hash) do
|
|
{
|
|
"registration_footer" => {
|
|
"en" => "some footer"
|
|
},
|
|
"working_days" => ["", "1", "2", "3", "4", "5"]
|
|
}
|
|
end
|
|
|
|
def recording_notifications_for(notification)
|
|
events = []
|
|
subscription = ActiveSupport::Notifications.subscribe notification do |*args|
|
|
events << ActiveSupport::Notifications::Event.new(*args)
|
|
end
|
|
|
|
begin
|
|
yield
|
|
ensure
|
|
ActiveSupport::Notifications.unsubscribe(subscription)
|
|
end
|
|
|
|
events
|
|
end
|
|
|
|
it "does not log any 'unpermitted' message" do
|
|
events = recording_notifications_for(/unpermitted_parameters/) do
|
|
subject
|
|
end
|
|
expect(events).to be_empty
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#enumerations" do
|
|
let (:attribute) { :enumerations }
|
|
|
|
describe "name" do
|
|
let(:hash) { { "1" => { "name" => "blubs" } } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "active" do
|
|
let(:hash) { { "1" => { "active" => "true" } } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "is_default" do
|
|
let(:hash) { { "1" => { "is_default" => "true" } } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "reassign_to_id" do
|
|
let(:hash) { { "1" => { "reassign_to_id" => "1" } } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "move_to" do
|
|
it_behaves_like "allows enumeration move params"
|
|
end
|
|
|
|
describe "custom fields" do
|
|
it_behaves_like "allows custom fields"
|
|
end
|
|
end
|
|
|
|
describe "#wiki_page_rename" do
|
|
let(:hash_key) { :page }
|
|
let (:attribute) { :wiki_page_rename }
|
|
|
|
describe "title" do
|
|
let(:hash) { { "title" => "blubs" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "redirect_existing_links" do
|
|
let(:hash) { { "redirect_existing_links" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
end
|
|
|
|
describe "#wiki_page" do
|
|
let(:hash_key) { :page }
|
|
let (:attribute) { :wiki_page }
|
|
|
|
describe "title" do
|
|
let(:hash) { { "title" => "blubs" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "parent_id" do
|
|
let(:hash) { { "parent_id" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "redirect_existing_links" do
|
|
let(:hash) { { "redirect_existing_links" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "journal_notes" do
|
|
let(:hash) { { "journal_notes" => "blubs" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "text" do
|
|
let(:hash) { { "text" => "blubs" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "lock_version" do
|
|
let(:hash) { { "lock_version" => "1" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
end
|
|
|
|
describe "member" do
|
|
let (:attribute) { :member }
|
|
|
|
describe "role_ids" do
|
|
let(:hash) { { "role_ids" => [] } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
describe "user_id" do
|
|
let(:hash) { { "user_id" => "blubs" } }
|
|
|
|
it_behaves_like "forbids params"
|
|
end
|
|
|
|
describe "project_id" do
|
|
let(:hash) { { "project_id" => "blubs" } }
|
|
|
|
it_behaves_like "forbids params"
|
|
end
|
|
|
|
describe "created_at" do
|
|
let(:hash) { { "created_at" => "blubs" } }
|
|
|
|
it_behaves_like "forbids params"
|
|
end
|
|
end
|
|
|
|
describe ".add_permitted_attributes" do
|
|
before do
|
|
@original_permitted_attributes = described_class.permitted_attributes.clone
|
|
end
|
|
|
|
after do
|
|
# Class variable is not accessible within class_eval
|
|
original_permitted_attributes = @original_permitted_attributes
|
|
|
|
described_class.class_eval do
|
|
@whitelisted_params = original_permitted_attributes
|
|
end
|
|
end
|
|
|
|
describe "with a known key" do
|
|
let(:attribute) { :user }
|
|
|
|
before do
|
|
described_class.send(:add_permitted_attributes, user: [:a_test_field])
|
|
end
|
|
|
|
context "with an allowed parameter" do
|
|
let(:hash) { { "a_test_field" => "a test value" } }
|
|
|
|
it_behaves_like "allows params"
|
|
end
|
|
|
|
context "with a disallowed parameter" do
|
|
let(:hash) { { "a_not_allowed_field" => "a test value" } }
|
|
|
|
it_behaves_like "forbids params"
|
|
end
|
|
end
|
|
|
|
describe "with an unknown key" do
|
|
let(:attribute) { :unknown_key }
|
|
let(:hash) { { "a_test_field" => "a test value" } }
|
|
|
|
before do
|
|
allow(Rails.logger).to receive(:warn)
|
|
described_class.send(:add_permitted_attributes, unknown_key: [:a_test_field])
|
|
end
|
|
|
|
it "permitted attributes should include the key" do
|
|
expect(described_class.permitted_attributes.keys).to include(:unknown_key)
|
|
end
|
|
|
|
it "does not log any warnings" do
|
|
described_class.permitted_attributes.keys
|
|
expect(Rails.logger).not_to have_received(:warn)
|
|
end
|
|
end
|
|
end
|
|
end
|