mirror of
https://github.com/opf/openproject.git
synced 2026-06-14 03:30:14 +00:00
Christophe Bliard
a69859f0ec
https://community.openproject.org/wp/67642 Attachments::ExtractFulltextJob is run twice: - one time on creation - one time when the direct upload is completed When it runs on creation, and the attachments are stored on S3, the attachment is in 'prepared' status and is not complete yet. Due to a bug in carrierwave which is fixed since June 2023 (see https://github.com/carrierwaveuploader/carrierwave/issues/2524), the `#local_file` method raises the error "NoMethodError: undefined method 'body' for nil:NilClass". There is a separate issue for upgrading this dependency one day: https://community.openproject.org/wp/67626. The fix is to call `#local_file` only if the attachment is readable. Additionnally: - error handling has been updated to raise the error instead of swallowing it silently, so well have proper reporting in AppSignal next time. - when a custom S3 endpoint is used (for local testing with minio for instance), this custom endpoint is added to the CSP. Co-authored-by: Jan Sandbrink <j.sandbrink@openproject.com>