Files
Kabiru Mwenja 6c253446ef Tighten route constraint to uppercase-only semantic identifiers
Project identifiers in semantic mode are validated as [A-Z][A-Z0-9_]*
(see Projects::Identifier#identifier_alphanumeric_format). Tighten
ID_ROUTE_CONSTRAINT to match only uppercase identifiers, rejecting
lowercase patterns at the constrained route level.

Note: lowercase identifiers still reach the controller via the
unconstrained resource route fallback and will 404 there.
2026-04-15 15:54:49 +03:00

143 lines
6.2 KiB
Ruby

# frozen_string_literal: true
#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See COPYRIGHT and LICENSE files for more details.
#++
require "spec_helper"
RSpec.describe WorkPackagesController do
it "connects GET /work_packages to work_packages#index" do
expect(get("/work_packages")).to route_to(controller: "work_packages",
action: "index")
end
it "connects GET /projects/blubs/work_packages to work_packages#index" do
expect(get("/projects/blubs/work_packages")).to route_to(controller: "work_packages",
project_id: "blubs",
action: "index")
end
it "connects GET /work_packages/new to work_packages#new" do
expect(get("/work_packages/new"))
.to route_to(controller: "work_packages",
action: "new")
end
it "connects GET /projects/:project_id/work_packages/new to work_packages#new" do
expect(get("/projects/1/work_packages/new"))
.to route_to(controller: "work_packages",
action: "new",
project_id: "1")
end
it "connects GET /work_packages/:id/overview to work_packages#show" do
expect(get("/work_packages/1/overview"))
.to route_to(controller: "work_packages",
action: "show", id: "1", tab: "overview")
end
it "connects GET /projects/:project_id/work_packages/:id/overview to work_packages#show" do
expect(get("/projects/1/work_packages/2/overview"))
.to route_to(controller: "work_packages",
action: "show",
project_id: "1",
id: "2",
tab: "overview")
end
it "connects GET /work_packages/details/:state to work_packages#index" do
expect(get("/work_packages/details/5/overview"))
.to route_to(controller: "work_packages",
action: "index",
state: "5/overview")
end
it "connects GET /projects/:project_id/work_packages/details/:id/:state " \
"to work_packages#index" do
expect(get("/projects/1/work_packages/details/2/overview"))
.to route_to(controller: "work_packages",
action: "index",
project_id: "1",
state: "details/2/overview")
end
it "connects GET /work_packages/:id to work_packages#show" do
expect(get("/work_packages/1")).to route_to(controller: "work_packages",
action: "show",
id: "1")
end
it "connects GET /work_packages/:id to work_packages#show with semantic identifier" do
expect(get("/work_packages/PROJ-42")).to route_to(controller: "work_packages",
action: "show",
id: "PROJ-42")
end
it "routes lowercase identifiers to show (caught by resource route, resolved at controller level)" do
expect(get("/work_packages/proj-42")).to route_to(controller: "work_packages",
action: "show",
id: "proj-42")
end
it "connects GET /work_packages/:id/share to work_packages/shares#index" do
expect(get("/work_packages/1/shares")).to route_to(controller: "shares",
action: "index",
work_package_id: "1")
end
it "connects POST /work_packages/:id/share to work_packages/shares#create" do
expect(post("/work_packages/1/shares")).to route_to(controller: "shares",
action: "create",
work_package_id: "1")
end
it "connects GET /work_packages/:work_package_id/moves/new to work_packages/moves#new" do
expect(get("/work_packages/1/move/new")).to route_to(controller: "work_packages/moves",
action: "new",
work_package_id: "1")
end
it "connects POST /work_packages/:work_package_id/moves to work_packages/moves#create" do
expect(post("/work_packages/1/move/")).to route_to(controller: "work_packages/moves",
action: "create",
work_package_id: "1")
end
it "connects GET /work_packages/moves/new?ids=1,2,3 to work_packages/moves#new" do
expect(get("/work_packages/move/new?ids=1,2,3")).to route_to(controller: "work_packages/moves",
action: "new",
ids: "1,2,3")
end
it "connects POST /work_packages/moves to work_packages/moves#create" do
expect(post("/work_packages/move?ids=1,2,3")).to route_to(controller: "work_packages/moves",
action: "create",
ids: "1,2,3")
end
end