mirror of
https://github.com/opf/openproject.git
synced 2026-06-14 03:30:14 +00:00
Kabiru Mwenja
b2d93c3a00
The shared-work-package email built its "Open work package" link and its text-part heading from the numeric primary key, so recipients on a semantic-identifier instance still landed on /work_packages/<numeric-id> rather than the semantic URL. Pass the work package itself to the URL helper so to_param yields the display id, and render the text heading with formatted_id to match the other work package mailers. Also drops an unused @notification_url that carried the same numeric-id problem. STC-747
127 lines
4.6 KiB
Ruby
127 lines
4.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
#-- copyright
|
|
# OpenProject is an open source project management software.
|
|
# Copyright (C) the OpenProject GmbH
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License version 3.
|
|
#
|
|
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
|
|
# Copyright (C) 2006-2013 Jean-Philippe Lang
|
|
# Copyright (C) 2010-2013 the ChiliProject Team
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License
|
|
# as published by the Free Software Foundation; either version 2
|
|
# of the License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
#
|
|
# See COPYRIGHT and LICENSE files for more details.
|
|
#++
|
|
|
|
require "spec_helper"
|
|
|
|
RSpec.describe SharingMailer do
|
|
let(:project) { build_stubbed(:project) }
|
|
let(:work_package) do
|
|
build_stubbed(:work_package,
|
|
type: build_stubbed(:type_standard),
|
|
author: build_stubbed(:user),
|
|
project:)
|
|
end
|
|
let(:shared_with_user) { build_stubbed(:user) }
|
|
let(:roles) { [build_stubbed(:comment_work_package_role)] }
|
|
let(:work_package_member) do
|
|
build_stubbed(:work_package_member,
|
|
entity: work_package,
|
|
user: shared_with_user,
|
|
roles:)
|
|
end
|
|
|
|
let(:current_user) { build_stubbed(:user) }
|
|
|
|
describe "#shared_work_package" do
|
|
subject(:mail) do
|
|
described_class.shared_work_package(current_user, work_package_member)
|
|
end
|
|
|
|
it "addresses the mail to the member's principal" do
|
|
expect(mail.to)
|
|
.to contain_exactly(shared_with_user.mail)
|
|
end
|
|
|
|
context "with classic mode", with_settings: { work_packages_identifier: "classic" } do
|
|
it "sets the subject with # prefixed numeric id" do
|
|
expect(mail.subject)
|
|
.to eq(I18n.t("mail.sharing.work_packages.subject", id: "##{work_package.id}"))
|
|
end
|
|
|
|
it "links to the work package by its numeric id" do
|
|
expect(mail.html_part.body.encoded).to include("/work_packages/#{work_package.id}")
|
|
expect(mail.text_part.body.encoded).to include("/work_packages/#{work_package.id}")
|
|
end
|
|
end
|
|
|
|
context "with semantic mode",
|
|
with_settings: { work_packages_identifier: "semantic" } do
|
|
let(:work_package) do
|
|
build_stubbed(:work_package,
|
|
type: build_stubbed(:type_standard),
|
|
author: build_stubbed(:user),
|
|
project:,
|
|
identifier: "PROJ-42",
|
|
sequence_number: 42)
|
|
end
|
|
|
|
it "sets the subject with the semantic identifier without # prefix" do
|
|
expect(mail.subject)
|
|
.to eq(I18n.t("mail.sharing.work_packages.subject", id: "PROJ-42"))
|
|
end
|
|
|
|
it "links to the work package by its semantic identifier, not the numeric id" do
|
|
expect(mail.html_part.body.encoded).to include("/work_packages/PROJ-42")
|
|
expect(mail.html_part.body.encoded).not_to include("/work_packages/#{work_package.id}")
|
|
|
|
expect(mail.text_part.body.encoded).to include("/work_packages/PROJ-42")
|
|
expect(mail.text_part.body.encoded).not_to include("/work_packages/#{work_package.id}")
|
|
end
|
|
|
|
it "renders the text-part heading with the semantic identifier, not the numeric id" do
|
|
expect(mail.text_part.body.encoded).to include("= PROJ-42 #{work_package.subject} =")
|
|
expect(mail.text_part.body.encoded).not_to include("##{work_package.id}")
|
|
end
|
|
end
|
|
|
|
it "has a project header" do
|
|
expect(mail["X-OpenProject-Project"].value)
|
|
.to eq(project.identifier)
|
|
end
|
|
|
|
it "has a work package id header" do
|
|
expect(mail["X-OpenProject-WorkPackage-Id"].value)
|
|
.to eq(work_package.id.to_s)
|
|
end
|
|
|
|
it "has a type header" do
|
|
expect(mail["X-OpenProject-Type"].value)
|
|
.to eq("WorkPackage")
|
|
end
|
|
|
|
it "has a message id header" do
|
|
Timecop.freeze(Time.current) do
|
|
expect(mail.message_id)
|
|
.to eq("op.member-#{work_package_member.id}.#{Time.current.strftime('%Y%m%d%H%M%S')}.#{current_user.id}@example.net")
|
|
end
|
|
end
|
|
end
|
|
end
|