Commit Graph

71 Commits

Author SHA1 Message Date
Tomas Hykel cafbca292d DRY up the route constraint in GithubIntegration helper 2026-05-20 17:25:49 +02:00
Tomas Hykel 7f506a1a8e feat: Support semantic work package identifiers for GitHub 2026-05-20 10:22:58 +02:00
Oliver Günther db27c3a7b8 Move menu to core 2026-03-30 09:12:15 +02:00
Oliver Günther 3c2acfc57a Add integrations menu 2026-03-26 14:35:34 +01:00
Oliver Günther 6b97c178a8 Allow setting a github user and webhook secret for github requests 2026-03-26 13:32:42 +01:00
Jan Sandbrink b9f781bd90 Merge pull request #20766 from opf/auto-preload
Automatically pre- and eager-load collections
2025-11-25 13:42:08 +01:00
Oliver Günther bbcadbb19e Move meetings and watchers tab
Meetings should come after relations, then gitlab/github (if enabled),
then watchers last.
2025-11-19 10:26:34 +01:00
Jan Sandbrink a82257ac66 Automatically pre- and eager-load collections
Index endpoints will automatically discover and use
the `to_eager_load` and `to_preload` declarations of their
representers. This takes away the possibility of forgetting
to add those to the scope.

I found a few endpoint that didn't use them, when other endpoints
rendering the same collection did.

Interestingly the SCM integration modules consistently declared
those methods but never used them.
2025-11-10 16:16:05 +01:00
Bruno Pagno c2886046cd update comment permission names 2025-04-24 13:12:32 +02:00
Ivan Kuchin 0b8308e419 unify procs and lambdas in module menus 2025-01-16 15:11:37 +01:00
Christophe Bliard d8f0788850 Introduce visible to control a permission visibility in admin
Attribute `enabled` can not be used dynamically to control if a
permission is available or not. Because enabled permissions is cached at
in a class instance variable, this can fails in a multi-tenant
architecture. For instance if the lambda reads a feature flag, the
permission will be enabled depending on the feature flag of a tenant.
Other tenants having a different value for this feature flag will get an
unexpected behavior.

That the origin of the bug https://community.openproject.org/wp/56064

So from now on, `enabled` is no longer a `Permission` initialization
parameter and is always initialized to `true`. It can be turned off at
boot time (for instance when using `OPENPROJECT_ENABLED_MODULES`). It
must not change during runtime.

Visibility in administration is now controlled with a new variable named
`visible`.

The two permissions previsouly relying on `enabled` proc,
`:create_backup` and `introspection`, are now using `visible` instead.
2024-09-02 16:19:48 +02:00
Oliver Günther 7d9d636487 Fix github split view tab 2024-08-15 11:27:44 +02:00
Oliver Günther 12ee9e6b83 Merge remote-tracking branch 'origin/idea/56781-remove-years-from-copyrights' into dev 2024-08-06 10:17:59 +02:00
Henriette Darge a144d669a2 Remove nesting of modules for Backlogs and GitHub integration as they only have one submenu entry 2024-08-05 12:55:25 +02:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
Oliver Günther ef9480bbd6 Use menu helper to generate tabs 2024-07-26 10:32:10 +02:00
Henriette Darge 4f2b8d39c2 Replace old icons with Octicons inside the main menu 2024-06-11 12:46:23 +02:00
Markus Kahl 80007dd48b translate deploy comment, allow to be made by manually set github user 2024-06-10 12:03:37 +01:00
Markus Kahl 5645d5d38e fix enabling deploy status job, symbol required 2024-06-10 10:56:03 +01:00
Markus Kahl c2386064a7 fix github specs broken due to missing merge_commit_sha 2024-06-03 11:16:13 +01:00
Markus Kahl 547bd8c65c pull introspection impl into github integration, add specs 2024-06-03 10:39:49 +01:00
Markus Kahl f1340e9897 implement deploy status checks for github integration 2024-06-03 10:39:49 +01:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Oliver Günther 337eda7dfa Revert "Revert "Merge pull request #12998 from opf/task/48717-replace-delayedjob""
This reverts commit dfa75621ea.
2024-03-07 13:59:24 +01:00
Markus Kahl dfa75621ea Revert "Merge pull request #12998 from opf/task/48717-replace-delayedjob"
This reverts commit 9f3e4c48ea, reversing
changes made to 10412f7c85.
2024-03-07 12:40:15 +00:00
Pavel Balashou 2267a0a1e3 React on comments from review.
- Do not use string literals for job class names. Use `class.name` instead.
- Rename `ApplicationJob#good_job_scheduled_at` to `ApplicationJob#job_scheduled_at` to be backend agnostic.
- update queries in bin/check-worker-liveness to use good_jobs table
- Set good_job config options through appropriate OpenProject::Configuration
- Remove delayed_jobs table.
- Update health_check docs.
2024-02-27 22:35:33 +01:00
Pavel Balashou fd6a899b29 [#48717] Replace DelayedJob with GoodJob.
https://community.openproject.org/work_packages/48717
2024-02-14 10:18:27 +01:00
Christophe Bliard 50558549ce Fix test broken by rubocop --autocorrect in 8fa8584538 2024-01-05 15:28:23 +01:00
Christophe Bliard 8fa8584538 Run rubocop --autocorrect on all files
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Klaus Zanders 28adc2ea17 Check :show_github_content permission on the work package 2023-11-27 10:23:17 +01:00
Klaus Zanders 16f0a44906 Check for the add_work_package_notes on the work package to allow
commenting
2023-11-27 10:23:08 +01:00
Klaus Zanders 49037c7857 Replace all allowed_to? calls in the API 2023-10-30 11:50:57 +01:00
Klaus Zanders e9d1deadff Fix all other usages of authorize methods in API 2023-10-30 11:50:55 +01:00
Klaus Zanders 53f5ee48b8 Replace allowed_to? calls in helpers 2023-10-30 08:21:51 +01:00
Aaron Contreras c6705401a4 Set permissible_on definitions on github_integration module 2023-08-31 08:34:19 -05:00
Aaron Contreras 274fe65c24 Chore: Fix Rubocop redundant current directory cop in github_integration/engine.rb
Fixes:
```
Style/RedundantCurrentDirectoryInPath:
Remove the redundant current directory path.
```
2023-08-31 08:34:19 -05:00
Oliver Günther 52c1ed33f7 Add referenced as possible action to github handler 2023-04-18 16:09:10 +02:00
Oliver Günther c77afd50c3 Fix specs generating macros 2023-04-18 16:09:09 +02:00
Oliver Günther bbf6e4e4b4 Add repository_html_url 2023-04-18 16:09:09 +02:00
Oliver Günther 45cb7b7363 Add pull-request macro 2023-04-18 16:09:08 +02:00
Oliver Günther 077112df43 Replace github state with store 2023-04-18 16:02:58 +02:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
ulferts 3492d08fdd turn OpenProject::Notifications static 2022-04-04 17:08:23 +02:00
ulferts c794a9249b defer autoloading permissions 2022-04-04 16:46:00 +02:00
Christophe Bliard a33524ef6d remove ruby magic comment for utf-8
ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless
2022-03-10 19:36:58 +01:00
ulferts a775e9e5d8 introduce permission governing whether work packages can be assigned 2022-03-03 11:36:58 +01:00