Commit Graph

13 Commits

Author SHA1 Message Date
Klaus Zanders 26d11b4236 Add Dangerfile to validate that project_id attribute is correctly checked in Update- or BaseContract 2026-04-21 11:31:28 +02:00
Oliver Günther dc4e65492a Add dangerfile for migrations 2025-02-28 10:20:24 +01:00
Aaron Contreras 6827196e9e Add Dangerfile
Warns that a PR involves migrations and pings Markus.
2024-02-22 15:40:29 +01:00
Oliver Günther 425b57b007 Replace dangerfile with eslint plugins
We currently use dangerfile only for jasmine fdescribe/fit tests and
Angular onPush checks.

Both can be replaced by eslint plugins.
2021-07-20 14:14:28 +02:00
Aleix Suau ac06c85662 Fix/36382 dynamic form not triggering expression properties (#9249)
* Fix

* Tests

* Fix dangerfile grep

* Remove fdescribe

Co-authored-by: Oliver Günther <mail@oliverguenther.de>
2021-05-10 22:08:01 +02:00
Oliver Günther 2c465ddaca Grep properly for dangerfile fit/fdescribe (#9230) 2021-05-06 09:42:50 +02:00
ulferts 1bdd2ab9ae safe automatic fixes by rubocop (#8994) 2021-02-11 16:02:18 +01:00
Henriette Dinger f47a75d153 [31023] Preparation for project edit fields: Generalize edit and display fields currently work package specific (#7726)
* Check edit fields for Work package dependencies

* Make EditForm, NotificationService, EditContext indepenedent of Work Packages

* Make EventsService independent of WorkPackages

* Start renaming WpNotificationService (WiP)

* Fix more references

* Fix typescript errors

* Add basic halEditingService

* Rename to global halResourceEditingService (WiP)

* Move typing from class to methods (WiP)

* Fix typescript errors

* Remove space in type

* Add test project widget && generalize the editFieldGroup

* Rename editing portal service

[ci skip]

* Rename WpEditFieldComponent

* Rename WpDisplayFields

* Rename display-XX-field to XX-display-field

[ci skip]

* Add WP specific ID field to distinguish between resources

* Re-add state in work package resource

* Generalize display field renderer

* Rename spent-time to wp-spent-time and fix highlight specifics

[ci skip]

* Actually load the project schema and make field editable

* Make edit-field-group.component an edit-form.component and subclass EditForm

* Remove edit context in favor of specialized EditForm

* Add special cases for work package editing

* Fix edit actions bar

* Fix codeclimate issues

* Use WorkPackageNotificationService if necessary

* Override NotificationService for WPs to allow WP specififc notifications (WiP)

* Correctly provide wpNotification service

Because the ui-router doesn't seem to correctly use the parent element's
injector, we need to provide the wpNotification service not in the
wp-base, but rather the wp-list component as well as in the isolated
query space.

* Allow to filter halEvents for specific resourceTypes (e.g. WorkPackage)

* Remove superfluous cell class constant

* Start renaming selectors for wp-edit-field into generics

* Remove wp-table--cell-span in favor of display field selector

* Consolidate other display and edit field styles

* Provide specialized service for transitions in active edit forms

* Remove superfluous overflowSelector

* Accept that date field contains some work package specifics

* Ignore unreadable files

* Provide the changeset for work packages as a hook

Since hal resource editing service is provided per query space, we
cannot register them once (would only work globally)

* Fix dangerfile

* Remove another todo in halResourceNotification service

* Fix npm TestBed for changed dependencies

* Show inplace edit field in project details widget

* Fix highlighting in single view

* Provide HalResourceEditingService outside of project context

* Used typedState for single-view

* Also provide wpNotification service in split view

* Correct check for resource type in eventsService

* Fix getSchemaName in display field renderer

* Fix passing ids into `halEditing.stopEditing`

* Do not globally inject the halResourceEditingService

There's a bug(?) in ui-router that gives you the global service before
the parent injected service for a ui-view

* Fix wpCreate service on copying and parallel creation

* Remove test project widget

* Revert changes for project details widget
2019-10-01 16:21:17 +02:00
ulferts c83ba63640 Revert revert unwanted in dev branch
This reverts commit b05a8f7b54.

The release/10 branch received a revert that was applied after changes
from dev unwillingly where merged into it. But when merging release/10.0
back into dev, that revert was also applied to dev where the changes are
indeed wanted. So we revert the revert for dev.
2019-09-20 08:36:05 +02:00
Oliver Günther b05a8f7b54 Revert "[31080] Trigger wpEvent after custom action" 2019-09-18 14:28:33 +02:00
Oliver Günther 030aefb030 Warn for components not using onPush 2019-09-18 13:24:37 +02:00
Oliver Günther 2f2c9b3a25 Fix found jasmine issue 2019-09-09 13:01:32 +02:00
Oliver Günther cace1b1015 Test dangerfile in test and development environment 2019-09-09 13:01:32 +02:00