references/openproject
1
0
Fork 0
mirror of https://github.com/opf/openproject.git synced 2026-06-14 03:30:14 +00:00
Code Issues Packages Projects Releases Wiki Activity
101,953 Commits 457 Branches 316 Tags
6943ad129eedbc4e4301ea401fefd4ffdc2d56ee
Commit Graph

13188 Commits

Author SHA1 Message Date
OpenProject Actions CI b2040cbe85 update locales from crowdin [ci skip] 2026-02-11 04:05:53 +00:00
Behrokh Satarnejad 974b84d580 [67399] Fix accessibility issues in Angular templates detected by ESLint (#21339) 
* Tell eslint to ignore click rule on router links

See https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/click-events-have-key-events.md

* Pass fixing accessibility issues found by ESLint

- fixes failing tests in configuration modal
- uses button instead of link in my account timer
- uses button instead of div for buttons of scrollable tabs
- sets correct role for links and divs which are clickable
- sets href on links

* Add role="button" and preventDefault() to accessibility fixes

Co-authored-by: myabc <755+myabc@users.noreply.github.com>

* remove tabindex for the item of draggable auto completer

* remove prevent default from drop modal

* Fix test to select the button

---------

Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: myabc <755+myabc@users.noreply.github.com>
 2026-02-10 14:37:32 +01:00
as-op 1b89cd7d3d fix specs with changed expectations for page break positions 2026-02-10 13:14:32 +01:00
as-op e4b7932212 [#69515] Fine-tuning of margins in pdf exports 
https://community.openproject.org/work_packages/69515
 2026-02-10 12:21:52 +01:00
Oliver Günther 0d55a543f0 Merge remote-tracking branch 'origin/release/17.0' into release/17.1 2026-02-10 09:43:36 +01:00
Jure Uršič 1074e9efee [#71414] Deleting a Time and Cost report results in an error 2026-02-10 09:43:13 +01:00
OpenProject Actions CI 0fd84357f6 update locales from crowdin [ci skip] 2026-02-10 04:15:21 +00:00
Mir Bhatia a27a9a4f8c Merge pull request #21901 from opf/bug/71404-timezone-warning-is-shown-when-users-reschedule-a-meeting-in-their-own-timezone 
[#71404] Timezone warning is shown when users reschedule a meeting in their own timezone
 2026-02-09 15:11:16 +01:00
Klaus Zanders 049ab87dd7 Do not include user names in error messages 2026-02-09 14:05:56 +01:00
Jan Sandbrink b3f8c1af66 Merge pull request #21917 from opf/fix-internal-error 
Fix API::Errors::InternalError class
 2026-02-09 11:59:44 +01:00
Mir Bhatia c0d6f4ec82 Merge pull request #21903 from opf/bug/70318-meeting-series-can-t-be-deleted-before-opening-the-first-occurrence 
[#70318] Meeting series can't be deleted before opening the first occurrence
 2026-02-09 11:32:17 +01:00
Jan Sandbrink 953ab1a6a8 Fix API::Errors::InternalError class 
This class got broken during what seems to be a
drive-by style-improvement in fbe1215365. That change:

* made it incompatible with frozen strings as error messages
* broke the intended hiding of messages if they came from the
  wrong class

All of this went by unnoticed, because there were no specs
for the InternalError class.

Specs have now been added and the previous version of the code
mostly restored. Since there were some callers that always created the
exception with known safe error messages, I added a new class just for these
cases, because they were intended to "just show the message". So we can
keep using the original implementation for rescue_from handling.
 2026-02-09 11:04:57 +01:00
Mir Bhatia e6454b7e76 Add option to end series to template in draft mode 2026-02-09 09:27:46 +01:00
Mir Bhatia baef841cab Merge pull request #21893 from opf/bug/70609-if-user-cancels-a-meeting-that-is-currently-happening-the-meeting-disappears-from-list 
[#70609] If user cancels a meeting that is currently happening, the meeting disappears from list
 2026-02-09 08:46:24 +01:00
OpenProject Actions CI 2d6502cc45 update locales from crowdin [ci skip] 2026-02-07 03:52:37 +00:00
Mir Bhatia 213c16019a Update warning banner to compare timezone abbreviations 2026-02-06 13:26:33 +01:00
Mir Bhatia 7ea9a3ecb4 Merge pull request #21863 from opf/bug/70585-images-are-broken-on-moved-meeting-agenda-item 
[#70585] Images are broken on moved meeting agenda item
 2026-02-06 10:51:41 +01:00
Mir Bhatia 94f55e9dfc Add spec 2026-02-06 09:07:22 +01:00
Mir Bhatia 8ac58e7658 Adjust count to compensate for ongoing cancelled occurrences 2026-02-06 09:07:15 +01:00
Henriette Darge 59ddae92c2 Merge pull request #21871 from opf/bug/69747-attribute-help-text-do-not-show-up-on-project-overview-on-initial-page-load 
[69747] Attribute help text do not show up on Project overview on initial page load
 2026-02-06 08:30:57 +01:00
OpenProject Actions CI 451bf3666f update locales from crowdin [ci skip] 2026-02-06 03:55:52 +00:00
Mir Bhatia 7c51f7bbc4 Fix falsely failing spec 
Occurrences will always have start times matching the actual recurring
meeting, and this is used for filtering when generating the "Planned"
occurrences. Without this matching, that calculation was off and the
spec was falsely failing.
 2026-02-05 17:46:27 +01:00
Mir Bhatia af592ecdce Include "ongoing" cancelled occurrences in the planned list 2026-02-05 16:13:49 +01:00
Oliver Günther 1b3d104516 Merge pull request #21872 from opf/fix/hashed-token-pepper 
Use a settings-based hashed token pepper that is not bound to secret_key_base
 2026-02-05 15:04:32 +01:00
Mir Bhatia 5f3c01c7c4 Merge pull request #21875 from opf/bug/update-meetings-strings 
[#70610, #71338] Update meetings strings
 2026-02-05 10:50:31 +01:00
OpenProject Actions CI 1ec9cc0611 update locales from crowdin [ci skip] 2026-02-05 03:53:08 +00:00
Mir Bhatia 6873b2f20a Add "or you have been removed as a participant" to cancellation emails 2026-02-04 16:14:40 +01:00
Mir Bhatia c2dd9093c8 Change "Duplicate in next occurrence" to "Duplicate in next meeting" 2026-02-04 15:48:06 +01:00
Henriette Darge 0af401994a Merge pull request #21870 from opf/bug/58458-loading-spinner-is-unreadable-on-timeand-costs-module-when-in-dark-mode 
[58458] Replace ajax loading indicator with Primer component
 2026-02-04 15:38:44 +01:00
Mir Bhatia a52ad5b329 Add specs 2026-02-04 15:31:41 +01:00
Oliver Günther b718dc0430 Get rid of find_by_plaintext_value! 2026-02-04 15:16:09 +01:00
Oliver Günther e9fb3a368c Merge pull request #21862 from opf/fix/71345/meeting-reopen 
Fix/71345/meeting reopen
 2026-02-04 14:56:04 +01:00
Mir Bhatia 01cf06b1f3 Add and use concern to handle duplication of agenda items as well 2026-02-04 13:05:27 +01:00
Henriette Darge 4d0015a81d Always show the AttributeHelpText for project status on overview 2026-02-04 11:30:14 +01:00
Henriette Darge 0029a0fac0 Replace old ajax loading indicator with Primer spinner 2026-02-04 11:13:53 +01:00
Oliver Günther 03f1c00389 Skip coverage validation when series model itself is invalid 2026-02-04 10:18:43 +01:00
Mir Bhatia e59dc77bb6 Use alias method instead of super to not skip AfterPerformHook method 2026-02-04 09:35:07 +01:00
Oliver Günther 43d08fc051 Append ICS as separate mail part, and set publish for subscriptions 2026-02-04 09:12:58 +01:00
OpenProject Actions CI 887188ffe5 update locales from crowdin [ci skip] 2026-02-04 03:52:47 +00:00
Mir Bhatia 893b085a14 Update UpdateService to copy attachments when agenda items are moved 2026-02-03 16:56:53 +01:00
Oliver Günther f6b578c340 Remove incorrect hiding of end_after elements 2026-02-03 15:56:22 +01:00
Oliver Günther 6c2b98c449 Merge pull request #21844 from opf/fix/external-link-capture 
Use stimulus controller for external link capture
 2026-02-03 14:41:17 +01:00
Alexander Brandon Coles 4b4a14452d Merge pull request #21842 from opf/bug/71325-drag-and-drop-turbo-interop 
[#71325, #71327] Drag and drop fixes
 2026-02-03 09:33:18 -03:00
Mir Bhatia d2cd230535 Merge pull request #21826 from opf/bug/71089-move-to-next-meeting-and-duplicate-in-next-meeting-select-cancelled-meeting 
[#71089] "Move to next meeting" and "Duplicate in next meeting" select cancelled meeting
 2026-02-03 12:50:45 +01:00
Oliver Günther 1857f25b58 Primerize static link helper and use that for external links consistently 2026-02-03 11:41:43 +01:00
OpenProject Actions CI 1cf9e97b51 update locales from crowdin [ci skip] 2026-02-03 09:40:25 +00:00
Mir Bhatia 78f5774e01 Update specs 2026-02-03 09:25:14 +01:00
Mir Bhatia fdc9609aeb Fix behaviour when next occurrence is cancelled 2026-02-03 09:25:13 +01:00
Mir Bhatia b0393391e6 Merge pull request #21838 from opf/bug/70242-meeting-template-shows-duplicate-menu-point-with-empty-action-list 
[#70242] Meeting template shows 'Duplicate' menu point with empty action list
 2026-02-03 08:41:52 +01:00
OpenProject Actions CI 502ef3e991 update locales from crowdin [ci skip] 2026-02-03 03:53:27 +00:00