98 Commits

Author SHA1 Message Date
ulferts 8c73781898 adapt specs for pdf content type
Chrome has been migrating its built-in PDF viewer from GuestView (separate WebContents with an <embed> element) to OOPIF (Out-of-Process Iframe). Chrome 145 appears to be where this became the default.
2026-02-18 08:47:39 +01:00
as-op 48b503bd60 address review comment https://github.com/opf/openproject/pull/19302#discussion_r2166706996 2025-06-25 16:28:00 +02:00
as-op 9d0720bcfd [#64591] Link CF in PDF report only partially clickable when in multiple lines
https://community.openproject.org/work_packages/64591
2025-06-24 14:51:55 +02:00
Jan Sandbrink 0b87e7543f Freeze string literals in specs
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
Bruno Pagno 97ccf0bfc5 adjust internal comments internal representation 2025-04-24 13:12:32 +02:00
Bruno Pagno c2886046cd update comment permission names 2025-04-24 13:12:32 +02:00
Kabiru Mwenja 994d49c843 Deduplicate restricted visibility comment spec helpers 2025-03-26 08:57:19 +03:00
as-op 3722fef77b Display an empty message for query groups without rows; apply formatting changes (discussed in call) 2025-03-19 16:50:29 +01:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
as-op f59f8f933b [#49081] (Re-)Add tests for pdf content
https://community.openproject.org/work_packages/49081
2023-08-08 17:14:36 +02:00
Oliver Günther 8989f2d439 Add lookbook 2023-08-02 13:57:27 +02:00
as-op 3a504ffbb4 via feedback: move equal methods into spec/support 2023-07-31 10:15:43 +02:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Dombi Attila 69e83fc0d4 BUG/34971 Order of work packages in XLS, PDF, CSV export differs from order in OpenProject (#10719)
* Save the new queries when manually sorting the work packages

* fixup! Save the new queries when manually sorting the work packages

* fixup! Save the new queries when manually sorting the work packages
2022-06-01 11:00:22 +02:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
Behrokh Satarnejad 133c0136c1 Using BEM methodology to change the styles (#9401)
* change some of stylesheets

* change the style naming

* resolve the error

* improving the previous commit with Ben's comments

* improve the styles of breadcrumb

* change the stylesheet related to status button

* refactoring css stylesheets of wp single card

* fixing the errors of PR, correct selector

* change some of stylesheets

* change the style naming

* resolve the error

* improving the previous commit with Ben's comments

* improve the styles of breadcrumb

* change the stylesheet related to status button

* refactoring css stylesheets of wp single card

* fixing the errors of PR, correct selector

* resolve the error on PR related to boards onboarding

* wp relation and list view style changes

* resolve the errors of previous commit

* fix error in selecting wp relation

* fix the errors of wp relations ruby tests

* change the stylesheets of autocompleter and wp calendar

* change the style of grid page

* Some improvements to the BEM styling

* Prefix draggable-autocomplete BEM block with op-

* Fix spec selector

* Fix spec selector

Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>
2021-07-15 14:08:58 +02:00
ulferts 6140f4c7e9 update copyright to 2021 (#8925)
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.

Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
Henriette Dinger bd7f4e4814 Update copyright notice 2020-01-15 11:31:26 +01:00
Henriette Dinger 6f92035ccc Rename EditField classes used for tests and remove WorkPackage reference 2019-10-02 10:30:04 +02:00
Henriette Dinger f47a75d153 [31023] Preparation for project edit fields: Generalize edit and display fields currently work package specific (#7726)
* Check edit fields for Work package dependencies

* Make EditForm, NotificationService, EditContext indepenedent of Work Packages

* Make EventsService independent of WorkPackages

* Start renaming WpNotificationService (WiP)

* Fix more references

* Fix typescript errors

* Add basic halEditingService

* Rename to global halResourceEditingService (WiP)

* Move typing from class to methods (WiP)

* Fix typescript errors

* Remove space in type

* Add test project widget && generalize the editFieldGroup

* Rename editing portal service

[ci skip]

* Rename WpEditFieldComponent

* Rename WpDisplayFields

* Rename display-XX-field to XX-display-field

[ci skip]

* Add WP specific ID field to distinguish between resources

* Re-add state in work package resource

* Generalize display field renderer

* Rename spent-time to wp-spent-time and fix highlight specifics

[ci skip]

* Actually load the project schema and make field editable

* Make edit-field-group.component an edit-form.component and subclass EditForm

* Remove edit context in favor of specialized EditForm

* Add special cases for work package editing

* Fix edit actions bar

* Fix codeclimate issues

* Use WorkPackageNotificationService if necessary

* Override NotificationService for WPs to allow WP specififc notifications (WiP)

* Correctly provide wpNotification service

Because the ui-router doesn't seem to correctly use the parent element's
injector, we need to provide the wpNotification service not in the
wp-base, but rather the wp-list component as well as in the isolated
query space.

* Allow to filter halEvents for specific resourceTypes (e.g. WorkPackage)

* Remove superfluous cell class constant

* Start renaming selectors for wp-edit-field into generics

* Remove wp-table--cell-span in favor of display field selector

* Consolidate other display and edit field styles

* Provide specialized service for transitions in active edit forms

* Remove superfluous overflowSelector

* Accept that date field contains some work package specifics

* Ignore unreadable files

* Provide the changeset for work packages as a hook

Since hal resource editing service is provided per query space, we
cannot register them once (would only work globally)

* Fix dangerfile

* Remove another todo in halResourceNotification service

* Fix npm TestBed for changed dependencies

* Show inplace edit field in project details widget

* Fix highlighting in single view

* Provide HalResourceEditingService outside of project context

* Used typedState for single-view

* Also provide wpNotification service in split view

* Correct check for resource type in eventsService

* Fix getSchemaName in display field renderer

* Fix passing ids into `halEditing.stopEditing`

* Do not globally inject the halResourceEditingService

There's a bug(?) in ui-router that gives you the global service before
the parent injected service for a ui-view

* Fix wpCreate service on copying and parallel creation

* Remove test project widget

* Revert changes for project details widget
2019-10-01 16:21:17 +02:00
Oliver Günther 872fba5892 Fix styling of task lists 2019-09-02 07:41:03 +02:00
Henriette Dinger f850aca7b8 Merge release/9.1 into dev 2019-08-21 14:15:32 +02:00
Oliver Günther d30f8a5e3e [30734] Wait for results and schemas to be present to show status button
https://community.openproject.com/wp/30734
2019-08-16 07:55:35 +02:00
Henriette Dinger d8aa2470e4 Merge branch 'release/9.1' into dev 2019-08-15 14:40:50 +02:00
ulferts 6d8918cd09 add custom text widget to dashboard 2019-07-19 13:19:26 +02:00
Henriette Dinger 8fcfe631c0 Adapt tests to immediate save of input fields on focus loss 2019-07-10 11:32:07 +02:00
ulferts cc0145daf6 prevent useless edits to wp status
In case the fixed version and the status of a work package are both closed, the status of a work package cannot be altered any more. Attempting it will result in an error.

Before the fix, the possible status calculation would not factor in that situation and the status would be marked as writable regardless as well. Therefore, the frontend would display a list of statuses even though selecting one would do nothing at all.

Now, the status property is marked as non writable in such a situation and the status list will only contain the current status. As we only fetch the form after a click on the edit field, we can only disable the field after that which is a bit weird.
2019-06-21 15:18:32 +02:00
Henriette Dinger 646945b1ba Increase available space for autocompleter in table and reduce label to save space 2019-06-03 15:02:45 +02:00
Henriette Dinger 147d4f4c9f Add test for inline creation of versions from within WP view && adapt tests to new component 2019-05-24 16:26:59 +02:00
Henriette Dinger f955b7edd1 Remove already selected entries from multi-select field 2019-03-04 09:27:53 +01:00
Henriette Dinger 1b8aa2b3e2 [29257] Auto completion for work package attributes (#6988)
* Introduce ng-select component on WP pages

* Remove multiselect switch within multiselect component

* Append autocomleter dropdown to attribute group to better handle the two colum layout

* Add overflow selector to edit contexts to allow adding to it

* Set correct element to append to on WP table and WP view

* Make dropdown in Subject row visible and start fixing tests

* Fix tests

* Append wp autocomplete dropdown to body

* Pass user activation requests to edit field

[ci skip]

* Directly open select fields on click

* Include ng-select from own fork

* Add path to tsconfig.json to resolve the module

* Make attributes group id fix, so that it stays the same after reinitialisation (e.g. type change)

[ci skip]
2019-01-23 12:13:29 +01:00
Oliver Günther 3ba6913960 Implement read-only work package attributes based on status 2018-11-12 08:19:19 +01:00
Jens Ulferts df4c9376d4 attempt to stabilize feature specs 2018-10-10 09:08:38 +02:00
Oliver Günther a694f9a581 [28580] Correctly replace the work package to avoid invalid update link
The permission to edit the work package is controlled through the HAL link workPackage.update

For new work packages, add_work_packages permission leads update link of /api/v3/projects/X/work_packages/form

When saving the work package, no update links is returned (correct, since you don't have the permission).

The returning HAL+JSON is merged back into the frontend resource, leaving the old update link, which is now invalid.

https://community.openproject.com/wp/28580
2018-09-25 14:20:24 +02:00
Oliver Günther 900cc7f985 [28123] Avoid balloon editor, instead use full and constrained classic build
https://community.openproject.com/wp/28123
2018-07-31 08:59:57 +02:00
Jens Ulferts 319f33e924 remove textile 2018-07-17 12:14:51 +02:00
Oliver Günther e7384aedf3 Fix markdown specifics for Chrome 2018-04-12 09:45:28 +02:00
Oliver Günther 1cd13c9d48 Merge remote-tracking branch 'origin/dev' into feature/commonmark-and-ckeditor 2018-04-03 08:53:05 +02:00
Oliver Günther 2a90971b4f Ensure input field is enabled when editing it 2018-03-28 14:53:58 +02:00
Oliver Günther bff8926898 Distinguish between textile and markdown spec 2018-03-01 08:19:22 +01:00
Oliver Günther 88a5e787ce CKEditor5 config and bundle for OP 2018-02-12 15:38:10 +01:00
Henriette Dinger 89e8c316a5 [25512] More prominent work package status selector (2) (#5999)
* Add new WP status selector button [WIP]

* Change styling and add little permission handling

* Store changed status

* Adapt new styling

* Show status depending on the changeset

* Remove status button from create form && reduce height of info row

* Adjust test cases, add success message, support for help texts and transfer css variables

[ci skip]
2017-11-17 16:26:56 +01:00
Jens Ulferts 5d1c3bc06f Merge branch 'release/7.3' into dev 2017-11-09 11:34:04 +01:00
Oliver Günther 7802034bac [26611] Avoid global preventDefault
This causes the multivalue change event to fail complete in Chrome.
For consistency, I added the ngModelOptions to clarify use of
getter/setter on the model variable.

https://community.openproject.com/wp/26611
2017-11-08 18:28:04 +01:00
Oliver Günther b15f07ea32 Scroll to element when blocked by overflow
The details view blocks certain elements of the table, causing
clicks to no longer work in newer Firefoxen

This is mainly caused by
https://bugzilla.mozilla.org/show_bug.cgi?id=1295538
2017-10-18 15:11:04 +02:00