30 Commits

Author SHA1 Message Date
Oliver Günther ca53474292 Keep principal selected on error 2025-10-21 10:01:34 +02:00
Oliver Günther 3cd7157404 Add warning if user does not have permission in current project, but others 2025-10-21 10:01:30 +02:00
Oliver Günther 9a4f69cfbb Adapt spec 2025-10-21 10:01:30 +02:00
Jan Sandbrink 0b87e7543f Freeze string literals in specs
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
Tobias Dillmann 43902eeb12 add specs for user invitation modal 2024-10-28 09:10:04 +01:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard 8fa8584538 Run rubocop --autocorrect on all files
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Aaron Contreras 9533a3089c Strengthen users/invite_user_modal/custom_fields_spec 2023-06-29 09:25:06 -05:00
Aaron Contreras 030a7a0596 Switch users/invite_user_modal/invite_user_modal_spec to cuprite 2023-06-28 05:19:04 -05:00
Aaron Contreras 3dbe501592 Switch users/invite_user_modal/custom_fields_spec to cuprite 2023-06-28 05:19:04 -05:00
ulferts 053209c2de use retry_block in flickering spec 2023-05-05 09:41:24 +02:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Oliver Günther c4b1d29b12 Add action slot for inputs below it, don't impose padding on it
The padding was meant for the attribute-help-text icon and accidentally
got moved into the text below the input, causing it to be non-aligned.
2022-09-28 13:56:35 +02:00
Oliver Günther e76ad458bc Merge remote-tracking branch 'origin/dev' into feature/spot-form-field 2022-09-22 20:35:16 +02:00
Behrokh Satarnejad 8dec25034b [43842] Re-design and small changes to modal dialogues (DS) for coherence (#11246)
* wp deletion modal changes

* fix test fails

* invite user modal changes

* fix eslint issus and add cancel button to summary modal

* add widget modal changes

* new board modal changes

* form configuration modal changes and remove unnecessary class

* WP table export modal changes

* WP save query modal changes

* visibility setting modal changes

* help text modal changes

* help video modal changes

* 2FA password confimation modal changes

* Delete EE token modal changes

* fix eslint errors

* eslint does not check the unbound method

* minor changes to switch the buttons and icon

* fix specs failing for invite user modal changes

* use the correct translations and revert the previous merge

* Fix opAutofocus directive

The opAutofocus directive was not setting focus if used like a normal
`autofocus` HTML attribute:

```
<input opAutofocus />
```

The above example would not produce a focus, because counterintuitively
Angular treats the default input to the directive here as an empty
string instead of undefined. This causes the default value of `true` NOT
to be set. Instead, the empty string was treated like the falsy value
it is.

* add focus on invite user modal while opening

* fix eslint errors

* eslint errors fix

* add icon delete for deleting ee token

* wp delete modal changes: remove unnecessary loading and change op-icon to a span

* remove unused components

* use spot-list for add-widget modal

* wp table configuration modal changes

* fix finding list item in add widget modal specs

* Chore/modal spacing (#11314)

* [chore] reworked spot-container spacings

* [chore] applied spot-container to spot-modal--body

- added style override for spacing within modal body

* [chore] removed unused modal footer class

* Remove scrollbar from project-include

Project include was creating scrollbars for the project list even if
it was not needed. This was caused by tooltips that were hidden in the
background but still affecting layouting.

This commit hides the tooltips correctly, and aligns the HTML structure
of project include to match that of file link list. A minimum height is
added to the project include list to make sure tooltips are readable even
if there is only one item in the list.

* [chore] rework of datepicker modal

- changed spacings, removed inner margins
- changed anchors to buttons (spot-link)
- added flatpickr override
- removed min-height
- moved project include min-height to root element

* [chore] fixed test selector

Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>

* redesign the save query modal changes

* remove op-form class from invite user modal since we have spot-container now

* add text and title for ee modal deletion

* showing the error message when it is not valid value in invite user modal

* close the inroduction video modal  with button

* close the dynamic content modal without jquery

* fx eslint warnnings

* webhook response modal

* remove multiple cancel translation in invite user modal

* fix indentation in html file

Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>
Co-authored-by: Eric Schubert <38206611+Kharonus@users.noreply.github.com>
2022-09-22 15:54:22 +02:00
Benjamin Bädorf c1d0e02629 Change all usage of op-form-field` to spot-form-field
* `op-form-field` was used both as a BEM block as well as a component.
  This commit removes usages of `op-form-field` in both instances.
* It changes all usages of `opFormBinding` to `spotFormBinding`.
* It removes all old files related to `op-form-field`.
2022-09-21 17:20:02 +02:00
Dombi Attila 367555397d [#43257] Fix Can not find users with the user creation/invitation form
https://community.openproject.org/work_packages/43257
2022-07-19 08:12:03 +02:00
Henriette Darge 70016a2417 Adapt autocomplete helper since ui-autocomplete does not exist any more and the project autocomplete HTML structure has changed 2022-06-24 10:26:10 +02:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
ulferts fe1e742a64 Fix/project in user invite validation (#9272)
* validate project in invite modal

The user might have the manage_member permission in a project but not
necessarily in the one the modal is opened in.

* resurface invite_user_modal spec deleted in b50298eb30

* allows users without manage_placeholder to add placeholder to project
2021-05-18 08:01:01 +02:00
Benjamin Bädorf 68949daa03 Feature/35521 ium capabilities (#9158)
* Started experimenting with capabilities

* Started adding akita store

* Use current user store to filter projects

* Work on integrating capabilities

* Added capability checks

* Fix project select

* Working on ium specs

* Change ng select option list format

* Fix proejct search label

* Fix some specs

* Fix issue with principal select

* Add spec for missing placeholder user capabilities

* Add new capability specs, fix existing ones

* Fix import

* Update shrinkwrap

* Add JSDoc deprecations

Co-authored-by: Oliver Günther <mail@oliverguenther.de>
2021-04-21 07:54:34 +02:00
Benjamin Bädorf 79832c27ea Invite user modal fixes (#9107)
* Improve invite button styling

* Put buttons on the right hand side inside modals, highlight next buttons, show newlines for invitation message

* Fix form-field invalid styles, fix some i18n typos

* Fix modal close button position

* Updat emobile and scroll styling

* Show email instead of name when inviting a new user

* Remove close on escape

* Force autofocus of message input

* Fix typing

* Update texts

* Fix translation string, update op-link inline styles, add autosizing to textarea

* Injecting CreateAutocompleterComponent to trigger onUserInvited

* Dirty fix for the data coming out of the modal

* Adapt Constructor of TimeEntryWorkPackageAutocompleterComponent

Co-authored-by: Aleix Suau <info@macrofonoestudio.es>
Co-authored-by: Oliver Günther <mail@oliverguenther.de>
2021-04-01 11:39:16 +02:00
Oliver Günther d329db23ff Finish user invite modal (#9061)
* Fix some ium stylings

* Extend create service to also test with empty names

* Add PrincipalLike type to pass around non-created placeholder refs

* Add icon-context

* Move principal rendering to its own module

* Fix emit create new placeholder to principals

* Revert op-principal for now

* Add memberships form API to properly post

* Fix types for returned principals

* Move untilDestroyed in role

* Filter input if not string in role-search

* Pass correct inputs to success component

* Return principal after saving membership

* Fix small stuff around  the ium

* Fix the way HalResources are selected and passed

* Move principal module to be exported by common

* Disable quotemark in tslint until eslint is enabled

* Fix image path in success

* Adapt modal to run all steps in one within the modal helper component

* Several fixes to modals

* Fix ium success component styles,
* Registration modal y-overflow
* Add SMTP parameters to .env.example

* Add disabled option to op-option-list, disabled placeholder users for non-ee instances

* Add correct ee link to placeholder user option

* Fix build

* Removed unused sass files

* Fix principal search not found indicator, added placeholder add image

* Fix enterprise edition url, use dirty instead of touched check

* Use backend class names for frontend principal types

* Fix duplicate import and principal type usage

* Also disable banners if with_ee is present in test

* Extend specs for placeholders

* Fix disabled attribute

* Extend spec WIP

* Improved inline-validation styles, fixed more PrincipalType usages

* Add group happy path test, fix more PrincipalType usage

* Fix a translation

* Revert line deletion

* Rewrite same spec examples into shared examples

* Fix name of shared example

* Dont run assets:clean to remove angular assets

* Output whether assets are there at all

* Fix placeholder path

* Revert "Output whether assets are there at all"

This reverts commit 42219c2755.

Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>
2021-03-04 21:47:25 +01:00
Aleix Suau 44cf9e0c5e Epic/placeholder users frontend (#8977)
* Add new button added to select-edit-field

* Permissions Service + show button if canInviteUsersToProject

* Permissions Service + show button if canInviteUsersToProject

* Add initial invite user modal

* Small change to invite user modal

* Small use rmodal changes

* Builds

* Added invite user modal title translation

* Changed modal to module

* Figured out basic modal setup

* Fixed build

* Started adding option-list component

* Adding reactive forms

* vim

* Reactive forms working for option-list

* op-form-field is implemented, project-selection step works

* Working on principal step

* Basics of principal selection are done

* Remove console logs

* Added role step and role api bindings, updated directory structure

* Added basics of message step

* Added summary page

* Add in-project check for selected principal

* Add documentation for principal filters

* Create modal-heading component

* Fix principal emit

* Add API calls to summary component

* Work on translations, rework close fn

* Added translations

* Fixed styling

* Add autofocus, fix typing

* Improve typing

* Add form-binding directive to fix form-field

* Fixed typescript errors

* Fix more translations

* Codeclimate and TSLint errors

* Failing test commented with TODO

* Codeclimate fixes

* Codeclimate fixes

* Open invite user modal from user selection

* Remove console and debugger calls

* Opening modal from CreateAutocompleterComponent

* Add new button added to select-edit-field

* Permissions Service + show button if canInviteUsersToProject

* Permissions Service + show button if canInviteUsersToProject

* Codeclimate and TSLint errors

* Failing test commented with TODO

* Codeclimate fixes

* Codeclimate fixes

* Add initial invite user modal

* Small change to invite user modal

* Small use rmodal changes

* Builds

* Added invite user modal title translation

* Changed modal to module

* Figured out basic modal setup

* Fixed build

* Started adding option-list component

* Adding reactive forms

* vim

* Reactive forms working for option-list

* op-form-field is implemented, project-selection step works

* Working on principal step

* Basics of principal selection are done

* Remove console logs

* Added role step and role api bindings, updated directory structure

* Added basics of message step

* Added summary page

* Add in-project check for selected principal

* Add documentation for principal filters

* Create modal-heading component

* Fix principal emit

* Add API calls to summary component

* Work on translations, rework close fn

* Added translations

* Fixed styling

* Add autofocus, fix typing

* Improve typing

* Add form-binding directive to fix form-field

* Fixed typescript errors

* Fix more translations

* Refactor/op modal (#8978)

* Initial modal refactoring

* Updated modal imports

* More modal module imports

* Fix one more import

* Fixed some styles

* Fixed failing modal specs

* Fix more spec selectors

* Fix more specs

* Updated backend modals

* Improved code style

* Fix export modal styles

* Fix wiki export modal

* Fix more specs

* Fix webhooks modal

* Added loading indicator back into modals

* Fixed wp preview modal

* InviteUserButtonComponent in

* InviteUserButtonComponent in

* InviteUserButtonComponent in MultiSelectEditFieldComponent and SelectEditFieldComponent

* Remove extraneous module

* Add Dragula import

* Remove empty spec

* Fix option-list component

* Remove group creation from invite user modal

* Write feature spec

* Fix TS errors

* Add Placeholder and Group apis to the frontend

* Better api typing

* Remove unnecessary interface

* Remove group creation call

Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>
Co-authored-by: Oliver Günther <mail@oliverguenther.de>
Co-authored-by: Benjamin Bädorf <hello@benjaminbaedorf.eu>
2021-02-26 14:38:14 +01:00