32 Commits

Author SHA1 Message Date
Alexander Brandon Coles 712fdbceba Harden feature test support helpers
Stabilize shared ng-select interactions for Cuprite and reuse open
dropdowns safely in modal-based flows. Also keep filter clearing
safe when no value is selected and refresh the My Page drop target
after drag-induced DOM updates.
2026-04-17 10:15:39 +01:00
Oliver Günther 5041176e9e Fix stale element in my_page_spec
Stale element reference during drag-and-drop. CDK drag restructures
the DOM between the click_and_hold and release phases,
invalidating the drop_area.native Selenium reference held from before the drag started.
2026-04-08 09:51:41 +02:00
Henriette Darge cbeaa51970 Add comments and replace sleep timeouts 2026-02-24 10:20:08 +01:00
Behrokh Satarnejad 04aa644370 fix failures in tests 2026-02-17 08:42:47 +01:00
Jan Sandbrink 0b87e7543f Freeze string literals in specs
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
Klaus Zanders 34ae4bb74c fix tests for the my page 2025-01-15 10:09:06 +01:00
Dombi Attila e1ab8638ee Fixing flaky spec 2024-04-03 20:10:09 +03:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard 8fa8584538 Run rubocop --autocorrect on all files
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
Christophe Bliard 9e865b4f7b lint: Run rubocop safe autocorrect
Command is `rubocop --safe --autocorrect app lib lib_static modules spec`
2023-03-09 10:25:57 +01:00
Christophe Bliard 6d5f9e36fc Add 'Project details activity' menu entry
Added to the Project details widget on project overview page.

Displaying the menu entry conditionally depending on the activity module
being activated is done through a public permission. Capabilities
endpoint has been extended to include actions from public permissions.
2023-01-23 09:31:21 +01:00
Christophe Bliard 8785caa17b Add failing acceptance test for Project details activity 2023-01-23 09:29:37 +01:00
Christophe Bliard e3f4a6b582 Include Capybara::RSpecMatchers where DSL is included
This is needed to make these two statements equivalent:

    expect(page).not_to have_xpath('a')
    expect(page).to have_no_xpath('a')

So that the both matchers return early on element absence, instead of
timing out.

This is the continuation of e85b47979a.
2022-11-14 11:52:52 +01:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
Benjamin Bädorf 3aaac1c7ce Rename most notification to toaster instances (#9765)
* Rename most notification to toaster instances

* Frontend builds

* Fix spec build

* Rename more notification elements to toaster

* Rename toaster-box to op-toast

* Fix op-toast-container

* Rename toasters upload progress

* Try fixing page.rb toaster check

* Fix some specs, break some others

* Correctly overwrite toast_type

* Fix more specs

* Fix one more notification to toaster rename

* Fix linting errors, harmonize naming more

* Remove byebug debugging statement

* Remove byebug debugging statement

* Rename notification in the backend, too

* Rename more instances of notifications to toastService

* Rename backend back to notification since bundle gems expect it there

* expect_toaster -> expect_toast

Co-authored-by: Henriette Darge <h.darge@openproject.com>
2021-11-04 16:25:55 +01:00
Oliver Günther 46599dd90e [37274] Remove accessibleClick (#9355)
* Remove accessibleClick from wp-single-card

* Remove accessibleClick directive itself

* Fix context menu with button

* Add common mixin for unset-button-styles

* relations button

* Editable query and toolbar

* Resizer button

* Replace wp-create button

* Replace relation description value

* Replace type form

* Replace pagination links

* Replace button styles for attachment dropzone

* Replace accessibleClick in tile-view

* Replace inline create

* Replace display container with button

* Replace text in notification on boards error

* Replace global search component

* Fix pagination spec

* Fix specs

* Fix triggering display field on enter

* Make search toggle a button

* Review feedback
2021-06-14 11:39:04 +02:00
ulferts 1bdd2ab9ae safe automatic fixes by rubocop (#8994) 2021-02-11 16:02:18 +01:00
Cyril Rohr b4086b2968 Standalone CI docker container (#8943) 2021-02-02 15:33:33 +01:00
Oliver Günther e3bb5c9de4 Dismiss the notification before opening items 2019-10-09 13:12:30 +02:00
ulferts dc66f16eb1 use custom resize icon 2019-09-06 08:56:58 +02:00
ulferts ddf08af31d display grid resizer only on hover 2019-09-05 10:17:27 +02:00
ulferts 4ac48a88ae auto height for grid-areas 2019-08-27 11:22:34 +02:00
ulferts c1b0befb22 restrict actions on grid for users lacking edit permissions 2019-08-15 09:10:42 +02:00
ulferts 9cc71658fd use icon context menu in grid 2019-06-25 15:59:42 +02:00
Jens Ulferts 6fb9077384 next attempt at travis failure 2019-01-25 14:31:18 +01:00
Jens Ulferts 9dce8b84bc attempt to fix test on travis 2019-01-25 13:12:39 +01:00
Jens Ulferts 2c9525f221 refactoring grid component 2018-12-18 21:22:31 +01:00
Jens Ulferts 22242aa6e9 spec d&d widgets 2018-12-09 22:52:42 +01:00
Jens Ulferts de2735f797 implement time entries widget 2018-12-07 08:26:03 +01:00
Jens Ulferts 05211a4f92 hook up frontend to backend 2018-12-03 20:39:33 +01:00