133 Commits

Author SHA1 Message Date
Ivan Kuchin b648341030 [#74768] Remove calculated_value_project_attribute feature flag
https://community.openproject.org/wp/74768
2026-05-19 17:42:42 +02:00
Henriette Darge 6df4d08b9d Add permission check for showing the project attribute widgets 2026-03-20 14:38:28 +01:00
Henriette Darge c7afb4968f Get inplaceEditField for customField dynamically by the format instead of registring them all directly 2026-03-20 08:40:33 +01:00
Henriette Darge adb88c979b Some more test fixing.. There is light and the end of the tunnel :fingers_crossed: 2026-03-19 15:10:27 +01:00
Henriette Darge ee83264379 Continue the endless journey of adapting the tests to the new inplaceEditFields. 2026-03-18 14:03:52 +01:00
Henriette Darge f2410d0b43 Add comment fields to the displayFields in case a user w/o permissions opens the dialog to see the comment in readonly mode 2026-03-18 10:08:11 +01:00
Henriette Darge a445cc196c * Take care that newly created CF are also correctly registered
* Introduce spec helper for inplace edit fields
* Preserve system_arguments for calculated fields when they are updated
2026-03-17 15:13:21 +01:00
Henriette Darge a6f54aa86b Start adapting features tests to new inplace edit functionality 2026-03-16 12:01:04 +01:00
Ivan Kuchin e13e4cd006 test readonly custom field modal from project overview 2026-03-05 17:39:00 +01:00
Ivan Kuchin f1eb93ea0b test saving custom comment 2026-03-05 17:39:00 +01:00
Ivan Kuchin 214ecdae35 test preserving custom comment in overview modals after failed validation of value 2026-03-05 17:38:59 +01:00
Ivan Kuchin fa60968f8a test custom comment inputs in modals opened from overview 2026-03-05 17:38:59 +01:00
Ivan Kuchin a6deb71c28 test conditions for showing modal buttons 2026-03-05 17:38:59 +01:00
Ivan Kuchin 1432c7b747 use an before vowels 2026-03-05 17:33:23 +01:00
Ivan Kuchin c19193c5bd extract method to submit dialog in overview custom field update spec 2026-03-05 17:33:22 +01:00
Ivan Kuchin 7a96165208 add dialog helper to not repeat dialog opening 2026-03-05 17:33:22 +01:00
Ivan Kuchin 05d5c31403 rename open_edit_dialog_for_custom_field helper to open_modal_for_custom_field 2026-03-05 17:33:21 +01:00
Ivan Kuchin 86f3b831b2 use more general modal buttons instead of edit buttons in permissions spec 2026-03-05 17:33:21 +01:00
Ivan Kuchin dc0cdd1b81 use block of factory method in project custom fields overview shared context 2026-03-05 17:33:21 +01:00
Ivan Kuchin 5a89078072 extract DialogComponent for shared behaviour between Edit and Show dialogs 2026-02-25 16:00:30 +01:00
Henriette Darge 2b31d05f0a Merge pull request #21612 from opf/code-maintenance/68481-remove-new-project-overview-feature-flag
[#68481] Remove new project overview feature flag
2026-02-24 12:20:13 +01:00
Henriette Darge 0fbb221c33 Merge remote-tracking branch 'origin/dev' into code-maintenance/68481-remove-new-project-overview-feature-flag 2026-02-24 10:39:21 +01:00
Alexander Brandon Coles a6ae097715 Merge branch 'dev' into merge-release/17.1-20260223125632 2026-02-23 11:45:18 -03:00
Oliver Günther 6e8df4ce22 Revert specs changed for external redirect behavior again when not active 2026-02-23 10:24:43 +01:00
Jens Ulferts eca0b60754 Merge pull request #21878 from opf/task/71375-refactoring-while-adding-custom-field-comments
Task/71375 refactoring while adding custom field comments
2026-02-10 15:27:47 +01:00
Tobias Dillmann 050572066f [#70315] Merge release/17.1 2026-02-06 09:43:00 +01:00
Ivan Kuchin 982fbf520a use custom field section title for dialog title 2026-02-05 14:15:10 +01:00
Ivan Kuchin bc0d5c5443 rename ProjectCustomFieldEditController to ProjectCustomFieldModalController
It is going to allow also to view comment for users with view, but no
edit permission
2026-02-05 14:15:08 +01:00
Oliver Günther 1857f25b58 Primerize static link helper and use that for external links consistently 2026-02-03 11:41:43 +01:00
Tobias Dillmann 432ef67ce4 [#70315] Bulk update service respects project creation wizard settings 2026-01-26 08:48:11 +01:00
Tobias Dillmann e0f2587743 [#70315] Consider creation wizard in mapping spec 2026-01-26 08:48:10 +01:00
Tobias Dillmann c7e8cb84a4 [#70315] Add "for all projects" specs 2026-01-26 08:48:09 +01:00
Alexander Brandon Coles 9819eb1cca [#68481] Remove new project overview feature flag 2026-01-09 11:27:53 +01:00
Henriette Darge caa609d34c [61445] Configure project attribute sections to be shown as widgets on the project overview page (#20899)
* Show project attributes as sections in project overview

* Introduce a column "shown_in" for CustomFieldSection which defines whether the section shall be shown in the sidebar or the main section of the project overview

* Show only those attributes in main section that are configured to be shown there. Same for the sidebar.

* Update project attribute sections after editing them

* Write a test for the new positioning behavior of project attribute sections

* Rename "shown_in" with "display_representation" and make it a hash

* Provide proper default when creating a new section

* Enforce project attribute widgets to be in a new line and wrap properly

* Hide logic for moivng sections to the main area behind the feature flag

* Rename "main section" to "main area"

* Extract custom margins into normal sass

* Rename "side-panel" to "side panel"

* Update test to changed wording
2025-11-19 08:01:42 +01:00
dombesz 7928953a82 Merge pull request #20961 from opf/dependabot/bundler/dev/capybara_accessible_selectors-v0.15.0
Bump capybara_accessible_selectors from v0.14.0 to v0.15.0
2025-11-17 22:40:24 +01:00
Alexander Brandon Coles 7873263576 Switch features using accessible_name to Cuprite
Switches features that were previously had to resort to Selenium to make
use of `accessible_name` to Cuprite.
2025-11-12 22:13:01 +00:00
Dombi Attila 652551d537 [#68040] Switching a multi select list cf to a single select cf of projects breaks opening the editing modal on the overview page
https://community.openproject.org/work_packages/68040

Change the custom_value_for method signature to always use a custom field.
2025-11-12 20:25:16 +02:00
Eric Schubert 4ec381034a [#68700] add enterprise switch to test setups 2025-11-03 21:50:25 +01:00
Eric Schubert d46545e694 Merge branch 'release/16.6' into implementation/68700-rename-to-weighted-item-list 2025-11-03 17:23:47 +01:00
Eric Schubert 38d5222c5b [#68700] replace score with weight
- add migration for db column name
- update AR relations in code
- update display texts and locale keys
- update test, method, class, variable names
- fix formatting mistake in item base controller
2025-11-03 13:58:05 +01:00
Dombi Attila 5b43bdfd6f Address minor CR comments 2025-11-03 13:48:41 +02:00
Dombi Attila 513792ef89 [#67839] "Required for all projects" should not require a value to be set for a Calculated Value
https://community.openproject.org/work_packages/67839
2025-11-03 13:48:00 +02:00
Yauheni Suhakou 0de0713a53 Big rename
Renames `scored_list` to `weighted_item_list`
2025-10-30 15:36:55 +01:00
Eric Schubert deaec0c8a5 [#67623] remove feature flag for weighted item list
- https://community.openproject.org/wp/67623
2025-10-30 15:07:02 +01:00
Dombi Attila aaa2b2b6a0 Address CR comments 2025-10-22 21:26:17 +03:00
Dombi Attila 0c2ef21a1f Remove unnecessary dialog closing code 2025-10-22 20:32:58 +03:00
ulferts b543f82ede Merge branch 'feature/63550-allow-editing-of-individual-work-package-project-attributes-even-if-certain-other-attributes-are-invalid-eg-required-field-empty' into implementation/66115-switch-from-section-based-editing-to-one-modal-per-attribute 2025-10-22 19:14:14 +02:00
ulferts edf3c709e3 Merge remote-tracking branch 'origin/dev' into feature/63550-allow-editing-of-individual-work-package-project-attributes-even-if-certain-other-attributes-are-invalid-eg-required-field-empty 2025-10-22 18:17:40 +02:00
Dombi Attila f979020cd2 Fix rubocop issues. 2025-10-21 09:37:05 +03:00
Dombi Attila 29d0569420 Fix specs and rename the edit dialog title to "Edit attribute" 2025-10-21 00:06:08 +03:00