29 Commits

Author SHA1 Message Date
Oliver Günther 6e8df4ce22 Revert specs changed for external redirect behavior again when not active 2026-02-23 10:24:43 +01:00
Oliver Günther 1857f25b58 Primerize static link helper and use that for external links consistently 2026-02-03 11:41:43 +01:00
dombesz 7928953a82 Merge pull request #20961 from opf/dependabot/bundler/dev/capybara_accessible_selectors-v0.15.0
Bump capybara_accessible_selectors from v0.14.0 to v0.15.0
2025-11-17 22:40:24 +01:00
Alexander Brandon Coles 51ceb64d28 Replace deprecated CAS described_by
Per Capybara Accessible Selectors CHANGELOG

> Deprecated the `described_by` filter in favour of `accessible_name`.
> This is now a synonym of `accessible_description` and will create
> warning.

See https://github.com/citizensadvice/capybara_accessible_selectors/blob/main/CHANGELOG.md#v0150
2025-11-12 22:11:43 +00:00
Behrokh Satarnejad 0a2ff1e320 test for parent link existing 2025-11-11 17:02:10 +01:00
Behrokh Satarnejad dbbefcc44e fix failing tests in project settings page and breadcrumbs spec 2025-11-05 12:59:47 +01:00
Behrokh Satarnejad 51d9300054 verify that rel is set on external links in spec 2025-10-28 14:56:33 +01:00
Behrokh Satarnejad 165d639b9d A feature spec scenario for target="_blank" links 2025-10-28 14:56:33 +01:00
Behrokh Satarnejad a0981dba91 add a test for empty and download links 2025-10-28 14:56:33 +01:00
Behrokh Satarnejad 4cf2fb5648 use href for mutation attribute 2025-10-28 14:56:33 +01:00
Behrokh Satarnejad 6e4f74f0e3 add a feature spec 2025-10-28 14:56:33 +01:00
Behrokh Satarnejad 1846e1686f [65606] Inform users on screen-readers that links will open in a new tab (ARIA-describedby) (#20371)
* [#65606] Apply description to links with blank target

Uses a `ExternalLinksController` Stimulus controller to set
`aria-describedby` on all links with `target="blank"`. Uses a
`MutationObserver` to ensure links that are added to the DOM dynamically
(e.g. via Turbo Drive) are also updated.

Co-Authored-By: Behrokh Satarnejad <62008897+bsatarnejad@users.noreply.github.com>

* add a documentation for the controller

* Add simple feature spec for external links

* Append id to aria-describedby if existing value

* Update the documentations on the lookbook for the links

---------

Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com>
2025-09-19 11:16:30 +02:00
Alexander Brandon Coles 1110f6b91f Merge branch 'dev' into merge-release/16.2-20250709034943 2025-07-09 08:21:02 +01:00
Henriette Darge 73d3ec67cf Fix breadcrumb spec 2025-07-08 09:58:44 +02:00
Henriette Darge a62ee876d7 Add a test for the breadcrumb behaviour 2025-07-04 15:12:52 +02:00
Dombi Attila c47b738dbf Focus the datepicker banner when switching scheduling mode via the keyboard. 2025-07-02 01:21:18 +03:00
Jan Sandbrink 0b87e7543f Freeze string literals in specs
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
Oliver Günther b214c61315 Reset some specs 2025-01-14 13:23:57 +01:00
Oliver Günther f791d33b72 Replace specs 2025-01-14 10:20:35 +01:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Aaron Contreras f93a687242 Bulletproof specs :) 2024-02-05 17:23:24 -05:00
Aaron Contreras 2afb0cf1e2 Add accessibility specs for alternative filter matches
Adds specs for the expected behavior of alternative name matches
for the filter work package autocompleter.
2024-02-05 13:46:53 -05:00
Christophe Bliard 8fa8584538 Run rubocop --autocorrect on all files
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Christophe Bliard 6d0a7a4104 Add axe a11y test for Home page content
Issues found by axe-core and fixed:

Found 1 accessibility violation:

1) image-alt: Images must have alternate text (critical)
    https://dequeuniversity.com/rules/axe/4.8/image-alt?application=axeAPI
    The following 2 nodes violate this rule:

        Selector: .widget-box--teaser-image
        HTML: <img _ngcontent-ng-c3812879498="" class="widget-box--teaser-image op-new-features--teaser-image" src="/assets/frontend/assets/images/13_0_features.svg">
        Fix any of the following:
        - Element does not have an alt attribute
        - aria-label attribute does not exist or is empty
        - aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
        - Element has no title attribute
        - Element's default semantics were not overridden with role="none" or role="presentation"

        Selector: .widget-box--blocks--upsale-image
        HTML: <img class="widget-box--blocks--upsale-image" src="/assets/enterprise-add-on.svg">
        Fix any of the following:
        - Element does not have an alt attribute
        - aria-label attribute does not exist or is empty
        - aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
        - Element has no title attribute
        - Element's default semantics were not overridden with role="none" or role="presentation"

Also removed useless title attributes from <img> tags
2023-11-16 11:59:43 +01:00
Christophe Bliard deaaa27666 Rename accessibility tests folder 2023-11-16 09:29:27 +01:00