8 Commits

Author SHA1 Message Date
Alexander Brandon Coles 7020778ee5 [OP-19470] Update Angular to v22
Force updates Angular dependencies:

    ng update @angular/core@22 @angular/cli@22 --force

And performs automated upgrade:

= Adds `ChangeDetectionStrategy.Eager` to all components.
- Adds 'withXhr' to 'provideHttpClient' function calls when the
  'HttpXhrBackend' is used.
- Wraps optional chaining expressions in $safeNavigationMigration().
- Disables the 'nullishCoalescingNotNullable & optionalChainNotNullable
  extended diagnostics.
- Adds 'strictTemplates: false' in tsconfig.json when not set.

https://community.openproject.org/wp/OP-19470
2026-06-07 21:01:53 +01:00
Alexander Brandon Coles 6e8510ca1d [#66563] Migrate specs to Vitest
Apply Angular's Vitest migration schematic to update frontend and plugin
specs from Jasmine globals to Vitest APIs.

    ng g @schematics/angular:refactor-jasmine-vitest

Fix migrated edge cases where async assertions or shallow tests changed.

https://community.openproject.org/wp/66563
2026-05-08 09:52:17 +02:00
Alexander Brandon Coles 39b29c2789 Update Angular to v19
Force updates Angular dependencies:

    ng update @angular/core@19 @angular/cli@19 --force

And performs automated upgrade:

- Updates non-standalone Directives, Component and Pipes to
  'standalone:false' and removes 'standalone:true' from those who are
  standalone.
2025-07-22 18:22:19 +01:00
Alexander Brandon Coles 1044570cee Add missing declarations to pull-request spec
Fixes additional schema warnings.
2025-01-27 08:15:04 -03:00
Alexander Brandon Coles 1f71972eda Fix stub, selectors in pull-request component spec
Updates spec for store changes made in 077112d and template changes in
9fbb746.
2025-01-27 08:15:03 -03:00
Benjamin Bädorf 3a877457ad Feat/frontend linting (#9424)
* Change eslintrc config

* Try esprint fix

* Run linter fix

* Set most of the typescript linting rules to warn, run with --fix

* Fix some linting errors

* Optimize imports

* Build works again

* Remove fixes that didn't fix anything

* Make imports lint-conform again && disable trailing underscores as it is part of Angular and our convention

* Remove wrong automated fix

* Rename components with suffix "Component" for linting

* Linting, refactor reorder-delta-builder to a more functional style

* Update delta reorder specs

* Add exceptions for "++" in loops and bracket expressions in arrow functions

* Some linting fixes

* Fix some more linting

* Optimize imports

Co-authored-by: Henriette Darge <h.darge@openproject.com>
2021-07-08 15:38:01 +00:00
Wieland Lindenthal e72d940b5b Feature/37108 improve design of GitHub tab (#9329)
* Rename Git button to 'Git snippets'

* Change font for Github tab header

* Improve design of pr status badges

* Reorganize the design of PR headers

* Improve design of PR checks

* Improve design of git snippets menu

* Remove WP description from commit message and command

* Fix frontend specs for github integration

* Adding dots to the end of phrases.

* Github Integration: reduce dom depth. remove last border under PR

* Add target blank to PR details link & other fixes

* Fix work_package_github_tab_spec.rb

* Remove fdescribe

* Improve layout of Github pull requests tab header

* Add title to Github check icon

* Refactor classnames for github pull requests

This introduces `op-pull-request` and `op-pr-check` as BEM blocks, both in their own sass files, but the files still scoped to the pull request component.

* Fix frontend spec. Added karma Chrome debug config.

* Fix frontend specs after refactoring styles

Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>
2021-06-01 10:29:05 +02:00
Philipp Tessenow 2f9d252456 Show github pull requests in the GitHub tab (#9148)
* WIP: prototype wiring up the API with the angular frontend

* little refactorings in namespace and loading logic

* frontend styling and polishing

* pairing with aleix

* Avoid empty pullRequest.githubUser to be displayed

* added feature specs, a workaround for a pr-reload-bug in angular, and some readme improvements

* Title for partial PRs added

* GitActionsMenuComponent tests

* Test improvements

* GitHubTabComponent tests

* TabHeaderComponent tests

* TabPrsComponent tests

* revert change to karma runner

* start styling

* i18n in component

* avoid container element

* git actions menu tests

* Github interfaces

* PullRequestComponent tests

* Comment removed

* Typings improvements

* Merge fixes

* Tests fixes

* fix: wp list id links working with tabs

* remove partial github pr state

A PR might still be incomplete but enough data can be pulled from a github issuee notification to fill in most of the information

* avoid duplicate spec

* Fix import paths of op-icon

Co-authored-by: Aleix Suau <info@macrofonoestudio.es>
Co-authored-by: ulferts <jens.ulferts@googlemail.com>
Co-authored-by: Oliver Günther <mail@oliverguenther.de>
2021-05-06 16:40:37 +02:00