286 Commits

Author SHA1 Message Date
Henriette Darge c74076a173 Merge pull request #23373 from opf/bug/64359-work-package-configuration-dialog-s-highlighting-tab-has-no-space-between-radio-buttons-and-labels
[64359] Work package configuration dialog's highlighting tab has no space between radio buttons and labels
2026-05-28 14:13:29 +02:00
Oliver Günther ddf7988950 Wait for board list reload
Added board_page.wait_for_lists_reload between expect_list "Closed" and
expect_card. The expect_card method checks for
.loading-indicator--background absence, but that indicator may not have
appeared yet when checked, so it passes immediately before cards are
actually loaded.
2026-04-08 10:31:39 +02:00
Henriette Darge bd14f7600b Update selection logic and adapt tests to new routing without uiRouter 2026-04-07 12:22:34 +02:00
Behrokh Satarnejad 7014e13d3e Merge pull request #22475 from opf/71063-create-a-pagination-component-based-on-the-primer-specification
[71063] Update PVC with new Pagination component and Banner styles
2026-03-25 14:02:04 +01:00
Alexander Brandon Coles 9680d2f8b2 [#73188] Remove EE guards from boards
Make action boards available in Community Edition by removing
board_view-based frontend and create-form gating, and align boards
feature coverage with the new default behavior.

https://community.openproject.org/wp/73188
2026-03-23 18:22:20 +00:00
ulferts 13a4a675a2 rename status boards to kanban boards 2026-02-18 09:17:39 +01:00
OpenProject Actions CI 40c6fdad24 Merge branch 'release/17.0' into release/17.1 2026-02-16 13:59:21 +00:00
Oliver Günther 1f690349f9 Extract queries validation into contract 2026-02-16 14:58:34 +01:00
Klaus Zanders 160f5a8424 Update specs 2025-12-15 12:56:10 +01:00
Alexander Brandon Coles 57dc5b8966 Merge branch 'dev' into merge-release/16.6-20251113034802 2025-11-13 09:02:51 +00:00
Dombi Attila bc11699ddd Change custom_value_for to return values based on the multi_value? only 2025-11-12 20:25:17 +02:00
Henriette Darge 655756631f [67007] Render the WP full view from rails (#20109)
* Create a FullView::CopyComponent for WorkPackages which is routed from rails

* Remove angular splitCopy route and component as it was overwritten by the angular fullCopy route for quite some time already and nobody complained. So we decided to remove the splitCopy completely

* Create FullView::CreateComponent for WorkPackages which is now routed from rails instead of Angular

* First draft of implementing the FullView route for WorkPackages from rails

* Pass correct tab from the URL to the FullView::ShowComponent

* Do a hard reload to "create" route when we are not routed from Angular

* Adapt routing spec to new WorkPackage routes and to some fine-tuning with the WP routes

* Show correct tab in WP Full view and change URL when clicking a tab entry

* Adapt to new rails based routing

* Fix some routes and redirects

* Make sure, the split screen stil renders correctly

* Remove back button from WP full view

* Fix routing issues

* Start fixing specs

* Attempt to override the browser history to be able to use browser back

* Use helper function to build new WP url string

* Adapt spec that now partially renders backend toasts

* Remove ability to move to fullscreen

Theoretically, we can re-add it by posting to some form endpoint, but
not worth it for the first iteration

* Disable cache-control on angular routed pages, so back links work

* Fix double click to fullscreen

* Adapt navigation and title setting

* Let WP breadcrumb to a hard reload instead of Angular transition

* Redirect when the WP route is incomplete (this is the attempt to re-implement an angular functionality)

* Navigate with Turbo when double clicking a card

* Adapt onboarding tour to new hard reload when switching to WP full view

* Fix some specs

* Fix more tests

* Hide Overview tab on FullView

* Correct check for incomplete routes

* Do a hard refresh when coming from slpit screen to full view

* Fix notification navigation

* Adapt attachment spec as the tab switch cannot be done anymore while dragging

* Fix more tests

* Please rubocop and fix more tests

* Attempt to fix navigation_spec

* Add debian_base for pullpreview

---------

Co-authored-by: Oliver Günther <mail@oliverguenther.de>
2025-11-03 09:02:16 +01:00
Eric Schubert ba381f8c04 [#67973] disable flickering spec 2025-10-08 12:08:14 +02:00
Christophe Bliard 63dd45ffab Fix test which was missing status workflows
The fixes in 7c7ebb6458 made the spec
`./modules/boards/spec/features/action_boards/custom_field_filters_spec.rb:93`
fail in job run
https://github.com/opf/openproject/actions/runs/17292632687/job/49083361666.

It appears that never really worked because a workflow was missing to be
able to change work package status from open to closed. So moving from
column Open to column Closed would fail. But actually the test was
passing because it was not properly waiting for the column to have
finished updating after moving, so it was ok. Probably it was flaky and
was sometimes failing.

Adding a proper workflow fixed it.
2025-08-28 14:27:24 +02:00
Christophe Bliard 7c7ebb6458 Fix flaky spec
failing spec: `modules/boards/spec/features/action_boards/status_type_moving_board_spec.rb:112`
failing job: https://github.com/opf/openproject/actions/runs/17290621432/job/49076891042?pr=20077

It fails because it moves the wrong card to the "Open" column. It tries
to locate the card by its text, and when it decides to move it, the card
order changes (no idea why) and both cards are swapped, resulting on the
wrong card being moved. Then the spec fails as it expects the card to be
in the other column but actually it did not move.

Sometimes, the spec passes because the card order has not changed yet
when the cards are located and moved, or the card order has already
changed before the cards are located and moved. Who knows.

Fix is to wait for the lists to properly reload after a save and moving
cards, and in the case of moving cards, it waits a little 2 secs more
just in case the order changes. It may not be reliable.
2025-08-28 12:03:03 +02:00
Behrokh Satarnejad 8565925b17 [64112] Create an angular breadcrumb as placeholder for the toggle button (#19229)
* create a breadcrumbs angular component

* change the styles of breadcrumbs component so it look like other breadcrumbs

* add breadcrumbs component to the partition query space component

* add breadcrumbs to boards

* add breadcrumbs to team planners and calendar

* add breadcrumbs to ifc viewer and wps and gantt pages

* add feature specs for modules that have breadcrumbs component

* add mobile view for breadcrumbs component

* fix mobile styles in bcf module

* remove margin-bottom from breadcrumb mobile since it has some space from toolbar title

* add a section for active breadcrumb

* move breadcrumb items for gantt and wp to a separate method

* fix urls for work packages and gantt pages when there is no project selected

* use only op- classes

* use existing translations and use capybara accessible selectors

* change gantt translation key

* fix failing test in boards

* add section header of side bar menu to the breadcrumb last item

* change css BEM styles and change the projectWorkPackages path to workPackages path

* undo css changes in bcf view

* fix failing tests

* change target of anchors

* Use real space instead of a margin so that screen readers can read it out correctly

---------

Co-authored-by: Henriette Darge <h.darge@openproject.com>
2025-06-25 15:27:21 +02:00
Christophe Bliard dc394361e1 Hide enterprise banner for action boards
They are the only type of boards available in community edition.
2025-06-18 10:14:44 +02:00
Dombi Attila 29c41c387a Fix flickering custom action button title on the work package page. 2025-04-08 23:39:19 +03:00
Oliver Günther 18574696f5 Fix specs 2025-04-07 10:55:25 +02:00
Oliver Günther b214c61315 Reset some specs 2025-01-14 13:23:57 +01:00
Oliver Günther f791d33b72 Replace specs 2025-01-14 10:20:35 +01:00
ulferts a9da1147b6 attempt to fix flickering spec 2024-12-04 09:30:24 +01:00
Aaron Contreras f7f2ec8654 Fix/stabilize board navigation specs 2024-11-13 08:16:03 -05:00
Aaron Contreras a10d97d9dd Fix/remove remaining broken specs and those no longer relevant 2024-11-13 07:18:20 -05:00
Oliver Günther a927d7f839 fix board navigation with cuprite 2024-11-05 17:13:26 +01:00
Oliver Günther e8953e7dc2 Disable cuprite while dragging doesn't work reliably 2024-10-17 16:19:36 +02:00
Oliver Günther c5e4c7a329 Merge branch 'dev' into experiment/enable-turbo-drive 2024-10-17 15:18:06 +02:00
Christophe Bliard d4d64b5858 Fix typo 2024-10-14 16:41:01 +02:00
Christophe Bliard e329baf3ee Extract have_enterprise_banner matcher 2024-10-14 16:40:27 +02:00
Henriette Darge efe54cf8ca Use Primer Button for "AddButtonComponent" 2024-10-11 09:46:24 +02:00
Oliver Günther 1ea0dc731b Replace subform 2024-10-11 08:43:02 +02:00
Oliver Günther cd2d0f0e1a Remove primerized_flash prefix in methods 2024-09-30 21:39:36 +02:00
Oliver Günther 9cc3d98391 Replace expect_primerized_error -> expect_primerized_flash 2024-09-30 21:39:00 +02:00
Oliver Günther 1cf49e2c9f Adapt specs 2024-09-30 20:37:00 +02:00
Behrokh Satarnejad 38019b6799 fix failing tests in boards 2024-09-25 16:36:46 +02:00
Christophe Bliard 0c420fbcf7 Use rspec-wait gem directly
Because rspec-wait gem was using `Timeout`, we used our own version of
its helpers since e60d440edd.

Now the gem seems to be maintained again and no longer uses `Timeout`,
so it's safe to use it again.
2024-09-19 17:12:32 +02:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
Ivan Kuchin d388423c68 move check for cuprite inside wait_for_reload helper 2024-07-29 13:06:37 +02:00
Henriette Darge 17724063da Render the Modules menu in the app header with Primer::Alpha::ActionMenu 2024-07-17 11:35:19 +02:00
Henriette Darge 896dd8e7da Merge obsolete "sidebar.sass" and "sidemenu.sass" files into one new "submenu_component.sass" and harmonize the selectors 2024-07-11 15:29:49 +02:00
Henriette Darge ee37ae08fa Adapt tests to new rails based submenu of the workpackages module 2024-07-03 13:26:25 +02:00
Jens Ulferts ba80c1dbfc Merge pull request #15931 from opf/dependabot/npm_and_yarn/frontend/dev/ng-select/ng-select-13.3.0
Bump @ng-select/ng-select from 13.2.0 to 13.3.0 in /frontend
2024-06-25 08:58:01 +02:00
Christophe Bliard 8e36b2aefc Merge pull request #15801 from opf/bug/53772-the-label-for-spent-time-is-still-visible-after-deactiving-the-module-time-and-costs-active-modules
Bug/53772 the label for spent time is still visible after deactiving the module time and costs active modules
2024-06-24 18:10:56 +02:00
ulferts 1605c40456 adapt spec helper as ng-select now passes on classes 2024-06-24 17:38:13 +02:00
ulferts 195c2b84ba spec speedup 2024-06-24 16:49:17 +02:00
ulferts 3660031344 adapt spec setup 2024-06-21 13:34:02 +02:00
Henriette Darge 42a72bfe1f Replace angular sidemenu with rails based Submenu component for the Boards module 2024-06-21 08:51:54 +02:00
Henriette Darge 0b50a4d639 Use test_selector instead of style classes 2024-05-17 17:31:21 +03:00
Dombi Attila 327bb93423 Remove explicit toast message expectation 2024-04-29 20:57:13 +02:00
Dombi Attila 3b4372b045 Fix failing specs due to toaster is not dismissed 2024-04-29 20:57:13 +02:00