The fact that it used to be called with a factory name speaks for
a history of using FactoryBot originally and then being rewritten
to use a manually written SQL insert statement.
This has now been changed so when a symbol is passed, it's taken
as a factory name and a factory is used. Only when a class name
is passed, the manual SQL path is chosen.
This is done, so that I can rely on the default-value-filling of
FactoryBot to create my test record.
Diff was achieved by running
rubocop -A --only Style/FrozenStringLiteralComment,Layout/EmptyLineAfterMagicComment,Style/RedundantFreeze
for the module folders of the affected modules.
This change is part of the effort to slowly roll out frozen
string literals across the entire application.
* update core with new primer view components version
* change h1 to h2 in news test for page header title
* fix failing test in files page header
* fix failing test in saml providers page header
* fix failing test in my page page header
* fix failing test in meetings page header
* use have_heading instead of test selector
* use have_heading instead of test selector
* use have-heading in storages test
Once the XML contains multiple certificates, the metadata hash
has a nil idp_cert. The idp_cert_multi key is always populated. However,
we never tried parsing data from there, so it was lost.
The way that the Saml::Provider right now represents multiple certificates
is to concatenate them inside the idp_cert, so the metadata parsing
has been adapted to use that.
This should be more stable, since we can change expectations regarding enterprise banners in a single place.
Co-authored-by: Oliver Günther <o.guenther@openproject.com>
This results in us having to use a bit more helpers around request and feature specs
to ensure that the configured host name also matches the requested one.
When SAML uses the HTTP-POST binding, we lose the saved back_url as the
session cookie is no longer sent due to SameSite=Lax.
We also don't want to widen SameSite to None, so we need another way to
keep this information. SAML has RelayState that we can use for storing this state.
https://community.openproject.org/work_packages/55188
Oliver Günther