When calling a service with `send_notifications: false`, the
`Journal::NotificationConfiguration.active?` will be set to `false` and
subsequent calls to set it to `true` will have no effect and log a
warning.
For this reason, it's better to use `nil` as default value for
`send_notifications` so that
`Journal::NotificationConfiguration.active?` is changed only when the
value is explicitly `true` or `false`, and ignored when the value is
`nil`.
* Add bell icon to icon font
* Add in app notification in top menu
* Add fullscreen modal
* Add notification modal and items
* Style items
* Toggle details of item
* Mark all read
* Add no results box
* wip specification for event api
* Add events table, query and index
* Send out events from WP notification mailer job
There we have the recipients present
* Add cleanup job for older events with a setting
* Hide bell notification when not logged
* Add specs for events API index/show
* Fix setting yml key
* remove pry in event creation
* Fix before hook in events API to after_validation
* Fix polymorphic association raising exception for aggregated journals
* Fix typo in read_ian
* Fix yml entry for mentioned
* Add read/unread post actions to event API and add specs
* Wire up API to frontend
* Fix order on events
* Switch to unread in notification
* Add event query
* rename WPEventService
* route wp mail sending over events
* rename spec methods
* author becomes watcher
* correct message call signature
* rename events to notifications
* renname parameter to reflect notification nature
* create author watcher for existing work packages
* Merge unreadCount from store
* Take a stab at polymorphic representers
* Fix link generation in polymorphic resources
For journals, no title is being generated however
* Fix frontend model for context
* Use timer for polling
* add notification_setting data layer
* Fix show resource spec
* Fix duplicate class in notification bell item
* Add minimal feature spec for notification
* API for notification settings
* Persist notifications
* adapt work package notification creation to notification settings
* extract notified_on_all
* consolidate wp#recipients
* concentrate wp notification in journal service
* simplify methods
* Remove unused patch endpoint
* Add specs for rendering and parsing notification settings
* Contract spec
* Update service spec
* adapt specs
* Angular notifications frontend
commit e29dced64699eb5f2443b9307c78343c9a58d1ee
Author: Wieland Lindenthal <w.lindenthal@forkmerge.com>
Date: Mon Jun 21 17:34:50 2021 +0200
Create Akita store and query for notification settings
commit 1a45c26c1a0c147d15393e49d2625aca4851a64d
Author: Wieland Lindenthal <w.lindenthal@forkmerge.com>
Date: Mon Jun 21 11:09:25 2021 +0200
Remove tabs from notificaition settings page
commit 0ea21e90c13a197f8bf2cfba1b60ddcff4e5e827
Author: Oliver Günther <mail@oliverguenther.de>
Date: Sun Jun 20 21:55:48 2021 +0200
WIP in app settings
* migrate notification data
* add project visible filter to project query
* Add inline-create and table display grouped by project
* Add notifications under admin/users
* Remove notifications partial
* Rename notififcations store to user preferences store
* Add setting for self_notified and hook that up to the backend
* Add aria-label to table checkboxes
* Restyle table and toolbar
* replace remains of mail_notifications attribute
* initialize notification settings for new user
* adapt my_preferences references
* reenable no self notified for documents
* adapt specs
* Avoid has_many :notifcation_settings
Rails magically autosaves the user's preferences when the user gets saved,
which somehow also tries to save the notfifications even when unchanged.
This breaks some specs such as the avatar upload spec. As we can't update the assocation
through rails anyway, just delegate to the user for reading instead.
* Restore update method of notification settings
* Restore update spec
* fix spec syntax
* lint scss
* linting
* Fix content_tag for bell icon
* Add feature specs for notification settings
* Disable ContentTag cop
* use visible filter to get projects for notification
The visible filter will reduce the project list down to the set of projects visible to the user provided as a parameter. This includes public projects.
* test for actual mail sending
* adapt me resource path
this.apiV3Service.users.me changed its type in 0d6c0b6bc7
* Implement changed migration
* Linting
* Add actor to notification representer
* Fix factory creating a duplicate WP journal
* Add work packages loading and journal details to notification entry component
* IAN basic facets, keep and expanded states.
* Fix notification bell spec
* Render body separately and add auto updating relative time
* Add fixedTime title
* Add actor to notification entry
* Fix clicking links on work package and project
* Tiny styling changes on entry row
* Disable count in notification if larger than 99 (wont fit)
* Introduce virtual scrolling to entry table
* allow delaying & prevent mail sending if ain read
Introduces a setting to delay mail sending after a journal aggregation time has expired. That way, users can confirm a notification in app. If they do before the delay expires, no mail is sent out additionally for that user.
* consolidate notifications (in&out) into shared admin menu
Co-authored-by: ulferts <jens.ulferts@googlemail.com>
Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>
* spec with correctly scoped links
* move db check into own file - fix deprecation
* basic spec for member creation service
* use constants for all notifications
* send an OP notification after member has been created
* send an OP notification after member has been updated
* mails on group member added
Depending on whether the membership existed before or not, an updated or
a created notification is send. This is done asynchronously.
* move all mail sender background jobs into namespace
* wip
* wip
* correct handling group member notifications
* add setting enable/disable mail sending on member alterations
* use services in members controller
* move Notifiable to OpenProject
* remove member after save hooks
* cleanup/testing/linting
* render member mails in receiver locale
* remove add_member! method
* use mailer layout for all mailers
* Update app/services/groups/cleanup_inherited_roles_service.rb
Co-authored-by: Oliver Günther <mail@oliverguenther.de>
* use around callback to avoid prepending
* handle nil params
Co-authored-by: Oliver Günther <mail@oliverguenther.de>
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.
Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
- each delivery job delivers only a single mail (like in the past)
- a common super-class ensures correct handling of different error conditions (similar to the past)
This new structure should allow for an efficient error handling:
- fail the mail delivery on a per-recipient basis (i.e. redeliveries on error only affect the user that did not receive a mail)
- only fail the delayed job for delivery errors (e.g. network issues, etc)
- do not fail the delayed job for rendering errors (which are likely to re-occur on each rendering)
-> only log those
Ivan Kuchin