* change Edition to edition in strings
* use add-on instead of feature
* replace premium with enterprise
* Change Edition to edition in readme files
* change feature to add-on
Found via `codespell -q 3 -S ./config/locales,./modules/xls_export/config/locales,./modules/job_status/config/locales,./modules/two_factor_authentication/config/locales,./modules/backlogs/config/locales/crowdin -L ba,nd,parms,sur,varius`
* Replace accessible-by-keyboard
* Replace messed up inplace styles with work-package-comment bem block
The styles are not used anymore except for work package comments anyway
* Replace split view icons with buttons
* Make back-button its own bem block
* Replace button in hide-section component
* Replace activity buttons
* Replace notification icon
* Replace collapsible-section
* Replace config-menu
* Make attribute help text trigger a button
* Ensure all buttons are role=button
* Replace inplace save controls
* Replace relations buttons
* Replace relation toggle button
* Replace relation row buttons
* Replace breadcrumb parent
* Replace activities toggler
* Remove accessible-by-keyboard component
* Fix button role to button type
* Fix indent
* Bemmify media query
* Fix specs
* Let GitHub integration show changes in a separate tab
* added new github integration icons to icon font
* add tab content: working tab-header and copy-menu
* modernise github_integrations ruby code
* refactored some code to be more modern ruby (if wrote most of it 7
years ago and couldn't look at some parts without squinting too much)
* make some intended-to-be-private module methods actually private
* fixed all rubocop errors in the /modules/github_integration
* re-organized tests a little
* gave our rubocop.yml some RSpec-related defaults -- happy to discuss
these, but I think we can live with these as a good starting point
👆 all without actually (intentionally) changing the behaviour
* removed dead angular template code
* codeclimate found more things than rubocop :)
* removed create-pr-button since we decided against implementing that feature
* added missing translations
* properly cache the github related part of the wp api
* lower case pull requests in translations
* fix specs
The `APP_INITIALIZER` only runs for global services on startup, but some
modules are now loaded dynamically.
This will result in services that are not `providedIn: 'root'` being
injected for each lazy loaded module that requires them.
* Check edit fields for Work package dependencies
* Make EditForm, NotificationService, EditContext indepenedent of Work Packages
* Make EventsService independent of WorkPackages
* Start renaming WpNotificationService (WiP)
* Fix more references
* Fix typescript errors
* Add basic halEditingService
* Rename to global halResourceEditingService (WiP)
* Move typing from class to methods (WiP)
* Fix typescript errors
* Remove space in type
* Add test project widget && generalize the editFieldGroup
* Rename editing portal service
[ci skip]
* Rename WpEditFieldComponent
* Rename WpDisplayFields
* Rename display-XX-field to XX-display-field
[ci skip]
* Add WP specific ID field to distinguish between resources
* Re-add state in work package resource
* Generalize display field renderer
* Rename spent-time to wp-spent-time and fix highlight specifics
[ci skip]
* Actually load the project schema and make field editable
* Make edit-field-group.component an edit-form.component and subclass EditForm
* Remove edit context in favor of specialized EditForm
* Add special cases for work package editing
* Fix edit actions bar
* Fix codeclimate issues
* Use WorkPackageNotificationService if necessary
* Override NotificationService for WPs to allow WP specififc notifications (WiP)
* Correctly provide wpNotification service
Because the ui-router doesn't seem to correctly use the parent element's
injector, we need to provide the wpNotification service not in the
wp-base, but rather the wp-list component as well as in the isolated
query space.
* Allow to filter halEvents for specific resourceTypes (e.g. WorkPackage)
* Remove superfluous cell class constant
* Start renaming selectors for wp-edit-field into generics
* Remove wp-table--cell-span in favor of display field selector
* Consolidate other display and edit field styles
* Provide specialized service for transitions in active edit forms
* Remove superfluous overflowSelector
* Accept that date field contains some work package specifics
* Ignore unreadable files
* Provide the changeset for work packages as a hook
Since hal resource editing service is provided per query space, we
cannot register them once (would only work globally)
* Fix dangerfile
* Remove another todo in halResourceNotification service
* Fix npm TestBed for changed dependencies
* Show inplace edit field in project details widget
* Fix highlighting in single view
* Provide HalResourceEditingService outside of project context
* Used typedState for single-view
* Also provide wpNotification service in split view
* Correct check for resource type in eventsService
* Fix getSchemaName in display field renderer
* Fix passing ids into `halEditing.stopEditing`
* Do not globally inject the halResourceEditingService
There's a bug(?) in ui-router that gives you the global service before
the parent injected service for a ui-view
* Fix wpCreate service on copying and parallel creation
* Remove test project widget
* Revert changes for project details widget
* remove geckodriver installation from travis setup
* update test documentation to reflect shift to Chrome
* remove duplicate test documentation
[ci skip]
This removes `gulp` and provides a simpler `karma` and `webpack`,
`webpack-watch` npm scripts.
For actual development, users will need the Rails stack anyway, so it
won't make sense to keep a separate set of dependencies up to date.
* Instead of `gulp webpack`, use `npm run webpack`.
* Instead of `gulp watch`, use `npm run webpack-watch`, which is *drastically* faster than gulp watch-polling.
* Instead of `gulp tests:karma` use `npm run karma`, or just `npm test`.
This also removes all traces of express and restores the Rails
styleguide. It is not whitelisted for precompilation and is only
available in the context of the development mode.
To access the styleguide, use `/assets/styleguide.html`.
In agreement with @furinvader, we have decided to remove protractor
testing from OpenProject.
Frontend tests are implemented in karma and test single units of work as
before.
Since the freshness of APIv3 JSON mocks are getting ouf hand and we have
covered almost all E2E protractor tests with Rails, we're going to
resort to Rails to write concise *actual* integration test with correct data.
as-op