* Fix GitHub/NoTitleAttribute, LinkHasHref errors
- Replaces `title` attribute with `aria-label` for interactive elements.
- Removes `title` from non-interactive elements.
- Converts `<a>` tags without proper `href` to `<button>` elements,
using Primer `Button`/`IconButton` where possible.
# Conflicts:
# app/views/custom_fields/_custom_options.html.erb
# spec/features/admin/custom_fields/shared_custom_field_expectations.rb
# spec/features/admin/custom_fields/work_packages/list_spec.rb
* Fix Autocomplete missing errors
* Fix GitHub/NoPositiveTabIndex errors
Removes all positive `tabindex` values.
* Fix Rails/LinkToBlank errors
* Replace toast with Primer Banner on LDAP form
* Add frozen_string_literal
* Ignore erb lint for deprecated files
* Fix linting errors in repository module
* Fix linting errors in budgets and custom actions
* Fix linting errors in member form and 2fa
* Fix linting errors in mcost types and wiki help and storages
* Fix linting errors in multi select filters, ifc viewer, and unsupported browser banner
* Fix failing spec
* Use Primer banner instead of op-toast where ever it is possible
* Use octicon instead of op_icon
* Fix failing tests
* Use no-decoration-on-hover for button links and change the button with only an icon to primer icon button
* Keep webhook response modal activation selector class-based
* use icon button for edit of hourly rate
---------
Co-authored-by: Behrokh Satarnejad <b.satarnejad@openproject.com>
- Use accessible selectors `within_modal` / `find_modal` in
share_spec.rb and define the modal as an accessible one: role=dialog,
aria-modal=true, aria-labelledby=spotModalTitle
- Set spotModalTitle id on all modals.
- Introduce new custom accessible capybara selectors for list and
list_item with custom description.
* wp deletion modal changes
* fix test fails
* invite user modal changes
* fix eslint issus and add cancel button to summary modal
* add widget modal changes
* new board modal changes
* form configuration modal changes and remove unnecessary class
* WP table export modal changes
* WP save query modal changes
* visibility setting modal changes
* help text modal changes
* help video modal changes
* 2FA password confimation modal changes
* Delete EE token modal changes
* fix eslint errors
* eslint does not check the unbound method
* minor changes to switch the buttons and icon
* fix specs failing for invite user modal changes
* use the correct translations and revert the previous merge
* Fix opAutofocus directive
The opAutofocus directive was not setting focus if used like a normal
`autofocus` HTML attribute:
```
<input opAutofocus />
```
The above example would not produce a focus, because counterintuitively
Angular treats the default input to the directive here as an empty
string instead of undefined. This causes the default value of `true` NOT
to be set. Instead, the empty string was treated like the falsy value
it is.
* add focus on invite user modal while opening
* fix eslint errors
* eslint errors fix
* add icon delete for deleting ee token
* wp delete modal changes: remove unnecessary loading and change op-icon to a span
* remove unused components
* use spot-list for add-widget modal
* wp table configuration modal changes
* fix finding list item in add widget modal specs
* Chore/modal spacing (#11314)
* [chore] reworked spot-container spacings
* [chore] applied spot-container to spot-modal--body
- added style override for spacing within modal body
* [chore] removed unused modal footer class
* Remove scrollbar from project-include
Project include was creating scrollbars for the project list even if
it was not needed. This was caused by tooltips that were hidden in the
background but still affecting layouting.
This commit hides the tooltips correctly, and aligns the HTML structure
of project include to match that of file link list. A minimum height is
added to the project include list to make sure tooltips are readable even
if there is only one item in the list.
* [chore] rework of datepicker modal
- changed spacings, removed inner margins
- changed anchors to buttons (spot-link)
- added flatpickr override
- removed min-height
- moved project include min-height to root element
* [chore] fixed test selector
Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>
* redesign the save query modal changes
* remove op-form class from invite user modal since we have spot-container now
* add text and title for ee modal deletion
* showing the error message when it is not valid value in invite user modal
* close the inroduction video modal with button
* close the dynamic content modal without jquery
* fx eslint warnnings
* webhook response modal
* remove multiple cancel translation in invite user modal
* fix indentation in html file
Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>
Co-authored-by: Eric Schubert <38206611+Kharonus@users.noreply.github.com>
* [#43684] migrated op-modal to spot-modal
- https://community.openproject.org/work_packages/43684
- amended styles
- removed "modal--title"
- removed header component
- removed closing icon
- fixed backdrop click
- removed jquery from modal service
* [#43684] removed unused styling
- fixed some inconsitencies
- readded removed icon
- removed listener on close button
* [#43684] combined spot-action-bar
- used spot-action-bar in combination with spot-modal--footer
- fixed some styling in action bar
* [#43684] replaced more op-modal
- moved spec selectors to spot-modal
- replaced found op-modal in html templates
* [#43684] add no margin to old buttons in new dialogs
- added mobile modal behavior
- fixed some feature spec selectors
* [#43684] added modal close on mobile resolutions
* [#43684] fixed PR issues
- removed old css classes from html
- fixed feature spec click
- readded tour trigger on modal cancel
* when clicking outside the modal it will be closed instaed of clicking on a close button
* exclude _center class from spot-modal sass file itself and add it to the component style sheet
* Words should be break in any case like when there is no space there
* remove unnecessary classes that never used like _fullscreen and _cente, remove _limited-height class to make all the modal look the same
Co-authored-by: bsatarnejad <b.satarnejad@gmail.com>
Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>
* [37262] Fix modal header icons
https://community.openproject.org/work_packages/37262
* Add autoheight to onboarding modal
* Render avatar of the user
* Fix different padding for header and align all center
This allows to render different things, not just icons (avatar) while
centering all correctly
* [35527] Add quick add button menu in top menu
* Add quick menu item to top menu
* Refactor top_menu.sass to follow BEM
* Only render project-based path if persisted
* Render project types when in project context
* Add headline and determine if any types are visible
* Hide quick add menu for unauthorized users
* Fix login menu dropdown by adding class
* Add schematic for correctly generating components
* Add augment service for triggering invite user modal
* Fix allowed_to? check in menu
* Add spec
* Highlight types and show all
* Fix help menu overridden
* Extend spec
* Add parent_id to project in dropdown and expand advanced settings
* Reload the page if the modal returned any data
* Fix invalid url allowed check if there is no URL to check
* Basic BEM changes
* Remove old classes
* Update more classes
* Update togling logic
* Fixed menu opening and some styles
* Added op-menu
* Fix some help menu styles
* Add op-menu to help menug
* Add avatar border
* Fix auth_provider_spec
* Fix zen mode
* Fix static link help menu
* Fixed top menu specs
* Fix self registration specs
* Fix logout spec
* Fix bim revit navigation spec
* Fixed menu permissions spec
* Fix homescreen onboarding tour spec
* Fix top menu item spec
* Remove unused file
* Fix a lot of mobile styles
* Fix more mobile styles
* Fixed build
* Move quick add menu to right hand side
* Improve quick-add-button styles, fix main-menu-toggle close icon
* Remove add new project spec
* Fix spec
* Update project dropdown styles
* Fix click handler for chrome mobile, update some styles
Co-authored-by: Oliver Günther <mail@oliverguenther.de>
* Add new button added to select-edit-field
* Permissions Service + show button if canInviteUsersToProject
* Permissions Service + show button if canInviteUsersToProject
* Add initial invite user modal
* Small change to invite user modal
* Small use rmodal changes
* Builds
* Added invite user modal title translation
* Changed modal to module
* Figured out basic modal setup
* Fixed build
* Started adding option-list component
* Adding reactive forms
* vim
* Reactive forms working for option-list
* op-form-field is implemented, project-selection step works
* Working on principal step
* Basics of principal selection are done
* Remove console logs
* Added role step and role api bindings, updated directory structure
* Added basics of message step
* Added summary page
* Add in-project check for selected principal
* Add documentation for principal filters
* Create modal-heading component
* Fix principal emit
* Add API calls to summary component
* Work on translations, rework close fn
* Added translations
* Fixed styling
* Add autofocus, fix typing
* Improve typing
* Add form-binding directive to fix form-field
* Fixed typescript errors
* Fix more translations
* Codeclimate and TSLint errors
* Failing test commented with TODO
* Codeclimate fixes
* Codeclimate fixes
* Open invite user modal from user selection
* Remove console and debugger calls
* Opening modal from CreateAutocompleterComponent
* Add new button added to select-edit-field
* Permissions Service + show button if canInviteUsersToProject
* Permissions Service + show button if canInviteUsersToProject
* Codeclimate and TSLint errors
* Failing test commented with TODO
* Codeclimate fixes
* Codeclimate fixes
* Add initial invite user modal
* Small change to invite user modal
* Small use rmodal changes
* Builds
* Added invite user modal title translation
* Changed modal to module
* Figured out basic modal setup
* Fixed build
* Started adding option-list component
* Adding reactive forms
* vim
* Reactive forms working for option-list
* op-form-field is implemented, project-selection step works
* Working on principal step
* Basics of principal selection are done
* Remove console logs
* Added role step and role api bindings, updated directory structure
* Added basics of message step
* Added summary page
* Add in-project check for selected principal
* Add documentation for principal filters
* Create modal-heading component
* Fix principal emit
* Add API calls to summary component
* Work on translations, rework close fn
* Added translations
* Fixed styling
* Add autofocus, fix typing
* Improve typing
* Add form-binding directive to fix form-field
* Fixed typescript errors
* Fix more translations
* Refactor/op modal (#8978)
* Initial modal refactoring
* Updated modal imports
* More modal module imports
* Fix one more import
* Fixed some styles
* Fixed failing modal specs
* Fix more spec selectors
* Fix more specs
* Updated backend modals
* Improved code style
* Fix export modal styles
* Fix wiki export modal
* Fix more specs
* Fix webhooks modal
* Added loading indicator back into modals
* Fixed wp preview modal
* InviteUserButtonComponent in
* InviteUserButtonComponent in
* InviteUserButtonComponent in MultiSelectEditFieldComponent and SelectEditFieldComponent
* Remove extraneous module
* Add Dragula import
* Remove empty spec
* Fix option-list component
* Remove group creation from invite user modal
* Write feature spec
* Fix TS errors
* Add Placeholder and Group apis to the frontend
* Better api typing
* Remove unnecessary interface
* Remove group creation call
Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>
Co-authored-by: Oliver Günther <mail@oliverguenther.de>
Co-authored-by: Benjamin Bädorf <hello@benjaminbaedorf.eu>
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.
Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
This allows us to use a single service implementation to augment
multiple modal-wrappers instead of bootstrapping the legacy frontend
there on every page load.
The help menu is costly to render mostly because of the onboarding menu which itself has a partial included.
When dropping the user name from that partial, we can however cache the menu which decreases the time required for rendering significantly.
We cannot properly pass 'overlayClose' to the ModalFactory since it's
transformed into 'overlayclose' instead through the `attr` API.
Instead, re-implement the whole factory so we actually have control over
what happens when.
* enable foundation.js
* built foundation-apps.js using webpack
* Add onboarding modal on button click
* Fix specs and little bugs
* Add show behavior for modal
* Pass template data from Rails to zf-modal
* Add closing cross and fix style bugs
* Re-add onboarding menu
* Change ID to class
* Fix styling and avatar problems
* Fix broken specs caused by foundation && improve implementation
* Require openproject-global.css and fix tests
Alexander Brandon Coles