This is making the interface of BaseCallable more consistent.
Previously it was unclear, whether the params passed to perform
should be used to reference parameters or whether the attribute accessor
should be used. Different code used different approaches.
To apply this change more consistently, BaseContracted also removed
params from the methods called inside its own perform method, e.g.
before_perform or after_validate.
At a later point we might consider removing this argument from other large
inheritors as well, for example `BaseServices::SetAttributes#set_attributes`.
The job has been updated to excluded work packages having a status with
`excluded_from_totals` set to true. The journal entry has valid values
so that the cause renders correctly.
The job is not yet triggered properly when the "excluded from totals"
attribute of a status is changed in the administration.
https://community.openproject.org/wp/54646
A concurrency key has been set on all jobs updating progress values to
ensure that only one job is performed at a time.
All classes related to managing progress updates in jobs has been moved
to a specific folder.
Extends the base Settings::UpdateService in order to force the default
language on users whose current language setting wasn't available (or not
available anymore after the service's run).
Some spec factoring fit quite nicely here to extract the shared setup code
into a shared context.
* create a new component for showing list of NWD
* fix the method for fetching data from the database
* fix eslint errors
* add delete icon to the list of non-working days
* Change componenet name and add empty state handleing and add button for opening the date picker modal
* fix full calendar/list css import issue in anguar 14
* change confirm modal to show a list of data and a warning
* open confirmation modal in list of non-working days component while submitting the form
* format removed dates to be shown on the confirmation modal
* change a warning string
* make a connection between rails and calendar list component
* reinstall list in fullcalendar
* fetch data from non-working days API endpoint
* set suto to content height of calendar
* use id returned from the API
* Fix parameter name on WorkingDaysSettingsController
* Fix non working days attributes _deleted to _destroy
* Pass ruby variable to the op-non-working-days-list component
* fixup! Pass ruby variable to the op-non-working-days-list component
* Pass this.modifiedNonWorkingDays to the angular component
* add inputs to the form itself instead of row of calendar, while adding a new NWD
* Update the modified_non_working_days variable to also propagate the _destroy field to the frontend
* create hidden inputs only for added and deleted NWDs
* Fix specs
* Limit json attributes
* add non-working days as test
* add hidden inputs for a new nwd in ngoninit and add it to the calendar itself at the same time, when it is back from a failed proces
* add a method to check if a date is a NWD
* Add requests spec for deleting non working days
* Allow dangling underscore for _destroy
* fixup! Allow dangling underscore for _destroy
* WIP single date picker
* Use slots from single datepicker to wire up modal
* Add spec to add a NWD
* remove Non-working days only toggle
* WIP
* Add required validation
* show asterisks beside date in date-picker
* test if date ans name are entered then close the datepicke
* Add error when already added
* Rewrite into less implicit created elements
---------
Co-authored-by: Dombi Attila <83396+dombesz@users.noreply.github.com>
Co-authored-by: Oliver Günther <mail@oliverguenther.de>
* Validate admin guard for all settings writers
* Add spec to test access to all links under admin
* Fix broken specs
* Keep only UpdateContract and add spec
* Move admin settings under their own namespace for clarity
Move all admin related settings under ::Admin::SettingsController
* Fix more paths and views for settings
Adds another spec to ensure all links in admin can be viewed by admin
* Fix wrongly changed settings path for repositories page
* Use plugin name for plugin settings
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.
Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
Tomas Hykel