236 Commits

Author SHA1 Message Date
Tomas Hykel 8e70767c5f fix: Correctly handle wp_sequence_counter on project copy 2026-05-07 22:12:27 +02:00
Tomas Hykel c4debc8aaa [#73523] Implement WorkPackage semantic ID allocation system 2026-04-01 17:25:19 +02:00
Oliver Günther 91fa44a109 Reupload artifact when stepping through wizard again
Refactoring the Create service to make it more readable, by introducing
a separate service for this.

https://community.openproject.org/work_packages/72550
2026-03-17 11:38:52 +01:00
OpenProject Actions CI 53ad486160 Merge branch 'release/17.1' into release/17.2 2026-03-03 13:38:43 +00:00
ulferts e47e387196 merge ProjectHelper into ProjectsHelper 2026-02-27 15:58:04 +01:00
Eric Schubert 9bab9e5da7 [#69991] applied review suggestion
- mostly regarding readability and consistency
2026-02-19 11:06:53 +01:00
Eric Schubert 6dbb337373 [#69991] rework work package attachments setting
- https://community.openproject.org/work_packages/69991
- apply global setting to existing projects via migration
- use global setting as default value when creating new projects
2026-02-18 15:03:59 +01:00
Klaus Zanders 538b3cd29b Merge branch 'dev' into more-visible-scopes 2026-02-12 11:19:23 +01:00
Dombi Attila c8665b74d4 Make the assignee and comment fields optional in the project creation wizard. 2026-02-10 14:08:18 +02:00
Klaus Zanders 150e4bb7c5 Properly handle non visible user 2026-02-09 15:27:25 +01:00
Klaus Zanders c212df5b81 Use more visible scoping for users 2026-02-09 15:07:45 +01:00
Oliver Günther 57b69c26f5 Allow groups to be assigned to PIRs 2026-02-09 14:37:23 +01:00
Oliver Günther 738e081aa5 Remove feature flag 2026-01-29 09:07:53 +01:00
Dombi Attila 2e624b1326 [#70982] 'For all projects' project attributes are not displayed during new project creation
https://community.openproject.org/work_packages/70982
2026-01-26 14:16:26 +02:00
Dombi Attila 54bb7a6468 Move the project custom field validation changes to the service level instead of the model level. 2026-01-11 00:04:42 +02:00
Tobias Dillmann d8bbc35ca6 [#70106] Convert symbol keys to string before casting, refactor 2026-01-07 15:01:07 +01:00
Tobias Dillmann 587333e79a [#70106] Activate a default field if the value is explicitly set
... even if it is identical to the default value
2026-01-07 15:01:07 +01:00
Tobias Dillmann 6651cb5f03 [#70106] Do not activate cfs in the first place if default
Without this commit, unwanted fields would still show up in the creation
form, as the NewProjectService will always create the mappings. But it
will only remove unwanted mappings after successfully persisting the
project. This does not happen if there are errors (e.g. a required field
has no value). Since the field should never have been activated in the
first place, it is expected to have no value. Still, this validation
errors prohibits saving - and thus the errornous field is never cleaned
up.
2026-01-07 15:01:07 +01:00
Tobias Dillmann edd06fb115 [#70106] Do not force-activate custom fields with a default value 2026-01-07 15:01:07 +01:00
Christophe Bliard 8dd148e640 [70290] Project copy nilifies user fields if members are excluded
https://community.openproject.org/wp/70290

This fixes the regression introduced in 5ea185ef66: the
`possible_principal_id` was run against the source project instead of
the target project, leading to always return something.

Fix is to always run `possible_principal_id` against the target project.

This was not detected by the unit tests: original tests were taking the
first work package of the copied project to check that the user field
was nil, assuming the first work package would be the copy of the one
having the user field set, but actually the work package was not copied,
so another work package is picked and this one has all user fields nil
because the original work package has all user fields nil.

The test was fixed by explicitly getting the copied work package using
the subject of the original work package, and failing if the copied work
package is not found.
2026-01-06 16:19:57 +01:00
Christophe Bliard ec76b26d7a Fix noisy deprecation warning 2026-01-06 16:13:22 +01:00
Oliver Günther be6297ecdf Take over creation_wizard flag in project mappings 2025-12-23 14:52:52 +01:00
Tobias Dillmann 2d3ea3adfe [#69399] new project service considers both flags 2025-12-12 09:59:50 +01:00
Oliver Günther 1289d761d6 Allow excluding roles on template copy 2025-12-10 08:30:15 +01:00
Oliver Günther 6221e90a6b Use the same call for storage upload service 2025-12-09 08:58:59 +01:00
Oliver Günther 3aa5275567 Merge pull request #21214 from opf/feat/workflow-work-package
Recreate artifact on status change
2025-12-08 14:08:55 +01:00
Oliver Günther 5d9272818a Ensure we take over the project role in members dependent service 2025-12-04 18:42:17 +01:00
Oliver Günther 28fae53f35 Ensure a project role is created before copy of dependencies 2025-12-04 18:42:17 +01:00
Oliver Günther 4a3d90e9ba Use the default language for generating the file name of the artifact (#21301)
* Use the default language for generating the file name of the artifact

* Update spec/services/projects/create_artifact_work_package_service_spec.rb

Co-authored-by: Mir Bhatia <m.bhatia@openproject.com>

---------

Co-authored-by: Mir Bhatia <m.bhatia@openproject.com>
2025-12-02 16:20:11 +01:00
Dombi Attila 2ca5a2e712 [#69495] The Project Initiation Request fails when the artifact work package has a required custom field
https://community.openproject.org/work_packages/69495
2025-11-28 12:56:45 +02:00
Oliver Günther cc3a03050c Use more fitting title when copying from template
Use "Applying template" rather than "Copy project"
2025-11-26 21:49:09 +01:00
Oliver Günther 6fc97cf04f Add PIR submission email 2025-11-26 16:40:00 +01:00
Oliver Günther 3b1aface65 Improve PIR description template 2025-11-26 16:27:22 +01:00
Christophe Bliard 3d2a567231 Skip creating another artifact work package if one already exists
https://community.openproject.org/wp/68862
2025-11-26 16:17:54 +01:00
Oliver Günther af7ebac0ce Revert "Fix retrieval of project storage"
This reverts commit d59269e026.
2025-11-26 15:20:35 +01:00
Christophe Bliard d59269e026 Fix retrieval of project storage 2025-11-26 15:03:46 +01:00
Christophe Bliard d50829aa6d Merge pull request #21203 from opf/hotfix-project-init
Associate artifact file link to artifact work package, not project
2025-11-26 14:48:51 +01:00
Jan Sandbrink b876177671 Associate file link to WP, not project
The file link was errorneously added to the project instead
of the work package.
2025-11-26 14:37:03 +01:00
Mir Bhatia fe1feeca11 Add link to wizard to WP description and comment 2025-11-26 13:28:21 +01:00
Oliver Günther 977c65ab3b Don#t copy project wizard artifact ID 2025-11-26 12:13:10 +01:00
Oliver Günther 7681aaf64c Merge without success 2025-11-25 16:25:25 +01:00
Oliver Günther ba994897af Upload artifact in storage 2025-11-25 16:10:29 +01:00
Christophe Bliard 0ff8b1ef16 Merge pull request #21139 from opf/feature/68862-create-work-package-to-submit-project-initiation-request
[68862] Create work package to submit project initiation request
2025-11-25 15:53:06 +01:00
Oliver Günther 26d37ff51d Use journal_notes directly 2025-11-25 15:18:38 +01:00
Christophe Bliard 9aae868dc2 Use default description for artifact work package
This way, if it has a template content, it will be used.
2025-11-25 15:04:26 +01:00
Christophe Bliard 59613e98de Comment and mention the assignee in the artifact work package 2025-11-25 15:02:53 +01:00
Oliver Günther f3aae808b6 Skip creation on template selection
Otherwise, new_project is not saved
2025-11-25 13:29:58 +01:00
Christophe Bliard 91cdf81dd8 Fix tests related to artifact work package creation
A project settings attribute name was renamed from `name_artefact_name`
to `project_creation_wizard_artifact_name`.
2025-11-25 11:55:19 +01:00
Christophe Bliard 4260e83f4d Set artifact work package subject to the name configured in settings 2025-11-25 10:46:41 +01:00
Mir Bhatia fd3d6acea5 Update new_project_service to send out mails 2025-11-24 18:13:08 +01:00