This error is intended for cases when a method is
intentionally not implemented, because the module/class defining
it expects a subclass (or class including the module) to implement
the method.
This is intended to distinguish it from other cases, such as:
* feature not implemented yet
* edge case of a method call not yet supported
Notably it avoids the misuse of the Ruby-defined NotImplementedError,
which is only intended for much more specific scenarios:
> Raised when a feature is not implemented on the current platform. For example, methods depending on the fsync or fork system calls may raise this exception [...]
Also see https://docs.ruby-lang.org/en/master/NotImplementedError.html
:change_work_package_status permission is additive, but not disjunct
with :edit_work_packages - this means:
- no DB migration is needed, :edit_work_packages will work as before
- :change_work_package_status added to some tests was removed again
Permission `change_work_package_status` is similar to `assign_versions`
permission as it:
- Allows edit for status field, without the need for edit WP.
- Now `edit_work_packages` alone does not allow status edit; this is
how `assign_versions` works too, migration adding the new permission
to existing roles with edit WP is provided.
Some tests were fixed, but more fixes and some new tests will be added.
The MenuItems::QueryMenuItems class used to map the `starred` state is replaced by a simple boolean flag. The hidden flag is removed (but still readable) as the concept of `View`s completely replaces it.
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.
Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
When an existing query (and its form) is loaded, members with
permissions to create new queries, but NOT to update existing ones can
not save existing queries as new ones.
This is due to the `create`, `update` and `commit` (on form) links are
dependent on the query resource itself, not on general permissions of
the queries project.
https://community.openproject.com/wp/27600
[ci skip]
`redirect_back_or_default` was vulnerable to some of the URLs found to
be vulnerable in redmine, such as `@test.foo`.
This commit extracts the whole functionality into a policy and alters
the constraints with a path check to avoid these cases.
Thanks to @marutosi for pointing this out.
http://www.redmine.org/projects/redmine/repository/revisions/14560
Jan Sandbrink