55 Commits

Author SHA1 Message Date
David F 5ebe35afb3 Deduplicate workflows’ eligible roles. wp/72383 2026-03-24 15:40:07 +01:00
Alexander Brandon Coles d17da65477 Freeze string literals in app/models
rubocop -A --only Style/FrozenStringLiteralComment,Layout/EmptyLineAfterMagicComment,Style/RedundantFreeze app/models
2025-07-22 18:26:13 +01:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Klaus Zanders 0c7fd939c8 Fixes Performance/MapCompact offenses 2023-09-06 11:06:36 +02:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
Christophe Bliard a33524ef6d remove ruby magic comment for utf-8
ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless
2022-03-10 19:36:58 +01:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
ulferts 6140f4c7e9 update copyright to 2021 (#8925)
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.

Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
Oliver Günther 53f2d694ff Use AnyFixtures to generate fixtures from factories (#7230)
Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec.
They automatically are created whenever first hitting them.
This makes an excellent time saver for items that are commonly used, such as an admin user account
2020-04-09 11:54:26 +02:00
Henriette Dinger bd7f4e4814 Update copyright notice 2020-01-15 11:31:26 +01:00
Oliver Günther f86abae9eb Enforce Arel.sql for string order, pluck 2018-12-03 10:31:57 +01:00
Oliver Günther 6ef4211e77 Bump copyright to 2018 (#6171)
[ci skip]
2018-02-12 08:51:12 +01:00
Jens Ulferts 690e0ffc60 wp create/update/destroy via services 2017-11-29 15:27:29 +01:00
Jens Ulferts 1d66745a5d fix additional workflows for assignee and roles 2017-07-20 20:49:07 +02:00
Jens Ulferts 30bf9a5199 code prettification 2017-07-20 20:49:07 +02:00
Oliver Günther 7cf11bb689 Update copyright notice 2017-01-10 15:11:43 +01:00
Jens Ulferts 6f6598bd84 delete_all and reload rails 5 way 2016-09-08 08:51:28 +02:00
Mohamed Wael Khobalatte 972b04d86e Refactor to allow for strong params
We no longer need attr_accessible.
2015-10-23 14:33:55 +02:00
Alex Coles 064d66449a Migrate AR finder/query methods in models
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-06-30 12:12:51 +02:00
Alex Coles e5da2578d5 Merge branch 'dev' into feature/rails4
Signed-off-by: Alex Coles <alex@alexbcoles.com>

Conflicts:
	.travis.yml
	Gemfile
	Gemfile.lock
	README.md
	app/assets/stylesheets/external.css.sass.erb
	app/assets/stylesheets/legacy/main.css.sass
	app/models/work_package.rb
	config/routes.rb
	lib/tabular_form_builder.rb
	spec/controllers/versions_controller_spec.rb
	spec/exemplars/type_exemplar.rb
	spec/factories/type_factory.rb
	spec/legacy/unit/default_data_spec.rb
	spec/legacy/unit/helpers/application_helper_spec.rb
	spec/legacy/unit/mail_handler_spec.rb
	spec/legacy/unit/project_spec.rb
	spec/legacy/unit/time_entry_activity_spec.rb
	spec/legacy/unit/type_spec.rb
	spec/models/work_package/work_package_validations_spec.rb
	spec/requests/api/v3/render_resource_spec.rb
	test/functional/types_controller_test.rb
	test/test_helper.rb
	test/unit/version_test.rb
2015-05-01 11:39:24 +02:00
Alex Coles e0191e759c Update year in copyright header to 2015
[ci skip]
2015-01-01 00:02:57 +00:00
Alex Coles f75392f8be Fully qualify ::Type class constant
See 0b941955.

Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-11-05 00:32:23 +01:00
Alex Coles f35e741387 Merge branch 'dev' into feature/rails4
Signed-off-by: Alex Coles <alex@alexbcoles.com>

Conflicts:
	app/controllers/api/v2/authentication_controller.rb
	app/controllers/api/v2/planning_element_journals_controller.rb
	app/controllers/api/v2/planning_element_type_colors_controller.rb
	app/controllers/api/v2/project_associations_controller.rb
	app/controllers/api/v2/project_types_controller.rb
	app/controllers/api/v2/projects_controller.rb
	app/controllers/api/v2/reported_project_statuses_controller.rb
	app/controllers/api/v2/reportings_controller.rb
	app/controllers/api/v2/timelines_controller.rb
	app/controllers/api/v2/users_controller.rb
	app/controllers/copy_projects_controller.rb
	app/controllers/custom_fields_controller.rb
	app/controllers/projects_controller.rb
	app/controllers/time_entries/reports_controller.rb
	app/controllers/types_controller.rb
	app/controllers/versions_controller.rb
	app/controllers/workflows_controller.rb
	app/helpers/types_helper.rb
	app/models/project.rb
	app/models/query.rb
	app/models/timeline.rb
	app/models/type.rb
	app/models/work_package.rb
	app/models/workflow.rb
	app/services/planning_comparison_service.rb
	config/initializers/10-patches.rb
	config/routes.rb
	db/seeds/production.rb
	features/step_definitions/general_steps.rb
	features/step_definitions/issue_steps.rb
	features/step_definitions/timelines_given_steps.rb
	features/step_definitions/type_steps.rb
	features/step_definitions/work_package_steps.rb
	lib/redmine/default_data/loader.rb
	lib/tasks/ci.rake
	lib/tasks/documentation.rake
	spec/controllers/api/v2/planning_elements_controller_spec.rb
	spec/factories/type_factory.rb
	spec/views/api/v2/custom_fields/index_api_rabl_spec.rb
	spec/views/api/v2/planning_elements/show_api_json_spec.rb
	spec/views/api/v2/projects/show_api_json_spec.rb
2014-11-04 20:50:24 +01:00
Alex Coles 1d1ec0ef37 Prefer #map over #collect in (Rails) models
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-11-04 11:24:51 +01:00
Alex Coles 6fe9535b1f Fix syntax (w/Rubocop) in (Rails) models
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-11-03 22:15:11 +01:00
Alex Coles 721101ed25 Use 1.9+ Hash syntax in (Rails) models
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-11-03 22:15:11 +01:00
Alex Coles 0604de3d8b Fully qualify ::Type class constant
See 0b941955.

Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-10-30 11:26:31 +01:00
Alex Coles 0b941955ce Fully qualify ::Type class constant
This fixes a naming collision with AR internals:

    undefined method `find' for ActiveRecord::AttributeMethods::Serialization::Type:Class

Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-09-13 19:07:45 +02:00
sschu df0a9aab74 Merge pull request #944 from opf/fix/workflow_copy_4285
[FIX] Workflow copy 4285
2014-02-27 17:06:49 +01:00
Johannes Wollert 8b096975fe updates copyright headers
updates more copyright

more copyright headers
2014-02-27 16:39:51 +01:00
Hagen Schink 3737a2960f Fixes missing author/assignee state on copy 2014-02-21 08:15:51 +01:00
Hagen Schink 2f5e9ad3d6 Renames IssueStatus to Status 2013-10-01 17:14:01 +02:00
Philipp Tessenow a1e67dd460 new copyright header #1903 2013-09-16 17:59:31 +02:00
Martin Czuchra 847a3029a9 Renames Tracker into Type. 2013-07-18 16:18:14 +02:00
Jens Ulferts 21459a384f provide every possible file with a short copyright notice
This was done using the rake task: rake copyright:update
2013-06-07 10:49:57 +02:00
Martin Linkhorst a3675092c8 fix role tests 2013-01-14 16:51:31 +01:00
Martin Linkhorst cc74c1e998 added attr_protected calls to protect mass assignment of :project_id through a view 2012-03-28 15:32:02 +02:00
Holger Just 91070236db Set source encoding to UTF-8 2011-10-29 14:48:03 +02:00
Holger Just 07185fb169 [#436] Remove trailing whitespace 2011-05-30 20:52:25 +02:00
Eric Davis 99507a0391 [#197] Upgrade the copyright in the code files 2011-05-29 13:11:52 -07:00
Eric Davis e131c3b531 [#197] Remove old copyrights 2011-05-29 12:50:08 -07:00
Jean-Philippe Lang da7c89bfd0 Fixes workflow edit with JRuby (#5404).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3709 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-04-30 12:19:51 +00:00
Jean-Philippe Lang 03b57415d6 Avoid a ruby warning.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3192 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-19 12:16:45 +00:00
Jean-Philippe Lang 5c6ce51ec9 Adds workflow copy functionality (#1727).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3154 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-12 10:06:07 +00:00