This error is intended for cases when a method is
intentionally not implemented, because the module/class defining
it expects a subclass (or class including the module) to implement
the method.
This is intended to distinguish it from other cases, such as:
* feature not implemented yet
* edge case of a method call not yet supported
Notably it avoids the misuse of the Ruby-defined NotImplementedError,
which is only intended for much more specific scenarios:
> Raised when a feature is not implemented on the current platform. For example, methods depending on the fsync or fork system calls may raise this exception [...]
Also see https://docs.ruby-lang.org/en/master/NotImplementedError.html
Favorite is the correct term in the context of expressing a preference
for a particular project / other OpenProject domain object.
Updates `ActsAsFavorable` to `ActsAsFavoritable`, as well as filenames,
identifiers and strings to:
favored => favorited
favorable => favoritable
favoring => favoriting
* Prepare basic recurring meeting setup
* Add proof of concept to create schedules
* Add feature flag
* Rework menu
* Pass request to meetings menu
This doesn't help, as the requested url is the turbo frame
* Add filter menu for recurring meetings
* Start primerized create form
* Add recurring meetings to dropdown and dialog
* Add schedule
* Add frequency/iterations form
* Add services
* Recurring meetings menu entry
* Fix setting project
* Template
* add bi-weekly
* Add template sideinfo
* Skip mails when adding participants
* exclude templated meetings
* Add header for templates
* Prevent deletion of meeting template
* Fix breadcrumb
* WIP Add show table and initialization
* Change icon for calendar
* remove unused template
* add template has_one
* meeting form
* Fix creation of recurring
* working edit
* specify end time
* Add header actions
* Add initial recurring meeting frequency label
* Add index page
* Add soft delete and restore for occurrences
* Refine implementation of scheduled meetings using skeletons
* Add template link
* Paginate
* Move init of meeting to recurring
* Add schedule in words
* Add show series action item
* Implement changed show page of occurrence
* Add interval, fewer frequencies
* Add interval to schedule
* Try to add non working days
* Update meetings index to display recurring occurrences correctly
* Update schedule in words
* Fix exception rule
* Fix occurrence for working days
* Hide interval when selecting working_days
* Document show-when-value-selected
* Set interval to 1 when changing to working_days
* Fix dialog
* Adapt to mobile table
* Update type filter
* Rename TypeFilter -> RecurringFilter
* Start date group
* Combined Filter component
* Updated menu
* Update label created by me
* Add validation on end_date > start_date
* Implement sorting through query
* Render all meeting series in the sidebar
* Select my meetings only when href passed
* WIP Add initial specs
* Fix date validation
* Use the correct date formatter in the subtitle
* Add spec for date validation
* Change label to View template
* Add edit series button
* Fix deletion of recurring meetings
* Correctly hide form for end_after options
* Update copy behaviour to never allow recurring copies
* Fix location value in form
* Fix meeting details form
* Add scheduled meetings table
* Replace destroy/restore with actual destroy
* Uniqueness
* Delete with schedule
* Switch to start_time
* Use start_time in schedule
Otherwise, we get time mismatches
* Add helper for time formatting to the current user
* fixup! Delete with schedule
* Move update_start_time to concern
* Delete cancelled meetings when changing schedule
* Allow passing dates directly
* Remove cancelled occurrences when changing schedules
* Limit count_rule until end_date
* Show changed start times for occurrences
* Indent case
* Fix destroy path to include project
* Fix past meetings
* Schedule first occurrence on creation
* Linting
* fixup! Linting
* Autoschedule job
* Add more schedule tests
* Fix project-based destroy
* Redirect to template, not show
* Don't cache user time zone in request store
* Fix forgotten invited where
* fixup! Linting
* Remove default meeting order
* Fix meetings index spec with new ordering
* Fix path
* Convert meeting tab to cuprite
* Fix expectation for meeting tab
* More robust selector on meeting tab
* Change global menu spec
* Add more CRUD specs
* Fix dates and times
* Allow cancellation of scheduled meetings
* Lint
* Reschedule init job when updating schedule
* Fix end date in the form
* Test cancellation
* Extract create spec
* Fix specs
* Add spec when lacking permissions
* Fix cancellation of scheduled meetings
* Render meetings with correct project link
* Remove unused disable
* Remove useless cop disable
* Add contract specs
* Add delete contract spec
* Revert "Add delete contract spec"
This reverts commit 27a517d773.
* Add delete contract spec for meetings itself
* Fix spec
* Hide past cancelled occurrences
* Show different delete labels and messages
* Move to request spec
---------
Co-authored-by: Mir Bhatia <m.bhatia@openproject.com>
Jan Sandbrink