88 Commits

Author SHA1 Message Date
ulferts 5968c0b18a Fix/replace custom i18n function (#8681)
* replace custom i18n function calls

* remove custom i18n method
2020-09-16 11:26:15 +02:00
Henriette Dinger bd7f4e4814 Update copyright notice 2020-01-15 11:31:26 +01:00
ulferts fe6a96dd08 improve performance of workflow updating 2019-08-12 14:13:45 +02:00
Oliver Günther f86abae9eb Enforce Arel.sql for string order, pluck 2018-12-03 10:31:57 +01:00
Oliver Günther 6ef4211e77 Bump copyright to 2018 (#6171)
[ci skip]
2018-02-12 08:51:12 +01:00
ulferts c0b709530c Fix/replace deprecations (#5533)
* replace alias_method_chain

* remove deprecation silencing

* bump controller-testing

* introduce permitted params for settings

* replace various deprecations in controllers

* remove deprecation silencing for legacy_specs

* remove `puts` from spec

* replace deprecated access to errors

* remove unnecessary AR::Parameters usage in spec

* specify error to expect

* replace deprecations

* replace deprecated action calls in legacy function specs

* replace deprecations in functional controller tests

* replace deprecations in controllers/controller_specs

* remove params parser which does not seem to be in effect

It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code.

* replace deprecations in unit specs

* replace alias_method_chain

[ci skip]
2017-07-19 21:17:37 +02:00
Henriette Dinger 7e1c46a6f7 Hide breadcrub per default and show in admin, my, wikHide breadcrub per default and show in admin, my, wiki 2017-03-29 08:45:03 +02:00
Henriette Dinger 9936df8dae Add breadcrumb for workflow 2017-03-28 11:00:26 +02:00
Oliver Günther 7cf11bb689 Update copyright notice 2017-01-10 15:11:43 +01:00
Oliver Günther fe0e8dd919 Rename before_filter to before_action 2016-09-06 15:40:49 +02:00
Alex Coles e02eb0181d Migrate AR finder/query methods in controllers
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-06-30 12:12:51 +02:00
Alex Coles ec1bb39f9b Fix syntax (w/Rubocop) in (Rails) controllers
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-06-30 12:08:27 +02:00
Alex Coles 57618b25ec Replace dynamic finder usages with #find_by, etc.
This patch replaces all dynamic finders, for the sake of consistency,
although only some methods are deprecated. See:
https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders

* Revert some `User#find_by_login` usages in cuke steps accidentally
  removed in 74228b59.

User Story # 20325

Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-06-30 11:50:26 +02:00
Alex Coles f968ecffe1 Merge branch 'dev' into feature/rails4
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-06-03 17:42:39 +02:00
Jan Sandbrink 4a69d2505a replace ternaries returning booleans
- foo ? true : false was replaced where foo already was bool
- foo ? true : false was kept, when the ternary did a bool conversion
- foo ? false : true was replaced by either negation or replacing == with !=

Note: I intentionally left one occurence that is fixed in another running PR and would cause a conflict
2015-05-27 10:14:43 +02:00
Alex Coles e5da2578d5 Merge branch 'dev' into feature/rails4
Signed-off-by: Alex Coles <alex@alexbcoles.com>

Conflicts:
	.travis.yml
	Gemfile
	Gemfile.lock
	README.md
	app/assets/stylesheets/external.css.sass.erb
	app/assets/stylesheets/legacy/main.css.sass
	app/models/work_package.rb
	config/routes.rb
	lib/tabular_form_builder.rb
	spec/controllers/versions_controller_spec.rb
	spec/exemplars/type_exemplar.rb
	spec/factories/type_factory.rb
	spec/legacy/unit/default_data_spec.rb
	spec/legacy/unit/helpers/application_helper_spec.rb
	spec/legacy/unit/mail_handler_spec.rb
	spec/legacy/unit/project_spec.rb
	spec/legacy/unit/time_entry_activity_spec.rb
	spec/legacy/unit/type_spec.rb
	spec/models/work_package/work_package_validations_spec.rb
	spec/requests/api/v3/render_resource_spec.rb
	test/functional/types_controller_test.rb
	test/test_helper.rb
	test/unit/version_test.rb
2015-05-01 11:39:24 +02:00
Alex Coles e0191e759c Update year in copyright header to 2015
[ci skip]
2015-01-01 00:02:57 +00:00
Alex Coles f35e741387 Merge branch 'dev' into feature/rails4
Signed-off-by: Alex Coles <alex@alexbcoles.com>

Conflicts:
	app/controllers/api/v2/authentication_controller.rb
	app/controllers/api/v2/planning_element_journals_controller.rb
	app/controllers/api/v2/planning_element_type_colors_controller.rb
	app/controllers/api/v2/project_associations_controller.rb
	app/controllers/api/v2/project_types_controller.rb
	app/controllers/api/v2/projects_controller.rb
	app/controllers/api/v2/reported_project_statuses_controller.rb
	app/controllers/api/v2/reportings_controller.rb
	app/controllers/api/v2/timelines_controller.rb
	app/controllers/api/v2/users_controller.rb
	app/controllers/copy_projects_controller.rb
	app/controllers/custom_fields_controller.rb
	app/controllers/projects_controller.rb
	app/controllers/time_entries/reports_controller.rb
	app/controllers/types_controller.rb
	app/controllers/versions_controller.rb
	app/controllers/workflows_controller.rb
	app/helpers/types_helper.rb
	app/models/project.rb
	app/models/query.rb
	app/models/timeline.rb
	app/models/type.rb
	app/models/work_package.rb
	app/models/workflow.rb
	app/services/planning_comparison_service.rb
	config/initializers/10-patches.rb
	config/routes.rb
	db/seeds/production.rb
	features/step_definitions/general_steps.rb
	features/step_definitions/issue_steps.rb
	features/step_definitions/timelines_given_steps.rb
	features/step_definitions/type_steps.rb
	features/step_definitions/work_package_steps.rb
	lib/redmine/default_data/loader.rb
	lib/tasks/ci.rake
	lib/tasks/documentation.rake
	spec/controllers/api/v2/planning_elements_controller_spec.rb
	spec/factories/type_factory.rb
	spec/views/api/v2/custom_fields/index_api_rabl_spec.rb
	spec/views/api/v2/planning_elements/show_api_json_spec.rb
	spec/views/api/v2/projects/show_api_json_spec.rb
2014-11-04 20:50:24 +01:00
Alex Coles bb0e6e6aa5 Fix syntax (w/Rubocop) in (Rails) controllers
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-11-03 22:15:11 +01:00
Alex Coles 336446c59d Use 1.9+ Hash syntax in (Rails) controllers
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-11-03 22:15:11 +01:00
Alex Coles 0b941955ce Fully qualify ::Type class constant
This fixes a naming collision with AR internals:

    undefined method `find' for ActiveRecord::AttributeMethods::Serialization::Type:Class

Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-09-13 19:07:45 +02:00
Johannes Wollert 8b096975fe updates copyright headers
updates more copyright

more copyright headers
2014-02-27 16:39:51 +01:00
Sebastian Schuster 11a566a044 Removed now-redundant specification of Status sort order 2014-02-25 10:53:21 +01:00
Hagen Schink 2f5e9ad3d6 Renames IssueStatus to Status 2013-10-01 17:14:01 +02:00
Philipp Tessenow a1e67dd460 new copyright header #1903 2013-09-16 17:59:31 +02:00
Martin Czuchra 847a3029a9 Renames Tracker into Type. 2013-07-18 16:18:14 +02:00
Jens Ulferts 21459a384f provide every possible file with a short copyright notice
This was done using the rake task: rake copyright:update
2013-06-07 10:49:57 +02:00
Holger Just 91070236db Set source encoding to UTF-8 2011-10-29 14:48:03 +02:00
Holger Just 07185fb169 [#436] Remove trailing whitespace 2011-05-30 20:52:25 +02:00
Eric Davis 99507a0391 [#197] Upgrade the copyright in the code files 2011-05-29 13:11:52 -07:00
Eric Davis e131c3b531 [#197] Remove old copyrights 2011-05-29 12:50:08 -07:00
Jean-Philippe Lang cc2d6f3605 Allow additional workflow transitions for issue author and assignee (#2732).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4895 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-04-16 14:43:45 -07:00
Eric Davis be20d98040 Refactor: Extract methods to before_filters
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3536 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-03-04 05:33:45 +00:00
Jean-Philippe Lang 008ad85d10 Fixes an error with postgres.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3193 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-19 12:40:43 +00:00
Jean-Philippe Lang 6bf0723d06 By default, only show statuses that are used by the tracker on the workflow edit view.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3188 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-18 15:41:32 +00:00
Jean-Philippe Lang dfabadf4f7 Adds an admin layout that displays the admin menu in the sidebar.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3176 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-17 18:21:02 +00:00
Jean-Philippe Lang 5c6ce51ec9 Adds workflow copy functionality (#1727).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3154 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-12-12 10:06:07 +00:00
Jean-Philippe Lang a37af7a226 Adds a workflow overview screen.
Workflow setup moved to a dedicated controller.

git-svn-id: http://redmine.rubyforge.org/svn/trunk@1914 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-09-28 12:03:17 +00:00