76 Commits

Author SHA1 Message Date
Jan Sandbrink 1f7de54aee Remove option to show wiki item as submenu
This option seems to have been broken for quite some time
and lead to pretty inconsistent results. What it clearly didn't
do was to show the item in the project navigation. Some effects were
visible in the wiki navigation, some of them only in some views of
the wiki.

This must have been broken for quite some time without major complaints
about it. Since we want to generalize our wiki options going forward and
also integrate with external wikis, this is a good chance for simplification.

Therefore instead of trying to reverse engineer what this option was supposed
to do, it's going to be removed for the time being.
2026-03-12 11:15:56 +01:00
Klaus Zanders 688626a7d4 Fix wiki specs and view 2026-02-13 11:05:51 +01:00
Klaus Zanders 3af9130e4c Fix specs and rubocop for wiki page menu items 2026-02-13 09:59:03 +01:00
Klaus Zanders 0eecb87a9d Load Wiki Pages properly through the Wiki 2026-02-12 16:24:59 +01:00
Oliver Günther 14192a74c3 Replace confirm with turbo-confirm, method with turbo-method 2025-09-26 09:15:04 +02:00
Alexander Brandon Coles f15be6e07f Freeze string literals in app/controllers
rubocop -A --only Style/FrozenStringLiteralComment,Layout/EmptyLineAfterMagicComment,Style/RedundantFreeze app/controllers
2025-07-18 17:51:00 +01:00
Oliver Günther b65e2cb514 Allow redirecting back to global 2025-02-13 13:16:54 +01:00
Oliver Günther 5e48ad2927 Lint 2024-11-05 17:13:30 +01:00
Oliver Günther fa99c5bef6 Render with status: :unprocessable_entity 2024-10-11 08:42:58 +02:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard 8fa8584538 Run rubocop --autocorrect on all files
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Christophe Bliard a33524ef6d remove ruby magic comment for utf-8
ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless
2022-03-10 19:36:58 +01:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Oliver Günther 0a0c55850e [40790] Fix missing menu_item in wiki items controller
https://community.openproject.org/wp/40790
2022-01-25 09:06:25 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
ulferts 1bdd2ab9ae safe automatic fixes by rubocop (#8994) 2021-02-11 16:02:18 +01:00
ulferts 6140f4c7e9 update copyright to 2021 (#8925)
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.

Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
Henriette Dinger bd7f4e4814 Update copyright notice 2020-01-15 11:31:26 +01:00
Jens Ulferts 71703432d9 replace wiki menu item cukes 2018-08-23 09:24:49 +02:00
Jens Ulferts abda9056cd add attachment on new resource via rails form 2018-08-01 10:37:21 +02:00
Wieland Lindenthal fa2905b851 Codeclimate improvements 2018-05-17 14:08:05 +02:00
Wieland Lindenthal 1c3ea0a370 fix and satisfy cuke 2018-05-16 16:29:42 +02:00
Wieland Lindenthal ed96f8aee6 Fix main menu when configuring custom menu items for wiki 2018-05-15 15:22:27 +02:00
Wieland Lindenthal 254e4a43a8 WIP: Fix that „Entry page“ finally is not selected if a non menu item page was requested. 2018-05-14 17:00:20 +02:00
Oliver Günther 6ef4211e77 Bump copyright to 2018 (#6171)
[ci skip]
2018-02-12 08:51:12 +01:00
Henriette Dinger 2f092e3f0e Merge remote-tracking branch 'origin/release/6.1' into merge-dev-release 2017-03-07 09:46:10 +01:00
Oliver Günther a799de0157 Remove invalid wiki menu children nodes if the slug already exists
They will be unable to be selected and/or removed by hand anyway,
so we should just delete them.
2017-02-04 09:21:55 +01:00
Oliver Günther 7cf11bb689 Update copyright notice 2017-01-10 15:11:43 +01:00
Jens Ulferts 571b2098c7 Merge branch 'release/6.0' into dev 2016-10-06 11:17:09 +02:00
Markus Kahl 471733ab05 prevent renaming wiki pages if there will be menu item conflicts 2016-09-20 11:40:20 +01:00
Oliver Günther fe0e8dd919 Rename before_filter to before_action 2016-09-06 15:40:49 +02:00
Oliver Günther c5ca7e7782 Actually save the title, not the name 2016-08-22 13:18:48 +02:00
Oliver Günther 35fa92c2ff Fix specs according to title <-> name swap 2016-08-03 14:54:11 +02:00
Oliver Günther 4f7c7d4ae9 [23753] Use MenuItem#title to discover the page
Since WikiMenuItem doesn't provide any other locator other than the
title, we can employ `wiki.find_page` to locate the page by title.
That title is either matched to the slug, or found by the legacy
redirect introduced with 6.0.1.

This still feels weird, but without an explicit column or accessor to
the page, there's not much we can do while keeping compatibility.

https://community.openproject.com/projects/openproject/work_packages/23753
2016-08-03 14:54:09 +02:00
Oliver Günther b12dc1998d Fix lookup for menu-items controller 2016-07-27 15:06:18 +02:00
Oliver Günther 7312ed1d6f Remove pretty_title since that won't matter now. 2016-07-27 11:03:17 +02:00
Oliver Günther a801a5c403 Unescape titles coming from route params 2016-01-08 14:37:06 +01:00
Alex Coles 0ad3cfb4b2 Prefer do…end for controller respond_to blocks
`rubocop -a` does not currently normalise formatting consistently
(see ec1bb39f).

Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-07-07 19:44:22 +02:00
Alex Coles e02eb0181d Migrate AR finder/query methods in controllers
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-06-30 12:12:51 +02:00
Alex Coles 57618b25ec Replace dynamic finder usages with #find_by, etc.
This patch replaces all dynamic finders, for the sake of consistency,
although only some methods are deprecated. See:
https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders

* Revert some `User#find_by_login` usages in cuke steps accidentally
  removed in 74228b59.

User Story # 20325

Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-06-30 11:50:26 +02:00
Alex Coles e0191e759c Update year in copyright header to 2015
[ci skip]
2015-01-01 00:02:57 +00:00
Alex Coles bb0e6e6aa5 Fix syntax (w/Rubocop) in (Rails) controllers
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-11-03 22:15:11 +01:00
Alex Coles 336446c59d Use 1.9+ Hash syntax in (Rails) controllers
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-11-03 22:15:11 +01:00
Johannes Wollert 8b096975fe updates copyright headers
updates more copyright

more copyright headers
2014-02-27 16:39:51 +01:00
Till Breuer ac92678f21 Fix redirect path after wiki menu item creation 2013-11-20 18:05:45 +01:00