88 Commits

Author SHA1 Message Date
Oliver Günther d6b0e8c2cd Re-enable embedded table 2025-07-23 15:59:49 +02:00
Oliver Günther 01139ce331 Remove gon 2025-07-23 15:59:49 +02:00
Oliver Günther 3651147f67 Make filter a bit more usable
Instead of passing module name directly, use filter=module
2025-07-23 15:59:49 +02:00
Oliver Günther 0cb9d86c12 Replace tabs with tab_nav 2025-07-23 15:59:49 +02:00
Behrokh Satarnejad 56abad9b22 [65336] Missing breadcrumb in remaining pages (#19405)
* eke the last item section in breadcrumbs component optional

* add breadcrumbs to the duplicate page

* add breadcrumbs to the create new work package page

* add breadcrumbs to move and copy pages

* when there is one WP in the list of moving or copy, add it to the breadcrumbs

* add page header to bulk editor page

* fix failing tests

* show the list of moved Wps even when there is one item

* add instance name to the breadcrumb in any way

* add breadcrumbs to search page

* show global menu when there is no project selected, in search page

* remove home path from rails breadcrumbs

* ensure reliable click on autocomplete by using JS click to avoid overlapping elements

* fix failing test on selecting a value from select box in team planner and search box
2025-07-09 09:19:16 +02:00
Jan Sandbrink 67637e3446 Make "search" related code frozen string compatible
We found some failing tests due to frozen string literals.
In one case it made sense to explicitly mark the starting string
as non-frozen, because we repeatedly add content to it.
2025-03-31 10:43:34 +02:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
ulferts 563229dc3e rename method for clarity 2024-06-10 17:19:55 +02:00
ulferts d3e81b257b remove methods rendered superfluous by using default auth methods 2024-06-07 16:57:27 +02:00
ulferts ed5a162230 allow actions to be called on those not using default authorization before_actions 2024-06-07 16:55:40 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard 8fa8584538 Run rubocop --autocorrect on all files
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Klaus Zanders de1851b2d8 Replace allowed_to calls in controllers except ApplicationController 2023-10-27 13:52:50 +02:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Oliver Günther 4161b33b47 Don't raise an exception in the search controller
instead, use ruby 2.6. conversion with exception: false
2022-06-21 09:28:16 +02:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
Christophe Bliard a33524ef6d remove ruby magic comment for utf-8
ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless
2022-03-10 19:36:58 +01:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
ulferts 1bdd2ab9ae safe automatic fixes by rubocop (#8994) 2021-02-11 16:02:18 +01:00
ulferts 6140f4c7e9 update copyright to 2021 (#8925)
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.

Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
ulferts 5a7176e6e1 Fix/search for projects (#8815)
* fix searching for projects

* only provide search options active in the project
2020-11-02 13:18:13 +01:00
Oliver Günther cf4975cad3 [26684] Redirect to WP from search only with #ID match on enter
Currently, the backend redirects to work packages whenever an ID is
exactly matched with or without the `#` prefix. This means users cannot
explicitly trigger a search through the "global" or "in this project"
buttons.

If we remember the match in the frontend, we can redirect it _only_ when
pressing enter. I also restricted the search to match with the `#`
prefix only

https://community.openproject.com/wp/26684
2020-03-30 07:59:32 +02:00
ulferts 9e2287bfcc rename and inflect according to zeitwerk 2020-02-21 20:47:24 +01:00
Henriette Dinger bd7f4e4814 Update copyright notice 2020-01-15 11:31:26 +01:00
ulferts 3eb20198b4 linting 2019-10-14 13:55:52 +02:00
Jens Ulferts fdaa449236 avoid initial search on work package tab 2019-03-13 15:04:12 +01:00
Wieland Lindenthal 835d9aca06 Remove minimum length for search terms in global search 2019-02-27 12:50:50 +01:00
Wieland Lindenthal c2819c466d improve code climate 2019-01-30 15:57:05 +01:00
Wieland Lindenthal 00cd53ef53 GlobalSearchTabs should not know that the All tab is treated differently. 2019-01-30 15:57:00 +01:00
Wieland Lindenthal 77b515546a Render tabs within Angular.
Overwrite tab names for forum and wiki.
2019-01-30 15:57:00 +01:00
Wieland Lindenthal 45b511a649 Remove project scope selector and integrate it into the autocompleter. 2019-01-30 15:56:58 +01:00
Wieland Lindenthal 6c5dba3eb9 WIP: Add a GlobalSearchService 2019-01-30 15:56:58 +01:00
Wieland Lindenthal 57d86b4a3f WIP: Add attachment fulltext and filename to old rails search.
- add  "All" tab
- remove "titles only"
- remove "all words" option and make it default.
2019-01-30 15:56:57 +01:00
Wieland Lindenthal 5df4e032ab remove "My projects" from scope 2019-01-30 15:56:56 +01:00
Wieland Lindenthal 816c6bd8ca Render work package table for work package search 2019-01-30 15:56:56 +01:00
Henriette Dinger 99f468fe33 Make search with subprojects default 2018-11-26 11:32:21 +01:00
Inga Mai 2d0d2feccf [27828] Feature: Query menu in sidenav (#6429)
* in main menu add gantt as extra work package child item

* Satisfy spec and code climate

* Add gantt chart icon behin default gantt query name.

* WIP Query menu in left sidebar

* Shift query dropdown in left sidenav

* Reload menu or load query on click from every project location

* WIP set correct label for default queries

* Query menu listens on all changes of queries (delete, create, rename, toggle starred) and updates immediatly

* WIP: Inline edit, field validation

* Inline Edit validation and comfirm

* Inline edit: validation of duplicate name

* Set default columns and sorting for static queries

* Codeclimate issues fixed

* WIP Inline edit validation not working perfectly in all error states

* Inline edit working

* Autocompleter hover disabled and hovering over categories fixed

* Category hover and toggle fixed; tested in Chrome, Firefox and Opera

* Placeholder cut off fixed and text wrap added

* English and german wording adjusted

* Styles of inline edit and menu adjusted; matching wiki page styles

* prevent menus to be displayed to often

* application menu only displayed on work package

* specify using no_menu layout more often

* adapt tests to altered production implementation

* Hamburger icon only in project; on global wp page: default queries shown correctly and summary removed

* searching for undefined leads to error

* Accessible click fixed (listen on escape)

* Gantt in top menu deleted (gantt chart is part of default queries on wp page)

* load menu on wp summary page

* reduce times queries are loaded

* lowercase on second word

* remove menu from search and home

* Styles fixed (category toggle and correct highlighting)

* reflect static query in url

* fix autocomplete handling in specs

* Open all global menus on default and hide hamburger icon on global pages; Rebuild changes that have been ovrwritten after merge"

* Correct highlighting of default queries  after reload

* Replace summary cuke with spec

* WIP

* Clear up selectors

* Avoid actively setting promises and instead use $state.go to load links

[ci skip]

* Make editable title component a little simpler

We can reuse the component I built for the wiki, that wasn't present in
the frontend beforehand.

* Fix moving through the menu and selecting items

[ci skip]

* Add save button to query title when query changed

* Improve static names lookup by comparing query_props

* Adapt and fix specs

* Allow inner scrolling of wp query results

Also, style the webkit scrollbar to make it pretty where supported

* Allow renaming the query through setting menu, but simply focus on field

[ci skip]
2018-08-09 14:51:49 +02:00
Oliver Günther 6ef4211e77 Bump copyright to 2018 (#6171)
[ci skip]
2018-02-12 08:51:12 +01:00
Oliver Günther 7cf11bb689 Update copyright notice 2017-01-10 15:11:43 +01:00
Oliver Günther 8391a9c0d2 Use PermittedParams to allow search parameters 2016-09-12 15:12:01 +02:00
Oliver Günther fe0e8dd919 Rename before_filter to before_action 2016-09-06 15:40:49 +02:00
Alex Coles 57618b25ec Replace dynamic finder usages with #find_by, etc.
This patch replaces all dynamic finders, for the sake of consistency,
although only some methods are deprecated. See:
https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders

* Revert some `User#find_by_login` usages in cuke steps accidentally
  removed in 74228b59.

User Story # 20325

Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-06-30 11:50:26 +02:00
Jan Sandbrink 4a69d2505a replace ternaries returning booleans
- foo ? true : false was replaced where foo already was bool
- foo ? true : false was kept, when the ternary did a bool conversion
- foo ? false : true was replaced by either negation or replacing == with !=

Note: I intentionally left one occurence that is fixed in another running PR and would cause a conflict
2015-05-27 10:14:43 +02:00
Alex Coles 64b288af36 Remove MessagesHelper includes
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-02-02 18:35:08 +01:00
Alex Coles e0191e759c Update year in copyright header to 2015
[ci skip]
2015-01-01 00:02:57 +00:00
Alex Coles 8a28b1a730 Prefer #map over #collect in (Rails) controllers
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-11-04 11:24:45 +01:00