The dialog is now rendered using primer components and uses
Turbo Stream and JavaScript events to render the dialog and handle
its result, instead of using Angular to do that.
Naming of the existing stimulus controller has been updated, to correctly reflect
that it's not about the confirmation dialog itself, but rather about components that
depend on the dialog.
Renames menu items, headings, routes and controller actions.
N.B. Uses **locale** in code (to encapsulate both language and region),
and **Language and Region** in user-facing text.
* add a new helper for breadcrumb in wiki page
* set page header in destroy page
* set page header in edit page
* set page header in history and rename and edit parent pages
* change toolbar items into page header items
* add new wiki action to sub header
* remove version edit page which is not in use any more
* add export as a menu item of the header
* fix rubocup errors
* fix failing tests
* replace page header in annotate page
* replace page header in diff page
* add page header in select menu page
* fix rubocup errors
* fix errors on rename test
* fix errors on selecting items from toolbar
* fix errors on tests for child pages
* set correct permission for configure menu item
* replace page header in summary page
* replace page header in summary details page
* edit docs of sub header
* add page header in wiki new page
* remove controller and a route for edit method
* undo changes for docs of sub header
* extract header in show page into a new component
* use helper method in header component
* add wiki module to the breadcrumb
* rename page header component for wiki page
* simplify how lock and lock implemented
* extract sub header
* remove wiki title from header of history page
* fix page header in new page
* use page.find_test_selector in test
* fix failing test for summary page
* fix failing test for wiki child pages
* change the summary test
* use test selector for page header title
* undo changes for activate user in admin
* use test selector in adding editing history test
* use test selector in attachment upload test
* use test selector in child pages tests
* use test selector in wiki menu items tests
* change test selector for breadcrumbs
* extract conditions to show edit button into a method
* extract conditions to show rollback action menu item into a method
* extract conditions to show create button into a method
* fix duplicated code in test
* Remove outdated `show_local_breadcrumb` method which is replaced by the Primer::PageHeader breadcrumb
* Remove `default_breadcrumb` method as it serves no prupose any more
* Remove the old breadcrumb and its hook completely
* remove breadcrumbs path from rename
* fix translations errors in storages
* undo changes on translations
* remove default breadcrumbs in time tracking controller
---------
Co-authored-by: Behrokh Satarnejad <b.satarnejad@openproject.com>
Co-authored-by: Behrokh Satarnejad <62008897+bsatarnejad@users.noreply.github.com>
* replace page header in profile, settings,sessions, password pages
* replace page header in user email reminder page
* replace page header in user access token page
* fix layout error on access token
* add page header component to two factor authentication page
* remove toolbar for email reminder
* use page header component in change avatar page
* unify menu entry and page header title for avatar page
* add page header for delete account pages
* add users and permissions to the breadcrumb of delete account from admin side
* create a separate component for page header in delete account page
* use page header component in n notifications settings and remove toolbar component in notification settings component and reminder settings component
* add page header component to 2fa new page
* add page header component to 2fa new pages and chnage the name of delete account page header component
* change user path in breadcrumb of delete account page
* remove show_toolbar of the component from reminders pages
* move page header to the top of the page in 2fa devices page
* remove the container element from access token page
* remove new type html and use action menu instead
* add description to menu item and change descriptions and titles
* Remove inline create button at the bottom of table
* fix failing specs
* fix failing spec
* fix rubocop error
* undo removing the page that is used for creating a new 2fa device in a state that is enforced by admin
* fix specs for selecting a device from action menu
* set the correct breadcrumb for add a new device
* undo changes for tests of forced registration
* undo changes for tests of new method when reverting deleted file
* add page header to the 2fa add new device page
* change html title in the 2fa add new device page
* change breadcrumbs in 2fa new device page
* use test selector helper in specs
* add page header to backup codes page
* shorten title an breadcrumb in backup code page
* remove closed tag
https://community.openproject.org/work_packages/56780
The previous behaviour was like this:
If the API Token Creation was not successful, the form in the dialog was
reloaded via turbo with error messages / form validations.
If the API Token Creation was successful, a full page reload was triggered
(so that the flash was shown and the table was updated).
Unfortunately, Turbo does not recognize the full page reload and therefore
does not load and initialize javascript linked in the page - so our Angular
App did not get initialized.
Since people were unhappy about the flash in general (because it's easy
to be missed by the user who has to copy the new token), it was decided
to switch to using a modal to avoid the full page reload.
Tobias Dillmann