96 Commits

Author SHA1 Message Date
Oliver Günther 3fcdc893b4 Also use visible scope for activities view 2026-05-19 08:47:56 +02:00
Oliver Günther fea9ecf623 Use project specific checking for custom field visibility in journals 2026-05-19 08:41:14 +02:00
Oliver Günther 27817f2871 Explicitly call journable.visible? on the diff controller 2026-05-18 11:28:51 +02:00
Ivan Kuchin 41d82d8322 Merge pull request #21452 from opf/feature/64264-comment-fields-for-project-attributes
Feature/64264 comment fields for project attributes
2026-02-25 20:45:14 +01:00
Ivan Kuchin 73803c59cd add admin_only_allowed setting to acts_as_customizable 2026-02-25 20:07:13 +01:00
Ivan Kuchin aa77d91ea3 prevent revealing of deleted custom fields diff only for journable that can have admin_only fields 2026-02-25 20:07:13 +01:00
Ivan Kuchin 58bceda1b6 refactor checking if field can be diffed 2026-02-25 16:00:29 +01:00
Ivan Kuchin d71ad110d7 allow showing journal diff for deleted custom fields 2026-02-25 16:00:27 +01:00
Ivan Kuchin aa144bae9d show custom comment journal diff 2026-02-25 16:00:25 +01:00
as-op 0b98d75179 [#72446] Create journal entries for issue history
https://community.openproject.org/work_packages/72446
2026-02-25 11:21:42 +01:00
Ivan Kuchin be3f82ba95 [#66925] Activity shows changes to admin only custom fields also to non admin users
https://community.openproject.org/work_packages/66925
2025-08-26 19:44:38 +02:00
Dombi Attila 10dc5538a2 [#63386] Use rescue_from ActiveRecord::RecordNotFound
https://community.openproject.org/work_packages/63386
2025-04-14 13:44:28 +03:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
Ivan Kuchin 953488f46b handle custom fields in journals#diff 2024-07-30 15:06:24 +02:00
ulferts fdbd6b6d5a forcing to specify allowed actions when forfeiting authorization check 2024-06-11 10:29:22 +02:00
ulferts 563229dc3e rename method for clarity 2024-06-10 17:19:55 +02:00
ulferts ed5a162230 allow actions to be called on those not using default authorization before_actions 2024-06-07 16:55:40 +02:00
Oliver Günther 6227f6f04d Add diff for agenda item notes (#15179)
* Add diff for agenda items

To make the diff available without too much hassle in the journal controller,
the key of the events need to be what the journal details are (e.g., `agenda_items_X_notes`).

For that to work, we need to adapt the event mapper and formatters a little bit.

https://community.openproject.org/work_packages/53975

* Use target=_top for diff link

* Add diff for agenda items

To make the diff available without too much hassle in the journal controller,
the key of the events need to be what the journal details are (e.g., `agenda_items_X_notes`).

For that to work, we need to adapt the event mapper and formatters a little bit.

https://community.openproject.org/work_packages/53975

* Use target=_top for diff link

* Update spec

* Adapt journal key after merge

---------

Co-authored-by: Mir Bhatia <m.bhatia@openproject.com>
2024-04-08 19:33:47 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Klaus Zanders 4246a556ea Catch unkown permission error in journals controller 2023-11-09 15:55:03 +01:00
ulferts 5a61e83bb0 avoid instance variables in helper 2023-05-31 13:10:31 +02:00
Aaron Contreras 68a8ab0073 Register status_explanation as a field to be rendered
Adds status_explanation as part of the rendering of activities
for project attributes.
2023-05-15 14:56:54 -05:00
Christophe Bliard 02673ed212 [46190] Link back button of diff page to the correct page
https://community.openproject.org/wp/46190
2023-02-21 18:06:52 +01:00
Christophe Bliard 0e634e24d9 refactor: Simplify logic to validate params 2023-02-06 09:32:44 +01:00
Christophe Bliard 78b3c94ecb Handle finer permissions for journals/diff endpoint
As description of both WorkPackage and Project journal can be diffed,
the needed permissions have to be distinct: view_project for Project
description diff, and view_work_packages for WorkPackage description
diff.
2023-02-06 09:30:32 +01:00
Mir Bhatia bec67bc4ed Add project journal attribute for description 2023-01-26 13:54:17 +01:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Christophe Bliard a33524ef6d remove ruby magic comment for utf-8
ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless
2022-03-10 19:36:58 +01:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
ulferts 2a015eeac3 Feature/journal aggregation on write (#9396)
* aggregate journals on write - simple implementation

* remove references to aggregated journals on read

* rewrite existing journals to be aggregated

* remove aggregated journal reference

* only delete predecessor if it can be aggregated

* fix aggregation condition

* adapt specs

* remove aggregated journal functionality from production code

The code is still necessary in a migration for the time being

* adapt specs

* use polymorphic belongs_to for journal data

The association can then be employed for eager loading

* eager load for activity rendering
2021-06-17 20:08:58 +02:00
ulferts 1bdd2ab9ae safe automatic fixes by rubocop (#8994) 2021-02-11 16:02:18 +01:00
ulferts 6140f4c7e9 update copyright to 2021 (#8925)
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.

Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
ulferts 5968c0b18a Fix/replace custom i18n function (#8681)
* replace custom i18n function calls

* remove custom i18n method
2020-09-16 11:26:15 +02:00
ulferts 983709db89 rewrite acts as journalized to create journals in sql 2020-05-25 10:43:04 +02:00
ulferts cd049721d5 rename/move according to zeitwerk 2020-02-21 20:47:25 +01:00
Henriette Dinger bd7f4e4814 Update copyright notice 2020-01-15 11:31:26 +01:00
ulferts d37bdb71f0 extract methods 2019-10-29 08:02:04 +01:00
Oliver Günther 1193a05efa [28426] Warn empty diffs in journals controller
https://community.openproject.com/wp/28426
2018-09-05 09:06:21 +02:00
Oliver Günther 6ef4211e77 Bump copyright to 2018 (#6171)
[ci skip]
2018-02-12 08:51:12 +01:00
Jens Ulferts 173204c36b embedding and linking to available sort bys when embedding query schema 2017-02-08 08:32:56 +01:00
Oliver Günther 7cf11bb689 Update copyright notice 2017-01-10 15:11:43 +01:00
Oliver Günther fe0e8dd919 Rename before_filter to before_action 2016-09-06 15:40:49 +02:00
Oliver Günther 9093be6730 Remove journal notes edit and preview 2016-05-02 07:46:54 +02:00
Alex Coles e4c87bc2b4 Merge branch 'dev' into feature/rails4
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-08-08 19:44:58 +01:00
Jan Sandbrink f9051bba3e display diff of containing aggregated journal
... instead of displaying the diff for the requested journal only

- this should provide the best forward compatibility of links
- even when aggregation timeframes are changed intermittently
2015-08-06 09:32:16 +02:00
Alexander Bach a8e1aadec7 replace changed_data by details
working towards making the alias obsolete...
2015-08-06 09:32:15 +02:00