98 Commits

Author SHA1 Message Date
Henriette Darge 72a274dbd5 Restore the old customOptions table but within a separate "items" tab 2026-02-19 15:45:20 +01:00
Oliver Günther 47477fe687 Add tab for work package custom fields 2025-11-25 22:06:39 +01:00
Alexander Brandon Coles f15be6e07f Freeze string literals in app/controllers
rubocop -A --only Style/FrozenStringLiteralComment,Layout/EmptyLineAfterMagicComment,Style/RedundantFreeze app/controllers
2025-07-18 17:51:00 +01:00
Henriette Darge ee8452282a [63485] Remove show_local_breadcrumb and default_breadcrumb (#18663)
* add a new helper for breadcrumb in wiki page

* set page header in destroy page

* set page header in edit page

* set page header in history and rename and edit parent pages

* change toolbar items into page header items

* add new wiki action to sub header

* remove version edit page which is not in use any more

* add export as a menu item of the header

* fix rubocup errors

* fix failing tests

* replace page header in annotate page

* replace page header in diff page

* add page header in select menu page

* fix rubocup errors

* fix errors on rename test

* fix errors on selecting items from toolbar

* fix errors on tests for child pages

* set correct permission for configure menu item

* replace page header in summary page

* replace page header in summary details page

* edit docs of sub header

* add page header in wiki new page

* remove controller and a route for edit method

* undo changes for docs of sub header

* extract header in show page into a new component

* use helper method in header component

* add wiki module to the breadcrumb

* rename page header component for wiki page

* simplify how lock and lock implemented

* extract sub header

* remove wiki title from header of history page

* fix page header in new page

* use page.find_test_selector in test

* fix failing test for summary page

* fix failing test for wiki child pages

* change the summary test

* use test selector for page header title

* undo changes for activate user in admin

* use test selector in adding editing history test

* use test selector in attachment upload test

* use test selector in child pages tests

* use test selector in wiki menu items tests

* change test selector for breadcrumbs

* extract conditions to show edit button into a method

* extract conditions to show rollback action menu item into a method

* extract conditions to show create button into a method

* fix duplicated code in test

* Remove outdated `show_local_breadcrumb` method which is replaced by the Primer::PageHeader breadcrumb

* Remove `default_breadcrumb` method as it serves no prupose any more

* Remove the old breadcrumb and its hook completely

* remove breadcrumbs path from rename

* fix translations errors in storages

* undo changes on translations

* remove default breadcrumbs in time tracking controller

---------

Co-authored-by: Behrokh Satarnejad <b.satarnejad@openproject.com>
Co-authored-by: Behrokh Satarnejad <62008897+bsatarnejad@users.noreply.github.com>
2025-04-23 10:40:43 +02:00
Dombi Attila 10dc5538a2 [#63386] Use rescue_from ActiveRecord::RecordNotFound
https://community.openproject.org/work_packages/63386
2025-04-14 13:44:28 +03:00
Eric Schubert 482b7d7d27 [#59985] add validation check to custom field controller
- https://community.openproject.org/work_packages/59985
- do not allow creation of custom fields of type hierarchy
2024-12-11 15:20:45 +01:00
Eric Schubert 5f5c53ff60 [#58635] fixed details form for custom fields
- https://community.openproject.org/work_packages/58635
- use correct form field indicator for required
- have multi-select validation for hierarchies
2024-10-25 14:52:12 +02:00
Henriette Darge 8788b34dbf Update the last page headers to use the new Primer::OpenProject::PageHeader component 2024-08-23 09:56:02 +02:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
Ivan Kuchin 6678cab48d auto correct quotes 2024-03-28 18:22:34 +01:00
jjabari-op 442eb03cdc Refactoring as suggested by @dombesz
Co-authored-by: Dombi Attila <83396+dombesz@users.noreply.github.com>
2024-03-12 11:19:27 +01:00
Jonas Jabari 8685d3eb72 removed feature flag as discussed with @oliverguenther 2024-02-19 14:25:37 +07:00
Jonas Jabari d529ee818a hiding more parts of the new concept behind the feature flag 2024-01-19 16:09:57 +01:00
ulferts ed4d105c1e Merge remote-tracking branch 'origin/dev' into epic/49688-individuelle-gruppen-für-projektattribute 2024-01-04 15:36:30 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Jonas Jabari f7f3b2b16b disable project custom field management through custom fields UI 2023-11-27 10:28:45 +01:00
Jonas Jabari 029c655b7f refactored datamodeling, reuse custom field forms in new project attribute context 2023-11-24 14:51:25 +01:00
Aaron Contreras 33c7339433 [FEAT-47002] Remove EE-restriction banner from custom_fields#new/edit
In the custom fields create/edit flow, there were EE-only banners being
dsiplayed and a policy removing the `multi_value` param from being used
in the services called in the relevant controller actions.
2023-04-21 15:37:10 -05:00
Christophe Bliard 9e865b4f7b lint: Run rubocop safe autocorrect
Command is `rubocop --safe --autocorrect app lib lib_static modules spec`
2023-03-09 10:25:57 +01:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
Christophe Bliard a33524ef6d remove ruby magic comment for utf-8
ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless
2022-03-10 19:36:58 +01:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Oliver Günther 8984b989c6 Add include_gon to base template
This will avoid needing to identify in templates whether gon is already
present, and will ensure it can be used.
2022-02-09 14:59:04 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
Oliver Günther d504855091 Fix custom fields reordering 2021-08-05 16:34:34 +02:00
ulferts 1bdd2ab9ae safe automatic fixes by rubocop (#8994) 2021-02-11 16:02:18 +01:00
ulferts 6140f4c7e9 update copyright to 2021 (#8925)
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.

Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
ulferts 5968c0b18a Fix/replace custom i18n function (#8681)
* replace custom i18n function calls

* remove custom i18n method
2020-09-16 11:26:15 +02:00
Oliver Günther 5d753deffe [34289] Avoid duplicate output of error messages in flash
https://community.openproject.com/wp/34289
2020-09-07 14:05:56 +02:00
Oliver Günther 41f8dbaff2 Refactor custom fields into services 2020-09-03 09:08:40 +02:00
Inga Mai 0f4ce76ab5 Update admin tabs layout 2020-01-17 14:27:36 +01:00
Henriette Dinger bd7f4e4814 Update copyright notice 2020-01-15 11:31:26 +01:00
Oliver Günther 6ef4211e77 Bump copyright to 2018 (#6171)
[ci skip]
2018-02-12 08:51:12 +01:00
Jens Ulferts feeed1402b fix touch: true option on custo_field association
Adding inverse_of on the custom_field association seems to fix a bug in rails which otherwise prevents the custom_field to be touched because of the after_commit callbacks defined on custom_field by acts_as_list
2017-09-28 09:53:33 +02:00
Markus Kahl 7b990c453f don't fail when there are no options 2017-09-26 13:13:51 +01:00
Markus Kahl 88d2e933c5 fixed deprecation, each_with_index will go in rails 5.1 2017-09-26 10:10:33 +01:00
Markus Kahl 30043ad4a2 touch cf if options changed to invalidate cache
so that users get to see new options in filters.

The custom field's updated_at is not changed
automatically when anything in the has_many
relation changes. Hence we do this manually.
2017-09-26 10:09:54 +01:00
ulferts 75f501e897 Fix/custom field lacking options (#5768)
* enforce having at least one custom option for a list cf

Removes the hand written nested attributes handling by accept_nested_attributes_for.
Removes the arbitrary boundary of having 500 custom options.

* i18n for custom option mgmt

[ci skip]
2017-07-19 11:35:34 +02:00
ulferts 2fc03c6f20 restict eager loading to wp cfs (#5538)
[ci skip]
2017-05-19 16:26:16 +02:00
Wieland Lindenthal fd1f14df73 Feature #25064 Custom Fields table: Remove sorting for work package CFs and link to types (#5503)
* CF table: Remove sorting for work package custom fields and add types that use that cf

* Optimize query

[ci skip]
2017-05-16 16:42:10 +02:00
Jens Ulferts 32a3b0865b fix sorting of custom fields back url 2017-05-04 09:55:28 +02:00
Jens Ulferts ec41e10013 code prettification 2017-05-04 09:55:05 +02:00
Oliver Günther 93dcd386f4 Remove usage of CF translations 2017-04-03 22:34:08 +02:00
Oliver Günther b63175fa97 Merge pull request #5212 from opf/feature/attribute_groups
[24123] Work package group form configuration
2017-03-29 21:49:46 +02:00
Oliver Günther 2666f8dd70 Avoid enabling new CFs by default 2017-03-29 13:44:08 +02:00
Henriette Dinger 7e1c46a6f7 Hide breadcrub per default and show in admin, my, wikHide breadcrub per default and show in admin, my, wiki 2017-03-29 08:45:03 +02:00
Jens Ulferts b6fe2b5442 merge 6.1 2017-03-22 17:08:06 +01:00
Henriette Dinger dd4d709b38 Add links to beadcrumb 2017-03-06 15:42:29 +01:00
Markus Kahl de584216e8 fixed (and added spec for) adding options to existing cf 2017-03-06 10:27:17 +00:00