From f40e53426a3d54cd6330abb921e4bc83965e2be7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliver=20G=C3=BCnther?= Date: Mon, 10 Mar 2025 20:15:41 +0100 Subject: [PATCH] Fix editing meeting series from working_days https://community.openproject.org/work_packages/62089 --- .../meetings/index/form_component.html.erb | 2 +- .../recurring_meeting_crud_spec.rb | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/modules/meeting/app/components/meetings/index/form_component.html.erb b/modules/meeting/app/components/meetings/index/form_component.html.erb index 712a1a1001a..7af4732a12c 100644 --- a/modules/meeting/app/components/meetings/index/form_component.html.erb +++ b/modules/meeting/app/components/meetings/index/form_component.html.erb @@ -55,7 +55,7 @@ frequency_row.with_column( flex: 1, - hidden: @meeting.frequency_working_days?, + style: "visibility: #{@meeting.frequency_working_days? ? "hidden" : "visible"}", data: { target_name: "frequency", not_value: "working_days", diff --git a/modules/meeting/spec/features/recurring_meetings/recurring_meeting_crud_spec.rb b/modules/meeting/spec/features/recurring_meetings/recurring_meeting_crud_spec.rb index 142a4d2ac4a..aed1150fd41 100644 --- a/modules/meeting/spec/features/recurring_meetings/recurring_meeting_crud_spec.rb +++ b/modules/meeting/spec/features/recurring_meetings/recurring_meeting_crud_spec.rb @@ -189,6 +189,25 @@ RSpec.describe "Recurring meetings CRUD", show_page.expect_cancelled_actions date: "12/31/2024 01:30 PM" end + it "can edit the meeting series interval when created with working days (Regression #62089)" do + meeting.update!(frequency: "working_days") + + show_page.visit! + + show_page.edit_meeting_series + show_page.within_modal "Edit Meeting" do + page.select("Every day", from: "Frequency") + page.fill_in("Interval", with: "2") + + sleep 0.5 + click_link_or_button("Save") + end + + wait_for_network_idle + wait_for { meeting.reload.frequency }.to eq "daily" + wait_for { meeting.interval }.to eq 2 + end + context "with view permissions only" do let(:current_user) { other_user }