diff --git a/modules/overviews/app/controllers/overviews/project_custom_fields_controller.rb b/modules/overviews/app/controllers/overviews/project_custom_fields_controller.rb index eac1e1a2db3..3b9c7cd9ebc 100644 --- a/modules/overviews/app/controllers/overviews/project_custom_fields_controller.rb +++ b/modules/overviews/app/controllers/overviews/project_custom_fields_controller.rb @@ -35,6 +35,15 @@ class Overviews::ProjectCustomFieldsController < ApplicationController before_action :find_project_custom_field before_action :authorize + def show + respond_with_dialog( + Overviews::ProjectCustomFields::ShowDialogComponent.new( + project: @project, + project_custom_field: @custom_field + ) + ) + end + def edit respond_with_dialog( Overviews::ProjectCustomFields::EditDialogComponent.new( diff --git a/modules/overviews/lib/overviews/engine.rb b/modules/overviews/lib/overviews/engine.rb index 8161cd70af2..f6a4649b379 100644 --- a/modules/overviews/lib/overviews/engine.rb +++ b/modules/overviews/lib/overviews/engine.rb @@ -54,6 +54,7 @@ module Overviews OpenProject::AccessControl.permission(:view_project_attributes) .controller_actions .push( + "overviews/project_custom_fields/show", "overviews/overviews/project_custom_fields_sidebar" ) diff --git a/spec/permissions/edit_project_attributes_spec.rb b/spec/permissions/edit_project_attributes_spec.rb index 4e97e0f4e72..868155eafd7 100644 --- a/spec/permissions/edit_project_attributes_spec.rb +++ b/spec/permissions/edit_project_attributes_spec.rb @@ -35,6 +35,9 @@ RSpec.describe Overviews::ProjectCustomFieldsController, "edit_project_attribute type: :controller do include PermissionSpecs + # render dialog displaying project attributes + check_permission_required_for("overviews/project_custom_fields#show", :view_project_attributes) + # render dialog with inputs for editing project attributes with edit_project permission check_permission_required_for("overviews/project_custom_fields#edit", :edit_project_attributes)