From 953488f46be0415b91c4ff2b8cd87931ddabbcb8 Mon Sep 17 00:00:00 2001 From: Ivan Kuchin Date: Tue, 23 Jul 2024 18:46:05 +0200 Subject: [PATCH] handle custom fields in journals#diff --- app/controllers/journals_controller.rb | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/app/controllers/journals_controller.rb b/app/controllers/journals_controller.rb index d7ea7714252..2482b17cfb8 100644 --- a/app/controllers/journals_controller.rb +++ b/app/controllers/journals_controller.rb @@ -108,11 +108,14 @@ class JournalsController < ApplicationController end def valid_field_for_diffing? - %w[description status_explanation].include?(field_param) || agenda_item_notes? - end - - def agenda_item_notes? - field_param.match?(/\Aagenda_items_\d+_notes\z/) + case field_param + when "description", + "status_explanation", + /\Aagenda_items_\d+_notes\z/ + true + when /\Acustom_fields_(?\d+)\z/ + ::CustomField.exists?(id: Regexp.last_match[:id], field_format: "text") + end end def journals_index_title