From 73461d1da6a55129a67a27472a46fec76184935d Mon Sep 17 00:00:00 2001 From: Alexander Brandon Coles Date: Sat, 13 Jun 2026 19:13:36 +0100 Subject: [PATCH] [OP-19546] Migrate lodash sortBy in module frontends The linked-plugin frontends share the global `_` but were outside the frontend/src sweep. Switches `sortBy` in the GitLab and GitHub modules to the `lodash-es` named import (`_.flatten` here is handled in #23732). --- .../frontend/module/tab-prs/tab-prs.component.ts | 3 ++- .../frontend/module/tab-issue/wp-gitlab-issue.service.ts | 3 ++- .../frontend/module/tab-mrs/wp-gitlab-mrs.service.ts | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/modules/github_integration/frontend/module/tab-prs/tab-prs.component.ts b/modules/github_integration/frontend/module/tab-prs/tab-prs.component.ts index 63e9712e4ae..17a227fe75c 100644 --- a/modules/github_integration/frontend/module/tab-prs/tab-prs.component.ts +++ b/modules/github_integration/frontend/module/tab-prs/tab-prs.component.ts @@ -26,6 +26,7 @@ // See COPYRIGHT and LICENSE files for more details. //++ +import { sortBy } from 'lodash-es'; import { ChangeDetectionStrategy, Component, HostBinding, Input, OnInit, inject } from '@angular/core'; import { WorkPackageResource } from 'core-app/features/hal/resources/work-package-resource'; import { ApiV3Service } from 'core-app/core/apiv3/api-v3.service'; @@ -63,7 +64,7 @@ export class TabPrsComponent implements OnInit { .githubPullRequests .ofWorkPackage(this.workPackage) .pipe( - map((elements) => _.sortBy(elements, 'updatedAt')), + map((elements) => sortBy(elements, 'updatedAt')), shareReplay(1), ); } diff --git a/modules/gitlab_integration/frontend/module/tab-issue/wp-gitlab-issue.service.ts b/modules/gitlab_integration/frontend/module/tab-issue/wp-gitlab-issue.service.ts index 729b9376f96..51a2afdfc83 100644 --- a/modules/gitlab_integration/frontend/module/tab-issue/wp-gitlab-issue.service.ts +++ b/modules/gitlab_integration/frontend/module/tab-issue/wp-gitlab-issue.service.ts @@ -27,6 +27,7 @@ // See docs/COPYRIGHT.rdoc for more details. //++ +import { sortBy } from 'lodash-es'; import { WorkPackageResource } from "core-app/features/hal/resources/work-package-resource"; import { HalResource } from "core-app/features/hal/resources/hal-resource"; import { Injectable, inject } from '@angular/core'; @@ -45,6 +46,6 @@ export class WorkPackagesGitlabIssueService extends WorkPackageLinkedResourceCac } protected sortList(gitlabIssue:HalResource[], attr = 'createdAt'):HalResource[] { - return _.sortBy(_.flatten(gitlabIssue), attr); + return sortBy(_.flatten(gitlabIssue), attr); } } diff --git a/modules/gitlab_integration/frontend/module/tab-mrs/wp-gitlab-mrs.service.ts b/modules/gitlab_integration/frontend/module/tab-mrs/wp-gitlab-mrs.service.ts index 3c8d1fa8e3c..0948747eac6 100644 --- a/modules/gitlab_integration/frontend/module/tab-mrs/wp-gitlab-mrs.service.ts +++ b/modules/gitlab_integration/frontend/module/tab-mrs/wp-gitlab-mrs.service.ts @@ -27,6 +27,7 @@ // See docs/COPYRIGHT.rdoc for more details. //++ +import { sortBy } from 'lodash-es'; import { WorkPackageResource } from "core-app/features/hal/resources/work-package-resource"; import { HalResource } from "core-app/features/hal/resources/hal-resource"; import { Injectable, inject } from '@angular/core'; @@ -45,6 +46,6 @@ export class WorkPackagesGitlabMrsService extends WorkPackageLinkedResourceCache } protected sortList(mergeRequests:HalResource[], attr = 'createdAt'):HalResource[] { - return _.sortBy(_.flatten(mergeRequests), attr); + return sortBy(_.flatten(mergeRequests), attr); } }