From 42c79fe19ae54f8b438d63c647df0711ac4a9f2b Mon Sep 17 00:00:00 2001 From: Tomas Hykel Date: Mon, 16 Mar 2026 21:08:23 +0100 Subject: [PATCH] switch to server-only ID length validation --- app/forms/projects/settings/editable_identifier_form.rb | 4 +--- spec/controllers/projects/identifier_controller_spec.rb | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/app/forms/projects/settings/editable_identifier_form.rb b/app/forms/projects/settings/editable_identifier_form.rb index b1e53d61d77..f929e1bd6f0 100644 --- a/app/forms/projects/settings/editable_identifier_form.rb +++ b/app/forms/projects/settings/editable_identifier_form.rb @@ -37,7 +37,6 @@ module Projects label: attribute_name(:identifier), caption: I18n.t("projects.settings.change_identifier_format_hint_semantic"), required: true, - maxlength: Project::SEMANTIC_IDENTIFIER_MAX_LENGTH, validation_message: validation_message_for(:identifier) ) else @@ -46,7 +45,6 @@ module Projects label: attribute_name(:identifier), caption: I18n.t("projects.settings.change_identifier_format_hint_legacy"), required: true, - maxlength: Project::IDENTIFIER_MAX_LENGTH, validation_message: validation_message_for(:identifier) ) end @@ -55,7 +53,7 @@ module Projects private def validation_message_for(attribute) - model.errors.messages_for(attribute).to_sentence.presence + model.errors.full_messages_for(attribute).to_sentence.presence end end end diff --git a/spec/controllers/projects/identifier_controller_spec.rb b/spec/controllers/projects/identifier_controller_spec.rb index 80fbb45a46c..e013a56683c 100644 --- a/spec/controllers/projects/identifier_controller_spec.rb +++ b/spec/controllers/projects/identifier_controller_spec.rb @@ -51,7 +51,7 @@ RSpec.describe Projects::IdentifierController do put :update, params: { project_id: project.id, project: { identifier: "bad identifier" }, format: :turbo_stream } expect(response).to have_http_status(:unprocessable_entity) - expect(response.body).to include("is invalid") + expect(response.body).to include("Identifier is invalid") expect(project.reload.identifier).to eq(previous_identifier) end end