From 37fca6901e1855948c002e0cd6a3f0e645b4bb9b Mon Sep 17 00:00:00 2001 From: Jan Sandbrink Date: Fri, 12 Jun 2026 14:54:40 +0200 Subject: [PATCH] Fix rubocop offenses in wikis module Those sneaked in most likely due to a Rubocop update. Fixing them all at once, bringing the wikis module back to formall no offenses. --- .../app/controllers/wikis/admin/health_status_controller.rb | 2 +- .../app/controllers/wikis/admin/oauth_clients_controller.rb | 2 +- .../app/controllers/wikis/admin/wiki_providers_controller.rb | 4 ++-- .../app/controllers/work_package_wikis_tab_controller.rb | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/modules/wikis/app/controllers/wikis/admin/health_status_controller.rb b/modules/wikis/app/controllers/wikis/admin/health_status_controller.rb index 53f95e59b23..ff4200de540 100644 --- a/modules/wikis/app/controllers/wikis/admin/health_status_controller.rb +++ b/modules/wikis/app/controllers/wikis/admin/health_status_controller.rb @@ -85,7 +85,7 @@ module Wikis end def find_provider - @provider = ::Wikis::Provider.visible.find(params[:wiki_provider_id]) + @provider = ::Wikis::Provider.visible.find(params.expect(:wiki_provider_id)) end def create_and_store_report diff --git a/modules/wikis/app/controllers/wikis/admin/oauth_clients_controller.rb b/modules/wikis/app/controllers/wikis/admin/oauth_clients_controller.rb index 40613992e4e..c9f65a0828c 100644 --- a/modules/wikis/app/controllers/wikis/admin/oauth_clients_controller.rb +++ b/modules/wikis/app/controllers/wikis/admin/oauth_clients_controller.rb @@ -99,7 +99,7 @@ module Wikis end def find_wiki_provider - @wiki_provider = Wikis::Provider.visible.find(params[:wiki_provider_id]) + @wiki_provider = Wikis::Provider.visible.find(params.expect(:wiki_provider_id)) end def respond_for_success diff --git a/modules/wikis/app/controllers/wikis/admin/wiki_providers_controller.rb b/modules/wikis/app/controllers/wikis/admin/wiki_providers_controller.rb index 0475bf0ce38..a084b990ba4 100644 --- a/modules/wikis/app/controllers/wikis/admin/wiki_providers_controller.rb +++ b/modules/wikis/app/controllers/wikis/admin/wiki_providers_controller.rb @@ -150,13 +150,13 @@ module Wikis end def find_wiki_provider - @wiki_provider = editable_wiki_providers.find(params[:id]) + @wiki_provider = editable_wiki_providers.find(params.expect(:id)) end def continue_from_wizard_params return if params[:continue_wizard].blank? - editable_wiki_providers.find(params[:continue_wizard]) + editable_wiki_providers.find(params.expect(:continue_wizard)) end def wiki_provider_params diff --git a/modules/wikis/app/controllers/work_package_wikis_tab_controller.rb b/modules/wikis/app/controllers/work_package_wikis_tab_controller.rb index 96483db8526..329cefccc10 100644 --- a/modules/wikis/app/controllers/work_package_wikis_tab_controller.rb +++ b/modules/wikis/app/controllers/work_package_wikis_tab_controller.rb @@ -49,6 +49,6 @@ class WorkPackageWikisTabController < ApplicationController private def set_work_package - @work_package = @project.work_packages.visible.find(params[:work_package_id]) + @work_package = @project.work_packages.visible.find(params.expect(:work_package_id)) end end