From a9cd2f730133c044f2ca709acb52e97e09802bb1 Mon Sep 17 00:00:00 2001
From: Arvin Xu <arvinx@foxmail.com>
Date: Mon, 30 Mar 2026 10:18:31 +0800
Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20refactor:=20remove=20Defau?=
 =?UTF-8?q?ltAgentForm=20UI=20from=20settings=20pages=20(#13342)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

🔥 refactor: remove DefaultAgentForm UI from settings pages

Remove the user-facing Default Agent configuration form from both
the agent settings page and the service-model settings page.
The underlying store action and selectors are preserved for
programmatic use (e.g. onboarding).

Fixes LOBE-1125

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../agent/features/DefaultAgentForm.tsx       | 68 -------------------
 src/routes/(main)/settings/agent/index.tsx    |  2 -
 .../(main)/settings/service-model/index.tsx   |  2 -
 3 files changed, 72 deletions(-)
 delete mode 100644 src/routes/(main)/settings/agent/features/DefaultAgentForm.tsx

diff --git a/src/routes/(main)/settings/agent/features/DefaultAgentForm.tsx b/src/routes/(main)/settings/agent/features/DefaultAgentForm.tsx
deleted file mode 100644
index 92c6e64511..0000000000
--- a/src/routes/(main)/settings/agent/features/DefaultAgentForm.tsx
+++ /dev/null
@@ -1,68 +0,0 @@
-'use client';
-
-import { type FormGroupItemType } from '@lobehub/ui';
-import { Form, Icon, Skeleton } from '@lobehub/ui';
-import { Form as AntForm } from 'antd';
-import { Loader2Icon } from 'lucide-react';
-import { memo, useState } from 'react';
-import { useTranslation } from 'react-i18next';
-
-import { FORM_STYLE } from '@/const/layoutTokens';
-import ModelSelect from '@/features/ModelSelect';
-import { useUserStore } from '@/store/user';
-import { settingsSelectors } from '@/store/user/selectors';
-
-const DefaultAgentForm = memo(() => {
-  const { t } = useTranslation('setting');
-  const [form] = AntForm.useForm();
-  const [loading, setLoading] = useState(false);
-
-  const [updateDefaultAgent, isUserStateInit] = useUserStore((s) => [
-    s.updateDefaultAgent,
-    s.isUserStateInit,
-  ]);
-
-  const defaultAgentConfig = useUserStore(
-    (s) => settingsSelectors.currentSettings(s).defaultAgent?.config,
-  );
-
-  if (!isUserStateInit) return <Skeleton active paragraph={{ rows: 3 }} title={false} />;
-
-  const defaultAgentSettings: FormGroupItemType = {
-    children: [
-      {
-        children: (
-          <ModelSelect
-            showAbility={false}
-            onChange={async ({ model, provider }) => {
-              setLoading(true);
-              await updateDefaultAgent({ config: { model, provider } });
-              setLoading(false);
-            }}
-          />
-        ),
-        desc: t('defaultAgent.model.desc'),
-        label: t('defaultAgent.model.title'),
-        name: 'defaultAgentConfig',
-      },
-    ],
-    extra: loading && <Icon spin icon={Loader2Icon} size={16} style={{ opacity: 0.5 }} />,
-    title: t('defaultAgent.title'),
-  };
-
-  return (
-    <Form
-      collapsible={false}
-      form={form}
-      initialValues={{ defaultAgentConfig }}
-      items={[defaultAgentSettings]}
-      itemsType={'group'}
-      variant={'filled'}
-      {...FORM_STYLE}
-    />
-  );
-});
-
-DefaultAgentForm.displayName = 'DefaultAgentForm';
-
-export default DefaultAgentForm;
diff --git a/src/routes/(main)/settings/agent/index.tsx b/src/routes/(main)/settings/agent/index.tsx
index a124a2191c..9fd5f75482 100644
--- a/src/routes/(main)/settings/agent/index.tsx
+++ b/src/routes/(main)/settings/agent/index.tsx
@@ -6,7 +6,6 @@ import { useTranslation } from 'react-i18next';
 import SettingHeader from '@/routes/(main)/settings/features/SettingHeader';
 import { featureFlagsSelectors, useServerConfigStore } from '@/store/serverConfig';
 
-import DefaultAgentForm from './features/DefaultAgentForm';
 import SystemAgentForm from './features/SystemAgentForm';
 
 const Page = () => {
@@ -15,7 +14,6 @@ const Page = () => {
   return (
     <>
       <SettingHeader title={t('tab.agent')} />
-      <DefaultAgentForm />
       <SystemAgentForm systemAgentKey="topic" />
       <SystemAgentForm systemAgentKey="generationTopic" />
       <SystemAgentForm systemAgentKey="translation" />
diff --git a/src/routes/(main)/settings/service-model/index.tsx b/src/routes/(main)/settings/service-model/index.tsx
index 13c9f9b9bc..796a09faad 100644
--- a/src/routes/(main)/settings/service-model/index.tsx
+++ b/src/routes/(main)/settings/service-model/index.tsx
@@ -6,7 +6,6 @@ import { useTranslation } from 'react-i18next';
 import SettingHeader from '@/routes/(main)/settings/features/SettingHeader';
 import { featureFlagsSelectors, useServerConfigStore } from '@/store/serverConfig';
 
-import DefaultAgentForm from '../agent/features/DefaultAgentForm';
 import SystemAgentForm from '../agent/features/SystemAgentForm';
 import Image from '../image/features/Image';
 import OpenAI from '../tts/features/OpenAI';
@@ -19,7 +18,6 @@ const Page = () => {
   return (
     <>
       <SettingHeader title={t('tab.serviceModel')} />
-      <DefaultAgentForm />
       <SystemAgentForm systemAgentKey="topic" />
       <SystemAgentForm systemAgentKey="generationTopic" />
       <SystemAgentForm systemAgentKey="translation" />