3 Commits

Author	SHA1	Message	Date
Ed Zynda	e8e99b19a8	refactor: dedupe cross-package logic and remove dead code from audit (#58) ... * Remove dead code: 5 unused symbols across internal packages - internal/models: LoadModelSettingsFromConfig (zero refs) - internal/prompts: PromptTemplate.ExpandWithArgs (zero refs) - internal/app: NewMessageStore (tests migrated to NewMessageStoreWithMessages) - internal/config: HasEnvVars (+ its test) - internal/core: ContextWithSudoPassword (test migrated to context.WithValue) * pkg/kit: use TreeManager alias in exported signatures NewTreeManagerAdapter and InitTreeSession now spell their signatures with the public kit.TreeManager alias instead of internal/session.TreeManager, so go doc renders domain types rather than internal paths. * Consolidate tool-kind classification into internal/extensions coreToolKinds + toolKindFor were duplicated verbatim in internal/extensions/wrapper.go and pkg/kit/events.go, risking silent divergence between extension events and SDK events. Single source of truth now lives in internal/extensions/toolkinds.go; pkg/kit re-exports the constants. * Consolidate Anthropic OAuth detection and usage-tracker refresh The 'is the active Anthropic credential a stored OAuth token' check was copy-pasted at 5 sites, all prefix-matching the magic string 'stored OAuth' produced in internal/auth. Now: - internal/auth: new CredentialSourceOAuth constant + IsAnthropicOAuth() - internal/ui: new UpdateUsageTrackerForModel(); CreateUsageTracker and SetupCLI share lookupTrackableModel (SetupCLI no longer re-inlines the tracker construction) - cmd/root.go + cmd/extension_context.go: verbatim-duplicated tracker refresh blocks replaced with ui.UpdateUsageTrackerForModel - pkg/kit isAnthropicOAuth delegates to auth.IsAnthropicOAuth - internal/models compares source against the constant * pkg/kit: consolidate model-path helpers and argument tokenizer - ExtractModelFromPath mis-parsed model IDs containing '/' (e.g. 'openrouter/meta/llama' -> 'meta'); it now delegates to RemoveProviderFromModel and is deprecated alongside ExtractProviderFromPath (-> GetCurrentProvider) - parseFields delegated to prompts.ParseCommandArgs so extension argument parsing and builtin prompt-template parsing share one quote/escape grammar; ParseCommandArgs now also splits on tabs (superset of both previous tokenizers) * Unify the two {{variable}} template engines internal/skills and pkg/kit/template_bridge each had their own grammar: skills rejected '{{ name }}' (whitespace) but allowed digit-first names; the bridge was the opposite. A template behaved differently depending on whether it was loaded as a skill prompt or via the extension API. internal/skills is now the single engine using the superset grammar (\{\{\s*(\w+)\s*\}\}); pkg/kit ParseTemplate/RenderTemplate are thin adapters over it. Expand is now regex-based so whitespace placeholders expand consistently; missing variables are still left as-is. * internal/ui: extract switchModel helper for model-switch flow The model-selector handler (ModelSelectedMsg) and /model slash command duplicated the full switch sequence (thinking-level fallback, setModel, display-state update, preference persistence, ModelChange emit) and had already drifted in ordering. Both now call a single switchModel method. Display state is still updated directly (no prog.Send from Update). * extbridge: extract shared BaseContext for extension wiring cmd/extension_context.go and internal/acpserver/session.go each built a giant extensions.Context literal, duplicating ~15 delegation closures (GetContextStats, GetMessages, AppendEntry, options, SetModel core, Complete, SpawnSubagent, ...) that had to be kept in sync by hand. New data-access fields had to be wired in both places or ACP-mode extensions silently got nil function fields. extbridge.BaseContext now provides the headless half; both call sites overlay only their UI-specific closures. As a side effect ACP mode gains previously-missing APIs (state, tree navigation, skills, template parsing, model resolution) that were nil before. The interactive TUI keeps its exact SetModel/ReloadExtensions ordering via overrides. * internal/tools: extract withOAuthRetry and marshalToolResult helpers ExecuteTool repeated the OAuth-error/re-auth/retry stanza verbatim twice (sync and task-augmented paths) and the marshal-and-wrap stanza four times. Both are now single helpers with identical error strings, so a fix to OAuth retry or error categorization applies everywhere at once. * internal/ui: extract buildShareFile with defer-based cleanup handleShareCommand repeated the close/remove/print/return cleanup chain four times across its temp-file write error paths. File assembly now lives in buildShareFile with a single deferred cleanup on error. * cmd: extract flag validation, preference restore, and provider-URL routing from runNormalMode runNormalMode opened with ~150 lines of policy logic (flag-combination validation, persisted model/thinking-level preference restoration, and two subtle --provider-url model-rewrite rules). These are now standalone functions (validateModeFlags, restorePersistedPreferences, applyProviderURLRouting) so the routing policy is independently readable and testable. Behaviour unchanged; ordering preserved. * fix: address review findings on SDK godoc and nil guard - pkg/kit: remove internal package paths from exported godoc on ParseTemplate and the ToolKind* constants (SDK doc surface must not reference internal packages) - internal/tools: guard marshalToolResult against a nil CallToolResult (json.Marshal(nil) succeeds as 'null', then result.IsError panics if a client returns nil result with nil error) Skipped the TreeNode Children deep-copy suggestion: the slice already comes from TreeManager.GetChildren which returns a fresh copy per call into a throwaway intermediate, so no internal state is exposed.	2026-06-11 16:13:18 +03:00
Ed Zynda	71301a9035	feat: add interactive sudo password prompt for bash tool ... Add core TUI support for handling sudo password prompts when executing bash commands that require elevated privileges. - Detect sudo commands and check if credentials are cached (sudo -n) - Show modal password prompt with masked input (• characters) when needed - Pipe password via stdin using sudo -S -p '' (no password in command string) - Password flows through context callbacks, never stored in session history - Add PasswordPromptHandler to agent and SDK event system - Add password prompt overlay to TUI with 🔐 icon and hidden input - Include tests for sudo command detection and rewriting The password is never persisted to disk - it only exists in memory during execution and is piped directly to sudo via stdin.	2026-04-15 17:33:03 +03:00
Ed Zynda	d1cffb85ef	fix: prevent bash tool from hanging on long-running/background processes ... - Use process group isolation (Setpgid) so the entire process tree is killed on timeout/cancellation, not just the direct child - Set cmd.Cancel to kill the process group (-pgid) with SIGKILL - Set cmd.WaitDelay (500ms grace period) to force-close pipes when grandchild processes hold them open after the direct child exits - Convert buffered path from cmd.Run() to explicit pipes + cmd.Start() + cmd.Wait() so WaitDelay can properly force-close pipe handles - Reorder streaming path: cmd.Wait() before wg.Wait() so the WaitDelay timer starts when the child exits, not after pipes close - Add mutex for thread-safe chunk collection in streaming mode - Add comprehensive tests for timeout, background processes, context cancellation, and both buffered/streaming paths	2026-03-24 15:13:35 +03:00