references/kit
1
0
Fork 0
mirror of https://github.com/mark3labs/kit.git synced 2026-06-14 03:30:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix legacy mcp config

Browse Source
This commit is contained in:
Ed Zynda
2025-06-25 13:15:09 +03:00
parent e5b6e7e123
commit 0972a1600a
5 changed files with 226 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
AGENTS.md
+19 -1
View File
@@ -44,6 +44,7 @@ MCPHost supports a simplified configuration schema with three server types:
- Maintains full backward compatibility with existing configurations
- Automatic detection and conversion of legacy formats
- Custom `UnmarshalJSON` method handles format migration seamlessly
- **Bug Fix**: Improved stdio transport reliability for legacy configurations with external processes (Docker, NPX, etc.)
### Transport Mapping
- `"local"` type → `stdio` transport (launches local processes)
@@ -108,4 +109,21 @@ MCPHost includes a powerful script system for automation and reusable workflows.
### Testing
- **Test Coverage**: 25+ test cases covering all variable scenarios
- **Edge Cases**: Empty defaults, complex values, mixed required/optional variables
- **Backward Compatibility**: Ensures existing scripts continue working unchanged
- **Backward Compatibility**: Ensures existing scripts continue working unchanged
## Recent Bug Fixes
### Legacy MCP Server Configuration Fix
- **Issue**: Legacy stdio transport configurations (using `command` + `args` format) were failing with timeout errors
- **Root Cause**: MCP client creation was not properly handling legacy argument parsing when `Command` array was incomplete
- **Fix**: Added fallback logic in `internal/tools/mcp.go` to use legacy `Args` field when `Command` array only contains the command
- **Impact**: Fixes Docker-based MCP servers, NPX-based servers, and other external process configurations
- **Files Modified**:
- `internal/tools/mcp.go`: Added legacy args fallback logic
- `internal/config/config.go`: Enhanced headers support for remote servers
- **Testing**: Verified with both Docker (`ghcr.io/mark3labs/phalcon-mcp:latest`) and NPX (`@modelcontextprotocol/server-filesystem`) servers
### MCP Client Initialization Improvements
- **Timeout**: Increased initialization timeout from 10s to 30s for slower external processes
- **Capabilities**: Added explicit `ClientCapabilities{}` to initialization request for better compatibility
- **Headers**: Enhanced SSE transport to support custom headers for authentication