mirror of
https://github.com/go-gitea/gitea.git
synced 2026-06-14 03:29:55 +00:00
bircni
aa63d1583d
- When the `action_task` row exists but the underlying dbfs/storage blob is gone, `OpenLogs` returns a wrapped `os.ErrNotExist` which surfaces as a 500 on the job logs endpoints. - Translate it to the same `util.NewNotExistErrorf` shape already used for unknown job ids / expired logs, so both the API (`/api/v1/repos/.../actions/jobs/<id>/logs`) and the web download handler return a clean 404 instead. Fixes #37990.
75 lines
2.0 KiB
Go
75 lines
2.0 KiB
Go
// Copyright 2025 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package common
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"io/fs"
|
|
"strings"
|
|
|
|
actions_model "gitea.dev/models/actions"
|
|
repo_model "gitea.dev/models/repo"
|
|
"gitea.dev/modules/actions"
|
|
"gitea.dev/modules/httplib"
|
|
"gitea.dev/modules/util"
|
|
"gitea.dev/services/context"
|
|
)
|
|
|
|
func DownloadActionsRunJobLogsWithID(ctx *context.Base, ctxRepo *repo_model.Repository, runID, jobID int64) error {
|
|
job, err := actions_model.GetRunJobByRunAndID(ctx, runID, jobID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if err := job.LoadRepo(ctx); err != nil {
|
|
return fmt.Errorf("LoadRepo: %w", err)
|
|
}
|
|
return DownloadActionsRunJobLogs(ctx, ctxRepo, job)
|
|
}
|
|
|
|
func DownloadActionsRunJobLogs(ctx *context.Base, ctxRepo *repo_model.Repository, curJob *actions_model.ActionRunJob) error {
|
|
if curJob.Repo.ID != ctxRepo.ID {
|
|
return util.NewNotExistErrorf("job not found")
|
|
}
|
|
|
|
taskID := curJob.EffectiveTaskID()
|
|
if taskID == 0 {
|
|
return util.NewNotExistErrorf("job not started")
|
|
}
|
|
|
|
if err := curJob.LoadRun(ctx); err != nil {
|
|
return fmt.Errorf("LoadRun: %w", err)
|
|
}
|
|
|
|
task, err := actions_model.GetTaskByID(ctx, taskID)
|
|
if err != nil {
|
|
return fmt.Errorf("GetTaskByID: %w", err)
|
|
}
|
|
|
|
if task.LogExpired {
|
|
return util.NewNotExistErrorf("logs have been cleaned up")
|
|
}
|
|
|
|
reader, err := actions.OpenLogs(ctx, task.LogInStorage, task.LogFilename)
|
|
if err != nil {
|
|
if errors.Is(err, fs.ErrNotExist) {
|
|
return util.NewNotExistErrorf("logs not found")
|
|
}
|
|
return fmt.Errorf("OpenLogs: %w", err)
|
|
}
|
|
defer reader.Close()
|
|
|
|
workflowName := curJob.Run.WorkflowID
|
|
if p := strings.Index(workflowName, "."); p > 0 {
|
|
workflowName = workflowName[0:p]
|
|
}
|
|
ctx.ServeContent(reader, context.ServeHeaderOptions{
|
|
Filename: fmt.Sprintf("%v-%v-%v.log", workflowName, curJob.Name, task.ID),
|
|
ContentLength: &task.LogSize,
|
|
ContentType: "text/plain; charset=utf-8",
|
|
ContentDisposition: httplib.ContentDispositionAttachment,
|
|
})
|
|
return nil
|
|
}
|