feat(actions): bulk delete, disable and enable runners in admin UI (#37869)

Adds bulk actions on the site-admin runner list
(`/-/admin/actions/runners`). Site admins can now select multiple
runners and **Delete**, **Disable**, or **Enable** them in one go
instead of clicking through each runner's edit page.

Scope is intentionally limited to the admin page. The user, org, and
repo runner pages keep their existing per-row UX — the shared list
template gates the bulk UI behind an `AllowBulkActions` flag set only by
the admin handler.

## Screenshots

<img width="1582" height="353"
src="https://github.com/user-attachments/assets/2125661f-aac0-4168-990a-97995a26abd2"
/>

---------

Signed-off-by: Nicolas <bircni@icloud.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
Nicolas
2026-05-29 22:16:47 +02:00
committed by GitHub
parent dafc9e127a
commit dd59c68486
6 changed files with 189 additions and 6 deletions
+72
View File
@@ -4,6 +4,7 @@
package actions
import (
stdctx "context"
"errors"
"fmt"
"net/http"
@@ -158,6 +159,7 @@ func Runners(ctx *context.Context) {
ctx.Data["RunnerOwnerID"] = opts.OwnerID
ctx.Data["RunnerRepoID"] = opts.RepoID
ctx.Data["SortType"] = opts.Sort
ctx.Data["AllowBulkActions"] = rCtx.IsAdmin
pager := context.NewPagination(count, opts.PageSize, opts.Page, 5)
@@ -362,6 +364,76 @@ func RunnerUpdatePost(ctx *context.Context) {
ctx.JSONRedirect("")
}
// RunnerBulkActionPost performs a bulk action (delete/disable/enable) on multiple runners.
// Admin-only: route must be mounted inside the admin runners group; defense-in-depth check below.
func RunnerBulkActionPost(ctx *context.Context) {
rCtx, err := getRunnersCtx(ctx)
if err != nil {
ctx.ServerError("getRunnersCtx", err)
return
}
var runnerIDs []int64
if rCtx.IsAdmin {
// ATTENTION: it completely depends on the assumption that the doer is "site admin"
// So it doesn't do extra permission check to the runner IDs
// In the future, if you need to support such operation on non-admin pages, be careful!
runnerIDs = ctx.FormStringInt64s("ids")
} else {
ctx.HTTPError(http.StatusForbidden, "bulk actions are admin-only")
return
}
action := ctx.FormString("action")
var successKey, failedKey string
switch action {
case "delete":
successKey, failedKey = "actions.runners.delete_runner_success", "actions.runners.delete_runner_failed"
case "disable":
successKey, failedKey = "actions.runners.disable_runner_success", "actions.runners.disable_runner_failed"
case "enable":
successKey, failedKey = "actions.runners.enable_runner_success", "actions.runners.enable_runner_failed"
default:
ctx.HTTPError(http.StatusBadRequest, "invalid action")
return
}
runners, err := db.Find[actions_model.ActionRunner](ctx, &actions_model.FindRunnerOptions{IDs: runnerIDs})
if err != nil {
ctx.ServerError("FindRunners", err)
return
}
err = db.WithTx(ctx, func(txCtx stdctx.Context) error {
for _, r := range runners {
switch action {
case "delete":
if err := actions_model.DeleteRunner(txCtx, r.ID); err != nil {
return err
}
case "disable":
if err := actions_model.SetRunnerDisabled(txCtx, r, true); err != nil {
return err
}
case "enable":
if err := actions_model.SetRunnerDisabled(txCtx, r, false); err != nil {
return err
}
}
}
return nil
})
if err != nil {
log.Warn("RunnerBulkActionPost.%s failed: %v, url: %s", action, err, ctx.Req.URL)
ctx.Flash.Error(ctx.Tr(failedKey))
ctx.JSONRedirect(rCtx.RedirectLink)
return
}
ctx.Flash.Success(ctx.Tr(successKey))
ctx.JSONRedirect(rCtx.RedirectLink)
}
func findActionsRunner(ctx *context.Context, rCtx *runnersCtx) *actions_model.ActionRunner {
runnerID := ctx.PathParamInt64("runnerid")
opts := &actions_model.FindRunnerOptions{
+1
View File
@@ -863,6 +863,7 @@ func registerWebRoutes(m *web.Router, webAuth *AuthMiddleware) {
m.Group("/actions", func() {
m.Get("", misc.LocationRedirect("./actions/runners"))
addSettingsRunnersRoutes()
m.Post("/runners/bulk", shared_actions.RunnerBulkActionPost)
addSettingsVariablesRoutes()
})
}, adminReq, ctxDataSet("EnableOAuth2", setting.OAuth2.Enabled, "EnablePackages", setting.Packages.Enabled))