From 0f76d8f3851bbc05de18051692ffedcce4e2e037 Mon Sep 17 00:00:00 2001 From: Mauricio Siu <47042324+Siumauricio@users.noreply.github.com> Date: Sun, 7 Jun 2026 00:12:08 -0600 Subject: [PATCH] refactor: improve restore logging for database backups (#4566) * refactor: improve restore logging for database backups - Updated restore functions across various database types (Postgres, MySQL, MongoDB, MariaDB, LibSQL, and Compose) to provide clearer logging messages. - Replaced generic command execution logs with specific messages indicating the database being restored and the source backup file. - This change enhances the clarity of restore operations and aids in troubleshooting by providing more context in the logs. * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> --- packages/server/src/utils/restore/compose.ts | 6 +++--- packages/server/src/utils/restore/libsql.ts | 6 ++---- packages/server/src/utils/restore/mariadb.ts | 5 +++-- packages/server/src/utils/restore/mongo.ts | 5 +++-- packages/server/src/utils/restore/mysql.ts | 5 +++-- packages/server/src/utils/restore/postgres.ts | 8 ++++---- 6 files changed, 18 insertions(+), 17 deletions(-) diff --git a/packages/server/src/utils/restore/compose.ts b/packages/server/src/utils/restore/compose.ts index 20cac27fb..946c94a38 100644 --- a/packages/server/src/utils/restore/compose.ts +++ b/packages/server/src/utils/restore/compose.ts @@ -77,9 +77,9 @@ export const restoreComposeBackup = async ( }); emit("Starting restore..."); - emit(`Backup path: ${backupPath}`); - - emit(`Executing command: ${restoreCommand}`); + emit( + `Restoring database: ${backupInput.databaseName} from ${backupInput.backupFile}`, + ); if (serverId) { await execAsyncRemote(serverId, restoreCommand); diff --git a/packages/server/src/utils/restore/libsql.ts b/packages/server/src/utils/restore/libsql.ts index e984826f8..f50f0c6da 100644 --- a/packages/server/src/utils/restore/libsql.ts +++ b/packages/server/src/utils/restore/libsql.ts @@ -21,15 +21,13 @@ export const restoreLibsqlBackup = async ( const rcloneCommand = `rclone cat ${rcloneFlags.join(" ")} "${backupPath}"`; - emit("Starting restore..."); - emit(`Backup path: ${backupPath}`); - const containerSearch = getServiceContainerCommand(appName); const restoreCommand = `docker exec -i $CONTAINER_ID sh -c "tar xzf - -C /var/lib/sqld"`; const command = `CONTAINER_ID=$(${containerSearch}) && ${rcloneCommand} | ${restoreCommand}`; - emit(`Executing command: ${command}`); + emit("Starting restore..."); + emit(`Restoring libsql from ${backupInput.backupFile}`); if (serverId) { await execAsyncRemote(serverId, command); diff --git a/packages/server/src/utils/restore/mariadb.ts b/packages/server/src/utils/restore/mariadb.ts index ffbceba76..afa167280 100644 --- a/packages/server/src/utils/restore/mariadb.ts +++ b/packages/server/src/utils/restore/mariadb.ts @@ -34,8 +34,9 @@ export const restoreMariadbBackup = async ( }); emit("Starting restore..."); - - emit(`Executing command: ${command}`); + emit( + `Restoring database: ${backupInput.databaseName} from ${backupInput.backupFile}`, + ); if (serverId) { await execAsyncRemote(serverId, command); diff --git a/packages/server/src/utils/restore/mongo.ts b/packages/server/src/utils/restore/mongo.ts index 4329a4985..91eb9af5a 100644 --- a/packages/server/src/utils/restore/mongo.ts +++ b/packages/server/src/utils/restore/mongo.ts @@ -34,8 +34,9 @@ export const restoreMongoBackup = async ( }); emit("Starting restore..."); - - emit(`Executing command: ${command}`); + emit( + `Restoring database: ${backupInput.databaseName} from ${backupInput.backupFile}`, + ); if (serverId) { await execAsyncRemote(serverId, command); diff --git a/packages/server/src/utils/restore/mysql.ts b/packages/server/src/utils/restore/mysql.ts index f5187242c..c955ef960 100644 --- a/packages/server/src/utils/restore/mysql.ts +++ b/packages/server/src/utils/restore/mysql.ts @@ -33,8 +33,9 @@ export const restoreMySqlBackup = async ( }); emit("Starting restore..."); - - emit(`Executing command: ${command}`); + emit( + `Restoring database: ${backupInput.databaseName} from ${backupInput.backupFile}`, + ); if (serverId) { await execAsyncRemote(serverId, command); diff --git a/packages/server/src/utils/restore/postgres.ts b/packages/server/src/utils/restore/postgres.ts index 19f32989f..8cbbe2175 100644 --- a/packages/server/src/utils/restore/postgres.ts +++ b/packages/server/src/utils/restore/postgres.ts @@ -22,9 +22,6 @@ export const restorePostgresBackup = async ( const rcloneCommand = `rclone cat ${rcloneFlags.join(" ")} "${backupPath}" | gunzip`; - emit("Starting restore..."); - emit(`Backup path: ${backupPath}`); - const command = getRestoreCommand({ appName, credentials: { @@ -36,7 +33,10 @@ export const restorePostgresBackup = async ( restoreType: "database", }); - emit(`Executing command: ${command}`); + emit("Starting restore..."); + emit( + `Restoring database: ${backupInput.databaseName} from ${backupInput.backupFile}`, + ); if (serverId) { await execAsyncRemote(serverId, command);